glenn schrooyenandClaude Opus 5.5 bbbc89b235 MAINT-20 part 2 review: comment-only fixes in main.py and the MAIN notes ...

- check_peak_floor_limited: restore the SAFETY-25 line (the reserve sentence is
  in messages.peak_reserve() on every branch, unreadable SoC included).
- Three status-page comments that no longer said anything (SAFETY-20 row,
  AC 5 delivery row, banner-vs-text) now say their rule in one line.
- tariff_refresh_wanted docstring: no orphan "TARIFF-24)" line.
- MAIN-orchestration.md: blank line before the first heading.
- MAIN-orchestration-archive.md: refilled intro; says how to find a section
  from a main.py pointer.

No code change: maint20_same_code.py 16029d7 -> SAME CODE, -OO same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-11-08 19:25:37 +01:00

..

app

MAINT-20 part 2 review: comment-only fixes in main.py and the MAIN notes

2026-11-08 19:25:37 +01:00

DECISIONS

MAINT-20 part 2 review: comment-only fixes in main.py and the MAIN notes

2026-11-08 19:25:37 +01:00

scenarios

OPT-11 P4: solar forecast and day plan

2026-09-29 19:29:32 +02:00

tools

Merge release/1.0 (16029d7) into MAINT-20-2

2026-11-08 17:28:03 +01:00

translations

SMA-2 round 2: keep the driver keys out of the schema, translations and labels

2026-11-07 13:09:31 +01:00

build.yaml

Packaged as a Home Assistant add-on, with a field guide

2026-08-23 01:15:25 +02:00

CHANGELOG.md

Release 0.21.0: CHANGELOG wording (SAFETY-136, SAFETY-138 known issues)

2026-11-08 10:20:46 +01:00

config.yaml

Release 0.21.0: version bump and CHANGELOG

2026-11-08 09:08:59 +01:00

Dockerfile

Six silent failures found by installing this on a live system

2026-08-23 02:25:58 +02:00

DOCS.md

OPT-36 round 3: B's charge counts the cheap time left; OPT-34 nights on their own shapes

2026-11-02 10:15:20 +01:00

MUTATION.md

TEL-12: several PV inverters, and one absent member is an absent TOTAL

2026-09-24 22:13:25 +02:00

named_absence.py

TEST-26: a missing value in a check is a named FAIL, not a traceback

2026-09-25 00:06:58 +02:00

requirements.txt

Six silent failures found by installing this on a live system

2026-08-23 02:25:58 +02:00

run.sh

Six silent failures found by installing this on a live system

2026-08-23 02:25:58 +02:00

test_alloc.py

OPT-11 P1: per-battery mode limits, on/off, solar order

2026-09-28 18:51:29 +02:00

test_arbiter.py

SAFETY-86 review: hold the site at the peak floor while a HOLD gives

2026-10-01 02:00:20 +02:00

test_arbitrage.py

SAFETY-125: a grid charge counts a late meter reading's seconds; the guard row says "over" when it is

2026-10-29 02:08:38 +01:00

test_batteries_screen.py

OPT-36: Leftover solar counts what Cheap hours and Solar first batteries will give before buying

2026-11-02 02:03:04 +01:00

test_bytecode.py

TEST-15: purge the bytecode cache before a mutation run, not after

2026-09-01 02:07:09 +02:00

test_ci_gate.py

TOOL-9: pin checks print their FAIL line under pipefail; job tokens via header

2026-09-25 19:07:34 +02:00

test_clamp.py

SAFETY-94: a healthy battery that lags or reverses is not flagged as frozen or refusing

2026-10-04 00:15:42 +02:00

test_control_task.py

UX-08 2d: plain log lines, the rest of the status page, and DOCS

2026-09-27 08:01:16 +02:00

test_control.py

OPT-11 P1 review: a mode never beats the peak floor; SAFETY-03 kept at the rail

2026-09-28 19:41:36 +02:00

test_defaults_pin.py

TARIFF-15: your own tariff card, as two coefficients the card itself grades

2026-09-13 03:49:08 +02:00

test_delivery.py

SAFETY-73 review: a refusal needs 22 s of evidence, and the cut-out warning is for giving only

2026-09-28 02:16:24 +02:00

test_docs.py

DOC-1: operator docs name the real P1 entity and a roster that starts

2026-09-24 23:24:50 +02:00

test_freeze.py

UX-08 phase 2b: short, plain status rows and page banners

2026-09-27 02:12:10 +02:00

test_freshness.py

SMA-2: each inverter is reached through a driver; GoodWe behaviour unchanged

2026-11-07 11:28:47 +01:00

test_haentities.py

UX-13 P2: the Installer settings view

2026-09-28 02:49:58 +02:00

test_home.py

UX-54: a Forecast tab with the sun, the house and each battery's level, per hour

2026-10-26 19:38:59 +01:00

test_inverter.py

SMA-2 round 2: keep the driver keys out of the schema, translations and labels

2026-11-07 13:09:31 +01:00

test_loop.py

SAFETY-39: slew_w is a ratio to the rail, and gain is what is still wrong

2026-09-06 01:10:15 +02:00

test_maint10.py

MAINT-10 review: warn when HA did not answer and TZ is UTC; test the 3 s budget

2026-10-05 23:24:02 +02:00

test_maint11.py

MAINT-11 review round 2: pin each cycle button to its own disabled flag

2026-10-14 00:39:37 +02:00

test_maint13.py

PRICE-01 review 3: tests for the round 3 note and dismiss; doc wording

2026-10-14 22:07:09 +02:00

test_maint14.py

MAINT-15: the balancing hold ends on time with no SoC reading

2026-10-09 23:56:29 +02:00

test_maint15.py

MAINT-15 round 2: in-repo differential check, full-hold with-reading check

2026-10-10 00:42:01 +02:00

test_maintenance.py

MAINT-14: maintenance with no SoC reading: charge times out, drain holds at 0 W

2026-10-08 20:37:01 +02:00

test_messages.py

SMA-10 round 2: a failed release sends 0 W once, retries at heartbeat pace

2026-11-07 20:17:01 +01:00

test_modes_p3.py

PRICE-02 round 2: require now, undo the test loosening, analyse ties

2026-10-22 10:37:43 +02:00

test_modes_p4.py

OPT-34 round 3: the latch ends on time, with the run, with the mode, and with the night

2026-10-31 23:04:36 +01:00

test_modes.py

SAFETY-95: a maintenance drain that ends hands back smoothly (N>=2)

2026-10-06 12:44:25 +02:00

test_mqtt.py

DOC-8: update test_mqtt digest pins for the new manufacturer string

2026-10-17 02:16:34 +02:00

test_named_absence.py

TEST-26: a missing value in a check is a named FAIL, not a traceback

2026-09-25 00:06:58 +02:00

test_opt17.py

OPT-17 review: title the forecast row on Home; test the hint and blank rows

2026-10-11 05:12:35 +02:00

test_opt20.py

SAFETY-125: a grid charge counts a late meter reading's seconds; the guard row says "over" when it is

2026-10-29 02:08:38 +01:00

test_opt23_28.py

OPT-36 round 4: count only charge control will make; Solar first drain at the night base

2026-11-02 12:56:17 +01:00

test_opt27.py

OPT-38 round 2: a kept tomorrow reading is flagged kept only from 20:00

2026-11-07 06:02:00 +01:00

test_opt34.py

OPT-38 round 2: a kept tomorrow reading is flagged kept only from 20:00

2026-11-07 06:02:00 +01:00

test_opt36.py

OPT-36 round 4: count only charge control will make; Solar first drain at the night base

2026-11-02 12:56:17 +01:00

test_opt38.py

OPT-38 round 2: a kept tomorrow reading is flagged kept only from 20:00

2026-11-07 06:02:00 +01:00

test_p1.py

UX-08 phase 2b: short, plain status rows and page banners

2026-09-27 02:12:10 +02:00

test_packshare.py

TEST-26: a missing value in a check is a named FAIL, not a traceback

2026-09-25 00:06:58 +02:00

test_peak_margin.py

SAFETY-85: no false 'not keeping up' while maintenance or the peak guard sets the battery

2026-10-01 19:05:27 +02:00

test_peakguard.py

SAFETY-128: control does not act on late Home Assistant readings

2026-11-01 23:45:03 +01:00

test_price02.py

PRICE-02 round 3: say that hourly and static plans change too, test plans built off the hour, exact period end and the Home page path, production-shaped real-year replay

2026-10-22 14:59:13 +02:00

test_price_forecast.py

PRICE-02 round 2: require now, undo the test loosening, analyse ties

2026-10-22 10:37:43 +02:00

test_price_history.py

PRICE-02 round 2: require now, undo the test loosening, analyse ties

2026-10-22 10:37:43 +02:00

test_price_run_fixes.py

SAFETY-125: a grid charge counts a late meter reading's seconds; the guard row says "over" when it is

2026-10-29 02:08:38 +01:00

test_price_secret.py

PRICE-01 review 3: tests for the round 3 note and dismiss; doc wording

2026-10-14 22:07:09 +02:00

test_price_service.py

PRICE-02 round 2: require now, undo the test loosening, analyse ties

2026-10-22 10:37:43 +02:00

test_price.py

PRICE-02 round 2: require now, undo the test loosening, analyse ties

2026-10-22 10:37:43 +02:00

test_pv.py

UX-13 P1: page shell and Home screen on a structured /status

2026-09-28 00:45:01 +02:00

test_refusal_units.py

SAFETY-73 review: a refusal needs 22 s of evidence, and the cut-out warning is for giving only

2026-09-28 02:16:24 +02:00

test_refusal.py

SAFETY-52 review: a refusal is under 100 W, and any delivery ends it

2026-09-27 18:11:42 +02:00

test_rehearse.py

SAFETY-60/62: operator tools refuse input they cannot read

2026-09-24 23:27:50 +02:00

test_safety78.py

SAFETY-96: a battery the loop cannot move does not freeze it

2026-10-06 04:02:03 +02:00

test_safety81.py

Merge release/1.0 (e3e4ba6) into opt15-price-run-fixes

2026-10-13 12:15:44 +02:00

test_safety83.py

SAFETY-86: peak guard outranks the maintenance hold

2026-10-01 00:56:34 +02:00

test_safety84.py

SAFETY-125 round 2: the one-inverter maintenance charge is sized to the room too

2026-10-29 14:57:39 +01:00

test_safety85.py

SAFETY-85 review: grade discharge only, over the plant's settle time

2026-10-01 20:25:41 +02:00

test_safety86.py

SAFETY-85: no false 'not keeping up' while maintenance or the peak guard sets the battery

2026-10-01 19:05:27 +02:00

test_safety87.py

SAFETY-125 round 2: the one-inverter maintenance charge is sized to the room too

2026-10-29 14:57:39 +01:00

test_safety90.py

SAFETY-90 review: test that a second gap does not price the first one down

2026-10-05 12:39:28 +02:00

test_safety91.py

SAFETY-91 review: a held-back battery is released 1 point above its reserve

2026-10-02 14:54:20 +02:00

test_safety93.py

MAINT-13 round 3: provider site, hourly fixed-tariff check, faster tests

2026-10-08 12:03:55 +02:00

test_safety94.py

SAFETY-128: control does not act on late Home Assistant readings

2026-11-01 23:45:03 +01:00

test_safety95.py

SAFETY-95 review: test the stale-link and contradiction legs; refusal +1 only

2026-10-07 16:41:16 +02:00

test_safety96.py

SAFETY-128: control does not act on late Home Assistant readings

2026-11-01 23:45:03 +01:00

test_safety97.py

SAFETY-97: centre the band on the idle reading clamped to 75 W

2026-10-04 16:57:16 +02:00

test_safety103.py

SAFETY-103: test a dropped battery is not counted; guard a read

2026-10-08 03:12:03 +02:00

test_safety107.py

SAFETY-107 review: test a writer that turns round on a dead pack; say when rule 3 applies

2026-10-09 03:52:39 +02:00

test_safety112.py

SAFETY-112 review: grade the waiting flag where hass.py sets it

2026-10-13 02:10:27 +02:00

test_safety118.py

SAFETY-118: a missing peak forecast reading keeps the unit-fault state

2026-10-16 18:19:44 +02:00

test_safety119.py

SAFETY-125 round 2: the one-inverter maintenance charge is sized to the room too

2026-10-29 14:57:39 +01:00

test_safety123.py

SAFETY-123: the day plan's hour loop steps in UTC and always ends

2026-10-27 08:58:54 +01:00

test_safety125.py

SAFETY-125 round 2: the one-inverter maintenance charge is sized to the room too

2026-10-29 14:57:39 +01:00

test_safety126.py

SAFETY-126 round 2: state what the 10 W tolerance costs; test the latch reset

2026-10-31 11:52:27 +01:00

test_safety128.py

SAFETY-129 round 2: shorter test_safety129, pinned 5 s row, 100 s bound

2026-11-06 21:24:37 +01:00

test_safety129.py

SAFETY-129 round 3: the real reason for the 16 s limit, a slow-start check, the row's tail

2026-11-07 00:12:33 +01:00

test_safety137_last_write.py

SAFETY-137: the shutdown and Stop 0 W is the last write every unit hears

2026-11-08 02:39:38 +01:00

test_selfconfig.py

UX-54: a Forecast tab with the sun, the house and each battery's level, per hour

2026-10-26 19:38:59 +01:00

test_settings.py

UX-13 P4: the setup wizard for installers

2026-09-28 05:31:18 +02:00

test_setup_only.py

PRICE-01 review 3: tests for the round 3 note and dismiss; doc wording

2026-10-14 22:07:09 +02:00

test_setup.py

OPT-11 P3 option A review: wizard no longer says modes come later

2026-09-29 11:21:32 +02:00

test_sma2_driver.py

SMA-2 round 2: keep the driver keys out of the schema, translations and labels

2026-11-07 13:09:31 +01:00

test_sma10_two_idle_states.py

SAFETY-137: the shutdown and Stop 0 W is the last write every unit hears

2026-11-08 02:39:38 +01:00

test_static_tariff.py

PRICE-02 round 2: require now, undo the test loosening, analyse ties

2026-10-22 10:37:43 +02:00

test_tariff24_weather.py

OPT-27: the night plan keeps the last fresh solar forecast

2026-10-30 18:54:41 +01:00

test_tariff24.py

TARIFF-24: test file follows the repo's suite rules (MUTATION.md pointer, named absence)

2026-10-28 01:09:39 +01:00

test_tariff.py

UX-10: the last plain-language leftovers: log lines, two table rows, 'Why: Other', red at 0 s

2026-09-27 10:58:43 +02:00

test_telemetry.py

SAFETY-48: what the lead cap actually does to a frozen integrator, and what the peak figure depends on

2026-09-19 02:37:01 +02:00

test_tool_inputs.py

UX-08 2c: short refusals, error texts and option texts

2026-09-27 05:55:45 +02:00

test_translations.py

SMA-2 round 2: keep the driver keys out of the schema, translations and labels

2026-11-07 13:09:31 +01:00

test_ui_text.py

UX-44: contract label says every 15 minutes, not hourly

2026-10-16 05:26:32 +02:00

test_uilayout.py

SMA-2 round 2: keep the driver keys out of the schema, translations and labels

2026-11-07 13:09:31 +01:00

test_uimodel.py

UX-43: tariff price fields take five decimals

2026-10-16 01:40:40 +02:00

test_ux46.py

UX-46: test_ux46 points at MUTATION.md and reads rows without raising

2026-10-22 03:41:18 +02:00

test_ux53.py

UX-53: Home draws a grid charge only where the add-on will take it

2026-10-26 11:15:29 +01:00

test_ux54_dst.py

UX-54 round 5: test_ux54_dst.py points at MUTATION.md (test_bytecode.py)

2026-10-27 16:19:07 +01:00

test_ux54.py

UX-77: Home draws today's grid charge for the hours control will really charge

2026-11-05 21:48:56 +01:00

test_ux77.py

UX-77: Home's roll shares the peak room by room left to full, as control does

2026-11-06 09:11:00 +01:00

test_validate.py

UX-13 P0: layout table, page<->options derivation, warning tier, entity list

2026-09-27 23:11:31 +02:00

test_version_gate.py

UX-08 2c: short refusals, error texts and option texts

2026-09-27 05:55:45 +02:00

test_watchdog.py

PRICE-01 review 3: tests for the round 3 note and dismiss; doc wording

2026-10-14 22:07:09 +02:00

ux08_allowlist.txt

UX-08 2d: plain log lines, the rest of the status page, and DOCS

2026-09-27 08:01:16 +02:00