MAINT-11 review round 2: pin each cycle button to its own disabled flag
Reviewer mutations survived the round-2 page checks: Start forced always disabled (|| true), and the two flags swapped between Start and Stop, because the checks only looked for each flag somewhere in the file. The check now pins each flag to its own button. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -372,6 +372,9 @@ check("Start is disabled while any battery cycles",
|
||||
and "disabled: !can.start" in JS)
|
||||
check("Start is disabled on a switched-off battery (use false, modes on)",
|
||||
"&& b.use !== false, abort" in JS)
|
||||
check("each button carries its own flag, and only that flag",
|
||||
'id: "bcs-" + i, disabled: !can.start, onclick: ask1("start_dialog"' in JS
|
||||
and 'id: "bca-" + i, disabled: !can.abort, onclick: ask1("abort_dialog"' in JS)
|
||||
check("a battery counts as cycling when its phase is not idle",
|
||||
'cycling = (x) => x.maintenance !== "idle"' in JS)
|
||||
check("the old header buttons still post a bare request",
|
||||
|
||||
Reference in New Issue
Block a user