The add-on is wired to the inverter's RS485 port labelled EMS, not METER. Rewords README, DOCS.md, config.yaml description, main.py docstring, field guide source (build_guide.py) and field-guide.html. No behaviour change, no CHANGELOG/version change.
HA manufacturer string (mqtt.py:32) left unchanged: test_mqtt.py byte-pins it in BASELINE. Field-guide PDF not rebuilt (already outdated).
The add-on is wired to the inverter's RS485 port labelled EMS, not METER. Rewords README, DOCS.md, config.yaml description, main.py docstring, field guide source (build_guide.py) and field-guide.html. No behaviour change, no CHANGELOG/version change.
HA manufacturer string (mqtt.py:32) left unchanged: test_mqtt.py byte-pins it in BASELINE. Field-guide PDF not rebuilt (already outdated).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC
The add-on is wired to the inverter's RS485 port labelled EMS. Reword
README, DOCS, config description, field guide source and HTML. The HA
manufacturer string is left unchanged: test_mqtt pins it byte for byte.
Co-Authored-By: Claude <noreply@anthropic.com>
Device id (identifiers) is unchanged; only the display text moves.
test_mqtt baseline updated for that one string.
Co-Authored-By: Claude <noreply@anthropic.com>
Both digests hash the discovery payloads, which carry the manufacturer.
Values regenerated; nothing else changes.
Co-Authored-By: Claude <noreply@anthropic.com>
README and FIELD-GUIDE.md said the PDF was not rebuilt; it was, on
2026-10-17. Its content is still v0.1.0 and outdated. Rewrap the
DOCS.md intro line. Text only.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DOC-8 review (head reviewed b8b357b, plus reviewer text fix a4a7ff6)
Checks:
Wording: every changed sentence says the EMS port and is true; the mechanism (a made-up grid reading over that port) is unchanged. Short and plain.
Manufacturer: putting the old string back in app/mqtt.py:32 gives back the old pins exactly (eb5022b0455158d7, 501a7d93782a260b). So the new pins differ only by that string. The device id goodwe_rs485_controller is unchanged. With the old string, test_mqtt fails (15 checks).
PDF: rebuilding with the unmodified docs/build_guide.py (Linux Chrome path swapped in a scratch wrapper) gives a field-guide.html identical to the committed one. The PDF has 10 pages and the same words as the committed PDF. It has no "meter port" or "meter bus" text.
No code behaviour change. No CHANGELOG or version change.
Findings:
Low, fixed in a4a7ff6: README.md:33 and FIELD-GUIDE.md:7-9 said the PDF was not rebuilt. They now say it was rebuilt on 2026-10-17 and its content is still v0.1.0 and outdated.
Nit, fixed in a4a7ff6: goodwe_controller/DOCS.md:4 was an over-long line. Rewrapped it; the text did not change.
Info, left: HANDOVER.md:169 "a G2 unit's meter bus" is about an unsupported G2 unit, not our wiring.
Info, left: "meter emulation" is the name of the mechanism in app/allocator.py:4, test_alloc.py:4 and CHANGELOG history. These sentences are true.
Info, left: "no meter-timeout" (README, DOCS, guide) means the reading has no timeout. It does not name a port.
Info, existing before this PR: docs/build_guide.py:24 has a Windows Chrome path, and the URL it builds at :531 only works on Windows. FIELD-GUIDE.md already says this. Out of scope.
**DOC-8 review (head reviewed b8b357b, plus reviewer text fix a4a7ff6)**
Checks:
- Wording: every changed sentence says the EMS port and is true; the mechanism (a made-up grid reading over that port) is unchanged. Short and plain.
- Manufacturer: putting the old string back in `app/mqtt.py:32` gives back the old pins exactly (`eb5022b0455158d7`, `501a7d93782a260b`). So the new pins differ only by that string. The device id `goodwe_rs485_controller` is unchanged. With the old string, test_mqtt fails (15 checks).
- PDF: rebuilding with the unmodified `docs/build_guide.py` (Linux Chrome path swapped in a scratch wrapper) gives a `field-guide.html` identical to the committed one. The PDF has 10 pages and the same words as the committed PDF. It has no "meter port" or "meter bus" text.
- No code behaviour change. No CHANGELOG or version change.
Findings:
- Low, fixed in a4a7ff6: `README.md:33` and `FIELD-GUIDE.md:7-9` said the PDF was not rebuilt. They now say it was rebuilt on 2026-10-17 and its content is still v0.1.0 and outdated.
- Nit, fixed in a4a7ff6: `goodwe_controller/DOCS.md:4` was an over-long line. Rewrapped it; the text did not change.
- Info, left: `HANDOVER.md:169` "a G2 unit's meter bus" is about an unsupported G2 unit, not our wiring.
- Info, left: "meter emulation" is the name of the mechanism in `app/allocator.py:4`, `test_alloc.py:4` and CHANGELOG history. These sentences are true.
- Info, left: "no meter-timeout" (README, DOCS, guide) means the reading has no timeout. It does not name a port.
- Info, existing before this PR: `docs/build_guide.py:24` has a Windows Chrome path, and the URL it builds at :531 only works on Windows. FIELD-GUIDE.md already says this. Out of scope.
admin
merged commit 243a756e7b into release/1.02026-10-17 04:09:34 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The add-on is wired to the inverter's RS485 port labelled EMS, not METER. Rewords README, DOCS.md, config.yaml description, main.py docstring, field guide source (build_guide.py) and field-guide.html. No behaviour change, no CHANGELOG/version change.
HA manufacturer string (mqtt.py:32) left unchanged: test_mqtt.py byte-pins it in BASELINE. Field-guide PDF not rebuilt (already outdated).
🤖 Generated with Claude Code
https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC
DOC-8 review (head reviewed
b8b357b, plus reviewer text fixa4a7ff6)Checks:
app/mqtt.py:32gives back the old pins exactly (eb5022b0455158d7,501a7d93782a260b). So the new pins differ only by that string. The device idgoodwe_rs485_controlleris unchanged. With the old string, test_mqtt fails (15 checks).docs/build_guide.py(Linux Chrome path swapped in a scratch wrapper) gives afield-guide.htmlidentical to the committed one. The PDF has 10 pages and the same words as the committed PDF. It has no "meter port" or "meter bus" text.Findings:
a4a7ff6:README.md:33andFIELD-GUIDE.md:7-9said the PDF was not rebuilt. They now say it was rebuilt on 2026-10-17 and its content is still v0.1.0 and outdated.a4a7ff6:goodwe_controller/DOCS.md:4was an over-long line. Rewrapped it; the text did not change.HANDOVER.md:169"a G2 unit's meter bus" is about an unsupported G2 unit, not our wiring.app/allocator.py:4,test_alloc.py:4and CHANGELOG history. These sentences are true.docs/build_guide.py:24has a Windows Chrome path, and the URL it builds at :531 only works on Windows. FIELD-GUIDE.md already says this. Out of scope.