• Joined on 2025-08-30
admin pushed to release/1.0 at admin/goodwe-addon 2026-10-21 12:41:13 +02:00
e077ae7f97 Merge pull request 'SAFETY-121: a recurring overload warns every quarter' (#204) from SAFETY-121 into release/1.0
24f31a9c3a SAFETY-121 review: DECISIONS limits state the jitter spread and the slow-cycle case
8bf25696cb SAFETY-121: a recurring overload warns every quarter
Compare 3 commits »
admin merged pull request admin/goodwe-addon#204 2026-10-21 12:41:12 +02:00
SAFETY-121: a recurring overload warns every quarter
admin commented on pull request admin/goodwe-addon#204 2026-10-21 12:40:27 +02:00
SAFETY-121: a recurring overload warns every quarter

**Review (Opus) of 8bf2569: right. I pushed a text-only fix as 24f31a9 (DECISIONS limits and PR body); CI run 1363 checks / unit 80/80 and 1364 infra-pin / fresh are green on it. Merging…

admin pushed to SAFETY-121 at admin/goodwe-addon 2026-10-21 11:55:26 +02:00
24f31a9c3a SAFETY-121 review: DECISIONS limits state the jitter spread and the slow-cycle case
admin created pull request admin/goodwe-addon#204 2026-10-21 10:09:56 +02:00
SAFETY-121: a recurring overload warns every quarter
admin pushed to SAFETY-121 at admin/goodwe-addon 2026-10-21 10:09:25 +02:00
8bf25696cb SAFETY-121: a recurring overload warns every quarter
admin created branch SAFETY-121 in admin/goodwe-addon 2026-10-21 10:09:25 +02:00
admin pushed to release/1.0 at admin/goodwe-addon 2026-10-21 03:32:41 +02:00
bee7431793 Merge pull request 'SAFETY-119: no "not keeping up" when the loop takes the wire back' (#203) from SAFETY-119 into release/1.0
96375ecbec SAFETY-119 review: DECISIONS states the steady-meter limit
6fd0fa05f1 SAFETY-119 round 3c: the hidden-bound budget follows the cycle length
e27e62ff72 SAFETY-119 round 3b: no-clock budget, fixed-seed tests, accepted limits
86b94bedb5 SAFETY-119 round 3: DECISIONS table ranges over all runs
Compare 12 commits »
admin merged pull request admin/goodwe-addon#203 2026-10-21 03:32:39 +02:00
SAFETY-119: no "not keeping up" when the loop takes the wire back
admin commented on pull request admin/goodwe-addon#203 2026-10-21 03:31:57 +02:00
SAFETY-119: no "not keeping up" when the loop takes the wire back

Review round 3 of SAFETY-119, head 6fd0fa0 (then 96375ec)

Verdict: right. Merging at 96375ec (the dev's 6fd0fa0 plus my text-only commit). The owner accepted the rule-shape change in…

admin pushed to SAFETY-119 at admin/goodwe-addon 2026-10-21 02:47:31 +02:00
96375ecbec SAFETY-119 review: DECISIONS states the steady-meter limit
admin pushed to SAFETY-119 at admin/goodwe-addon 2026-10-21 01:41:54 +02:00
6fd0fa05f1 SAFETY-119 round 3c: the hidden-bound budget follows the cycle length
admin pushed to SAFETY-119 at admin/goodwe-addon 2026-10-20 20:46:17 +02:00
e27e62ff72 SAFETY-119 round 3b: no-clock budget, fixed-seed tests, accepted limits
admin pushed to SAFETY-119 at admin/goodwe-addon 2026-10-20 17:28:25 +02:00
86b94bedb5 SAFETY-119 round 3: DECISIONS table ranges over all runs
admin pushed to SAFETY-119 at admin/goodwe-addon 2026-10-20 17:27:46 +02:00
103db2fcda SAFETY-119 round 3: rolling 15-minute budget for the hidden integrator bound
admin commented on pull request admin/goodwe-addon#203 2026-10-20 03:17:05 +02:00
SAFETY-119: no "not keeping up" when the loop takes the wire back

Review round 2 of SAFETY-119, head 85542e4

Verdict: needs changes. Not merged. The owner asked for at least one warning per 15-minute period. At a 10 s or 15 s meter cycle, the "never"…

admin pushed to SAFETY-119 at admin/goodwe-addon 2026-10-20 01:38:26 +02:00
85542e443b SAFETY-119 round 2: test_safety119 reads through named_absence
admin pushed to SAFETY-119 at admin/goodwe-addon 2026-10-20 00:52:26 +02:00
e76c70ecb0 SAFETY-119 round 2: one settle window per run of hand-backs
admin commented on pull request admin/goodwe-addon#203 2026-10-19 21:42:02 +02:00
SAFETY-119: no "not keeping up" when the loop takes the wire back

Review of SAFETY-119

Verdict: ready to merge at b9ff6ac, once the owner accepts the trade-off below. Not merged. CI is green on b9ff6ac: unit run 1344 (80/80) and infra-pin run…

admin pushed to SAFETY-119 at admin/goodwe-addon 2026-10-19 20:29:04 +02:00
b9ff6acea4 SAFETY-119 review: DECISIONS, at least once a quarter