EV-16: hold the Car Why text while the guard floor flag toggles #266

Merged
admin merged 4 commits from EV-16 into release/1.0 2026-11-21 16:08:08 +01:00
Collaborator

EV-16: the Car Why no longer alternates between "are at {pct}" and "give all they can" while the car-over row holds.

Cause (confirmed red on base): _car_manual_why read the live peak_guard.floor_limited, which toggles at the reserve.
Fix: display only. The text is held in c._car_why_hold and changes only after the other state has stood for 180 s (the car_over off hold). SoC unread is never "are at". Cleared when car_over drops, on unplug and with cover off. No wording or control change.

Tests: new test_ev16.py (T1-T15, T17); T14/T15 compare against base digests.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VSY9UpTaUYnjJF5oVtbM1w

EV-16: the Car Why no longer alternates between "are at {pct}" and "give all they can" while the car-over row holds. Cause (confirmed red on base): `_car_manual_why` read the live `peak_guard.floor_limited`, which toggles at the reserve. Fix: display only. The text is held in `c._car_why_hold` and changes only after the other state has stood for 180 s (the car_over off hold). SoC unread is never "are at". Cleared when car_over drops, on unplug and with cover off. No wording or control change. Tests: new `test_ev16.py` (T1-T15, T17); T14/T15 compare against base digests. 🤖 Generated with [Claude Code](https://claude.ai/code) https://claude.ai/code/session_01VSY9UpTaUYnjJF5oVtbM1w
ems-agent added 1 commit 2026-11-21 08:54:11 +01:00
EV-16: hold the Car Why text while car_over holds and the guard floor flag toggles
checks / unit (pull_request) Successful in 27m49s
infra-pin / fresh (pull_request) Failing after 2s
3b1189cdbf
Display only: the 'are at' / 'give all they can' text changes only when the
other state has stood for 180 s (the car_over off hold); SoC unread is never
'are at'. Cleared when car_over drops, on unplug and with cover off.

Co-Authored-By: Claude <noreply@anthropic.com>
ems-agent added 1 commit 2026-11-21 10:04:02 +01:00
EV-16: key the held Car Why to the car_over episode; add T16, T18 and N-id checks
checks / unit (pull_request) Successful in 25m43s
infra-pin / fresh (pull_request) Failing after 2s
b662d7171b
Control bumps _car_over_ep at each start and end of car_over; the display
ignores a hold of another episode, so a read overlapping the end cannot bring
a stale text back.

Co-Authored-By: Claude <noreply@anthropic.com>
ems-agent added 1 commit 2026-11-21 11:23:17 +01:00
EV-16: time the Car Why hold on the control cycle, not on page reads
checks / unit (pull_request) Successful in 24m55s
infra-pin / fresh (pull_request) Failing after 1s
c707eb4776
car_cycle ends with _car_why_tick (display only: control writes, never reads);
the Why reads the record. Adds read-gap tests (A, B, cover off/on), a long
guard-None test and a lower bound for the hold.

Co-Authored-By: Claude <noreply@anthropic.com>
ems-agent added 1 commit 2026-11-21 12:37:09 +01:00
EV-16 review round 2: pin the unread-SoC rule on the Why's live fallback
checks / unit (pull_request) Successful in 24m26s
infra-pin / fresh (pull_request) Failing after 2s
91cbdf2f43
The fallback (no record yet, or a record of an ended episode) had no check;
reading floor_limited alone there survived test_ev16. Test only.

Co-Authored-By: Claude <noreply@anthropic.com>
admin merged commit 00b116e5b2 into release/1.0 2026-11-21 16:08:08 +01:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/goodwe-addon#266