• Joined on 2025-08-30
admin commented on issue admin/model-router#1 2026-11-07 01:54:02 +01:00
TOOL-02: parseVerdict reads a verifier PASS as FAIL when prose after the JSON has a brace, then orders a needless rewrite

Fixed in v0.4.5 (05f9663). Installed into ~/projects/goodwe/tools/model-router and reloaded in the goodwe session 2026-11-07.

admin pushed tag v0.4.5 to admin/model-router 2026-11-07 01:48:09 +01:00
admin pushed to main at admin/model-router 2026-11-07 01:48:09 +01:00
05f9663129 Fix TOOL-02: read verifier verdicts with prose around them
admin pushed to release/1.0 at admin/goodwe-addon 2026-11-07 01:24:41 +01:00
b291262ee1 Merge pull request 'SAFETY-129: find late Home Assistant readings sooner at a 5 s meter' (#236) from SAFETY-129 into release/1.0
c70eeb6916 SAFETY-129 round 3: the real reason for the 16 s limit, a slow-start check, the row's tail
03541a1eee SAFETY-129 round 2: next() with a default in test_safety129
85433edac6 SAFETY-129 round 2: shorter test_safety129, pinned 5 s row, 100 s bound
2667cf0dda SAFETY-129: the 5 s row no longer waits for the batteries' figure
Compare 6 commits »
admin merged pull request admin/goodwe-addon#236 2026-11-07 01:24:40 +01:00
SAFETY-129: find late Home Assistant readings sooner at a 5 s meter
admin commented on pull request admin/goodwe-addon#236 2026-11-07 01:24:39 +01:00
SAFETY-129: find late Home Assistant readings sooner at a 5 s meter

Re-review of round 3 (head c70eeb6): ready, merging.

  • Diff 03541a1..c70eeb6: comment in lateness.py, DECISIONS, one test. No logic change.
  • D1 fixed: comment and DECISIONS now say the…
admin pushed to SAFETY-129 at admin/goodwe-addon 2026-11-07 00:36:32 +01:00
c70eeb6916 SAFETY-129 round 3: the real reason for the 16 s limit, a slow-start check, the row's tail
admin commented on pull request admin/goodwe-addon#236 2026-11-07 00:09:56 +01:00
SAFETY-129: find late Home Assistant readings sooner at a 5 s meter

Review of 03541a1 (Opus). Not merged: the owner decides on the two missed targets.

Verdict: accept both missed targets for the reasons below. One short dev round is needed (D1, D2); no…

admin pushed to SAFETY-129 at admin/goodwe-addon 2026-11-06 22:37:35 +01:00
03541a1eee SAFETY-129 round 2: next() with a default in test_safety129
85433edac6 SAFETY-129 round 2: shorter test_safety129, pinned 5 s row, 100 s bound
Compare 2 commits »
admin created pull request admin/goodwe-addon#236 2026-11-06 20:27:37 +01:00
SAFETY-129: find late Home Assistant readings sooner at a 5 s meter
admin pushed to SAFETY-129 at admin/goodwe-addon 2026-11-06 20:27:26 +01:00
2667cf0dda SAFETY-129: the 5 s row no longer waits for the batteries' figure
5b6cb0bf08 SAFETY-129: find readings 30 s late within about 90 s at a 5 s meter
Compare 2 commits »
admin created branch SAFETY-129 in admin/goodwe-addon 2026-11-06 20:27:26 +01:00
admin pushed to release/1.0 at admin/goodwe-addon 2026-11-06 11:19:23 +01:00
c66aa7f69a Merge pull request 'UX-77 round 2: Home's roll shares the peak room by room left, as control does' (#235) from UX-77-2 into release/1.0
6d2b9b5335 UX-77: Home's roll shares the peak room by room left to full, as control does
Compare 2 commits »
admin merged pull request admin/goodwe-addon#235 2026-11-06 11:19:21 +01:00
UX-77 round 2: Home's roll shares the peak room by room left, as control does
admin commented on pull request admin/goodwe-addon#235 2026-11-06 11:19:20 +01:00
UX-77 round 2: Home's roll shares the peak room by room left, as control does

Review (round 2): approve and merge

Head reviewed: 6d2b9b5, on release/1.0 47c89a1.

Verdict: right. The roll now shares the room the same way control's commands do, and it changes…

admin created pull request admin/goodwe-addon#235 2026-11-06 09:11:14 +01:00
UX-77 round 2: Home's roll shares the peak room by room left, as control does
admin pushed to UX-77-2 at admin/goodwe-addon 2026-11-06 09:11:02 +01:00
6d2b9b5335 UX-77: Home's roll shares the peak room by room left to full, as control does
admin created branch UX-77-2 in admin/goodwe-addon 2026-11-06 09:11:02 +01:00
admin pushed to release/1.0 at admin/goodwe-addon 2026-11-06 00:11:05 +01:00
47c89a13d0 Merge pull request 'UX-77: Home draws today's grid charge for the hours control will really charge' (#234) from UX-77 into release/1.0
45535e19d7 UX-77: Home draws today's grid charge for the hours control will really charge
Compare 2 commits »
admin merged pull request admin/goodwe-addon#234 2026-11-06 00:11:04 +01:00
UX-77: Home draws today's grid charge for the hours control will really charge