• Joined on 2025-08-30
admin commented on pull request admin/goodwe-addon#239 2026-11-07 20:03:05 +01:00
SMA-10: two idle states, hold 0 W or hand the inverter back

Review (SMA-10): not merged, one change needed. Head a1be9c4 checked.

What is right: GoodWe is byte-identical (wire-level replay of 7 identity tools N=1/N=2, TEL-07 announce 0/0/0 at N=1 and…

admin created pull request admin/goodwe-addon#239 2026-11-07 18:45:30 +01:00
SMA-10: two idle states, hold 0 W or hand the inverter back
admin created branch SMA-10 in admin/goodwe-addon 2026-11-07 18:45:21 +01:00
admin pushed to SMA-10 at admin/goodwe-addon 2026-11-07 18:45:21 +01:00
a1be9c48b3 SMA-10: two idle states, hold 0 W or hand the inverter back
admin pushed to release/1.0 at admin/goodwe-addon 2026-11-07 14:47:00 +01:00
57c8d1b912 Merge pull request 'SMA-2: each inverter is reached through a driver; GoodWe behaviour unchanged' (#238) from SMA-2 into release/1.0
c015230452 SMA-2 round 2: keep the driver keys out of the schema, translations and labels
0b20f53cf8 SMA-2 round 2: census keeps ACTUATOR_WRITE_KEYS, setters, NaN/inf port refused, tests
e56eeef8f0 SMA-2: each inverter is reached through a driver; GoodWe behaviour unchanged
Compare 4 commits »
admin merged pull request admin/goodwe-addon#238 2026-11-07 14:46:59 +01:00
SMA-2: each inverter is reached through a driver; GoodWe behaviour unchanged
admin commented on pull request admin/goodwe-addon#238 2026-11-07 14:46:58 +01:00
SMA-2: each inverter is reached through a driver; GoodWe behaviour unchanged

Review (Opus) of c015230: approved, merging.

  • Pure refactor: wire log of every HA call in the 7 replay identity tools (N=1 and N=2, ~113k calls) and their digests byte-identical base 23ff9d0…
admin pushed to SMA-2 at admin/goodwe-addon 2026-11-07 13:33:34 +01:00
c015230452 SMA-2 round 2: keep the driver keys out of the schema, translations and labels
0b20f53cf8 SMA-2 round 2: census keeps ACTUATOR_WRITE_KEYS, setters, NaN/inf port refused, tests
Compare 2 commits »
admin created pull request admin/goodwe-addon#238 2026-11-07 11:29:10 +01:00
SMA-2: each inverter is reached through a driver; GoodWe behaviour unchanged
admin pushed to SMA-2 at admin/goodwe-addon 2026-11-07 11:28:50 +01:00
e56eeef8f0 SMA-2: each inverter is reached through a driver; GoodWe behaviour unchanged
admin created branch SMA-2 in admin/goodwe-addon 2026-11-07 11:28:50 +01:00
admin pushed to release/1.0 at admin/goodwe-addon 2026-11-07 06:56:12 +01:00
23ff9d0920 Merge pull request 'OPT-38: keep tomorrow's solar forecast when one sensor goes stale in the afternoon' (#237) from OPT-38 into release/1.0
0bacafadf0 OPT-38 round 2: a kept tomorrow reading is flagged kept only from 20:00
c43873b142 OPT-38: a kept tomorrow forecast reading stands in at any hour
Compare 3 commits »
admin merged pull request admin/goodwe-addon#237 2026-11-07 06:56:10 +01:00
OPT-38: keep tomorrow's solar forecast when one sensor goes stale in the afternoon
admin commented on pull request admin/goodwe-addon#237 2026-11-07 06:56:09 +01:00
OPT-38: keep tomorrow's solar forecast when one sensor goes stale in the afternoon

Re-review, round 2 (0bacafa): right, merging.

  • All 4 requested changes are done. The kept flag for a kept tomorrow reading now starts only at 20:00, and there is a 14:00 Home-line test for…
admin pushed to OPT-38 at admin/goodwe-addon 2026-11-07 06:02:03 +01:00
0bacafadf0 OPT-38 round 2: a kept tomorrow reading is flagged kept only from 20:00
admin commented on pull request admin/goodwe-addon#237 2026-11-07 05:35:02 +01:00
OPT-38: keep tomorrow's solar forecast when one sensor goes stale in the afternoon

Review of c43873b: not merged, one change needed.

The forecast rule is right. A stale tomorrow reading stands in only for its own day0 and when it is at most 12 h old. Today readings, the…

admin created pull request admin/goodwe-addon#237 2026-11-07 04:24:04 +01:00
OPT-38: keep tomorrow's solar forecast when one sensor goes stale in the afternoon
admin pushed to OPT-38 at admin/goodwe-addon 2026-11-07 04:24:04 +01:00
c43873b142 OPT-38: a kept tomorrow forecast reading stands in at any hour
admin created branch OPT-38 in admin/goodwe-addon 2026-11-07 04:24:04 +01:00
admin closed issue admin/model-router#1 2026-11-07 01:54:02 +01:00
TOOL-02: parseVerdict reads a verifier PASS as FAIL when prose after the JSON has a brace, then orders a needless rewrite