• Joined on 2025-08-30
admin pushed to release/1.0 at admin/goodwe-addon 2026-11-08 10:46:29 +01:00
16029d7cb8 Merge pull request 'Release 0.21.0' (#241) from release-0.21.0 into release/1.0
8e26574b03 Release 0.21.0: CHANGELOG wording (SAFETY-136, SAFETY-138 known issues)
0f208a0500 Release 0.21.0: version bump and CHANGELOG
Compare 3 commits »
admin merged pull request admin/goodwe-addon#241 2026-11-08 10:46:28 +01:00
Release 0.21.0
admin commented on pull request admin/goodwe-addon#241 2026-11-08 10:21:47 +01:00
Release 0.21.0

REL-0.21.0 review of 0f208a0 (Opus, independent; router T232 PASS)

Checks:

  1. Only goodwe_controller/config.yaml (version "0.21.0") and goodwe_controller/CHANGELOG.md changed: PASS. 2.…
admin pushed to release-0.21.0 at admin/goodwe-addon 2026-11-08 10:21:23 +01:00
8e26574b03 Release 0.21.0: CHANGELOG wording (SAFETY-136, SAFETY-138 known issues)
admin created pull request admin/goodwe-addon#241 2026-11-08 09:09:10 +01:00
Release 0.21.0
admin created branch release-0.21.0 in admin/goodwe-addon 2026-11-08 09:09:00 +01:00
admin pushed to release-0.21.0 at admin/goodwe-addon 2026-11-08 09:09:00 +01:00
0f208a0500 Release 0.21.0: version bump and CHANGELOG
admin pushed to release/1.0 at admin/goodwe-addon 2026-11-08 04:20:07 +01:00
b3cfcf2df4 Merge pull request 'SAFETY-137: the shutdown 0 W must be the last write every unit hears' (#240) from SAFETY-137 into release/1.0
8953be0362 SAFETY-137: the shutdown and Stop 0 W is the last write every unit hears
Compare 2 commits »
admin merged pull request admin/goodwe-addon#240 2026-11-08 04:20:05 +01:00
SAFETY-137: the shutdown 0 W must be the last write every unit hears
admin commented on pull request admin/goodwe-addon#240 2026-11-08 04:19:21 +01:00
SAFETY-137: the shutdown 0 W must be the last write every unit hears

Review (SAFETY-137, head 8953be0): approved, merging.

  • Race closed: with a 0.3 s, 0.6 s or hung cycle write on its way, at shutdown and at Stop, N=1 and N=2, GoodWe and a fake that does not hand…
admin pushed to SAFETY-137 at admin/goodwe-addon 2026-11-08 03:03:01 +01:00
8953be0362 SAFETY-137: the shutdown and Stop 0 W is the last write every unit hears
admin created pull request admin/goodwe-addon#240 2026-11-08 03:03:01 +01:00
SAFETY-137: the shutdown 0 W must be the last write every unit hears
admin created branch SAFETY-137 in admin/goodwe-addon 2026-11-08 03:03:01 +01:00
admin pushed to release/1.0 at admin/goodwe-addon 2026-11-07 23:43:16 +01:00
dbdc37b959 Merge pull request 'SMA-10: two idle states, hold 0 W or hand the inverter back' (#239) from SMA-10 into release/1.0
6cae5a2f8f SMA-10 round 4: pin the Dutch default "de eigen sturing"
313503724d SMA-10 round 3: Start clears a failed hand-back streak; the hook is tested
d26cc573fe SMA-10 round 2: a failed release sends 0 W once, retries at heartbeat pace
a1be9c48b3 SMA-10: two idle states, hold 0 W or hand the inverter back
Compare 5 commits »
admin merged pull request admin/goodwe-addon#239 2026-11-07 23:43:15 +01:00
SMA-10: two idle states, hold 0 W or hand the inverter back
admin commented on pull request admin/goodwe-addon#239 2026-11-07 23:42:36 +01:00
SMA-10: two idle states, hold 0 W or hand the inverter back

Re-review (round 2) of 6cae5a2: merging.

  1. Failed release (False, raise, hang), on Stop and on shutdown: the unit at 1120 W gets exactly one 0 W, then none over 6 heartbeats. Release is…
admin pushed to SMA-10 at admin/goodwe-addon 2026-11-07 22:45:11 +01:00
6cae5a2f8f SMA-10 round 4: pin the Dutch default "de eigen sturing"
admin pushed to SMA-10 at admin/goodwe-addon 2026-11-07 21:57:20 +01:00
313503724d SMA-10 round 3: Start clears a failed hand-back streak; the hook is tested
admin pushed to SMA-10 at admin/goodwe-addon 2026-11-07 20:43:53 +01:00
d26cc573fe SMA-10 round 2: a failed release sends 0 W once, retries at heartbeat pace
admin commented on pull request admin/goodwe-addon#239 2026-11-07 20:03:28 +01:00
SMA-10: two idle states, hold 0 W or hand the inverter back

Correction to my point 1. SMA-9 §1.4/§5 (SMA-5) relies on the inverter's own fallback timer (41193/41195) to take over when writes stop. A 0 W write re-sent on every retry would keep resetting…