adminandClaude Opus 5
8beba0a3e7
Rounds 2 and 3 hardened the FLOOR axis - the max inside binding_soc_floor(), the roster handed to it, Controller.packs, pack_floor_pct()'s conjunction. peakguard.decide() is handed a SECOND reduction over the same roster beside it, soc=self.pack_floor_soc, and peakguard.py's own docstring names the two as a pair. Three rewrites of Controller.pack_floor_soc were green across all 19 files on52380c0and again after the rebase onto3934ad7: min(float(v) for v in vals) -> ... vals[:2] +4 bytes -> ... vals[-2:] +5 bytes -> ... vals[:3] +4 bytes while [:1], [-1:], [1:], [:-1], max() and the mean were all red. The suite's separating power on the SoC axis stopped at exactly N=2 - the state the floor axis was in before round 3. It changes a real answer: three packs at 50/60/11 %, emptiest THIRD, answers 11.0 shipped and 50.0 mutated. The site is then graded for discharge PERMISSION against a pack 39 points fuller than the emptiest and spends a pack its own BMS stops, through sim/inject.py which runs no validator rule. Round 3's machinery transfers directly. New test_peakguard.py part 12i: - six REAL Controller.cycle()s, emptiest pack at every position of a three-pack roster and both positions of a two-pack one, observable read off PeakDecision.soc; cut-outs held flat so the floor axis cannot move the answers - computed slice and non-slice tables, printed, red naming any live survivor - a LENGTH SWEEP over the real property, 78 rosters of 1..12 real inverters, closing head/tail widths 1-11 and asserting width 12 is unreached - a NONE-GUARD sweep over the same 78 - THREE exact structural pins: the vals comprehension iterates the bare self.inverters, and both any() and min() reduce the whole vals - closing every slice width at every roster length, which no bounded fixture can SPIKE-04: pack B is 4 x Dyness DL5.0C, DoD 90 -> floor 10 % [FROM DATASHEET AND SERIAL - inverter B does not exist and nothing about it is measured]. Pack A is DoD 90 -> 10 % and that one IS measured. So production is DEGENERATE on the floor axis and a differing floor exists ONLY in the fixtures - which is the argument for keeping them, not for simplifying them. Recorded in CHANGELOG and DECISIONS so nobody later collapses them to one number. The SoC axis has no such degeneracy. AND THE FAMILY, not the member. Every reduction over self.inverters/self.packs in Controller was found from the AST and mutated to a slice against the full suite. Eighteen were already graded. FOUR were not, and three of them are SAFETY-30's, all any(i.sign_wd.tripped for i in self.inverters), each +4 bytes and green across 19 files - because the only fixture that reached them was a roster of ONE, where self.inverters[:1] IS self.inverters: - cycle()'s stale-input hold: a LATCHED unit must take the roster past it or its failsafe SET stops being re-filed the moment a poll is missed - publish()'s status vocabulary: a site holding an inverter at 0 W published "running" - status_payload()'s banner: the one headline on the page New test_watchdog.py part 8 grades all three with the latch at EACH position plus a no-latch counterfactual. New part 12j pins all 26 roster comprehensions in Controller to iterating the roster WHOLE, so a reduction added over a slice anywhere in the class is red on the line it is written, with no fixture needed. Two rows reported OPEN rather than closed: _grade_store_migration()'s second disjunct (now red on 12j, argued equivalent because a unit tripped at startup implies its namespaced key is set) and cycle()'s undeliverable-unit LOG LINE, where sorted(...)[:1] is still green - it truncates names in one event message; the refusal itself is a different expression and is graded. MUTATION.md gains habits 10 and 11: a fixture of N members cannot separate two reductions that agree on N, and mutate the SIBLINGS of anything you harden. No shipped behaviour changed - tests and documentation only. 19/19 green; all three named survivors and all round-3 mutations verified RED. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BwRLw7eKYj2byVdwB6kbjU
GoodWe RS485 Controller — Home Assistant add-on repository
Replaces a GoodWe battery inverter's vendor controller with a local one: holds net grid exchange at zero by emulating the inverter's smart meter over RS485, and runs the monthly battery maintenance cycle the vendor box was doing.
repository.yaml add-on repository metadata
goodwe_controller/ the add-on
config.yaml manifest + options schema (the per-site config form)
app/ the controller
control.py the control law — pure functions, no I/O
maintenance.py the monthly cycle state machine
hass.py Supervisor/Core API access
store.py persistent state in /data
mqtt.py optional status entities
web.py ingress UI
main.py orchestration, heartbeat, failsafe behaviour
test_control.py runnable checks — no framework needed
test_maintenance.py runnable checks — walks a full cycle in fake time
DOCS.md the add-on's documentation tab
MUTATION.md how to run a mutation so the result means something
tools/mutation_run.sh the mutation harness - purges bytecode, then grades
firmware/goodwe-master.yaml ESPHome config for the T-CAN485
estop/rs485_log.py optional RS485 e-stop / bus witness
docs/GoodWe-RS485-Field-Guide.pdf the guide techs carry (10pp, A4)
docs/build_guide.py its single source - rebuilds the HTML and PDF
FIELD-GUIDE.md how to edit and rebuild the guide
Picking this up after a break? Read HANDOVER.md first — current state,
what is known broken, and what to do next.
Install
Settings → Add-ons → Add-on store → ⋮ → Repositories → add
https://gittea.kammenstraatha.duckdns.org/admin/goodwe-addon
then install GoodWe RS485 Controller.
⚠️ The repository must be PUBLIC for this to work. Home Assistant clones it
anonymously; against a private repo the store shows nothing and gives no useful
error. If it must stay private, install locally instead: copy
goodwe_controller/ into the machine's /addons/ folder, then
ha store reload — it appears as a Local add-on.
⚠️ Bump version: in goodwe_controller/config.yaml for every change.
Supervisor keys the built image by that version, so without a bump it silently
reuses the old image and your fix appears not to work — on your bench and on
every client's machine.
Requires Home Assistant OS or Supervised. Add-ons cannot be installed on HA Container or Core.
Read this first
The inverter holds its last command forever. It has no meter-timeout of its own — a controller that dies mid-command leaves the battery running until a human intervenes. Measured on real hardware: 5 kW of discharge held for 113 seconds after a controller went silent.
Three layers exist because of that, and only the third covers the Home Assistant machine itself dying:
- ESP32 watchdog — no fresh setpoint for ~30 s → command 0 W, and keep commanding it.
- Wind-down before firmware updates — 0 W written before the update starts.
- RS485 e-stop (optional) — writes 0 W after 30 s of total bus silence.
Sites sold without the e-stop must have the acknowledgement in FIELD-GUIDE.md
§10 signed.
Development
The control law and the maintenance machine are pure Python with no Home Assistant imports, so they run anywhere:
cd goodwe_controller
python3 test_control.py
python3 test_maintenance.py
Both must pass before shipping any change. To prove a check bites - the way
almost every claim in this repository was established - mutate the module and
run tools/mutation_run.sh, which clears __pycache__ first. It is not
optional: a same-size edit reverted inside one second leaves CPython reusing the
old bytecode, and the run grades code that is not there. goodwe_controller/MUTATION.md
has the mechanism, the measurement, and what the flags do not do. They are not unit-test theatre —
each assertion corresponds to a rule whose absence produced an observed failure
on real hardware, and the comments in control.py say which.
Compatibility
Check the serial number, not the model name. Characters 6-8 of the serial are the platform tag:
| tag | platform | verdict |
|---|---|---|
ESU EMU ESA BPS BPU EMJ IJL |
105 — ES/EM/BP, AA55-era meter bus | supported |
SPB SPN |
745 — SBP G2 (GW…-SBP-20) |
no |
ESN ESC |
745 — ES G2 (GW…-ES-20) |
no |
ETU EHU BTU … |
205/745/753 — ET/EH/BT hybrids | no |
SDT DST MSU NSU … |
PV-only inverters — no battery to control | no |
A "-20" or "G2" suffix means a different platform with a different meter
protocol. The tags come from the goodwe library's PLATFORM_105_MODELS, which
is also what Home Assistant's own integration uses to pick a protocol.
- GoodWe ES / BP family inverters (AA55 / RS485 meter-bus generation)
- The protocol is reverse-engineered. There is no vendor contract, and a firmware change on GoodWe's side could break every installation at once. Say so when you sell it.