Release 0.23.0 #255

Merged
admin merged 3 commits from release-0.23.0 into release/1.0 2026-11-16 03:55:38 +01:00
Owner

Release cut 0.23.0 on release/1.0 (minor). Changes only goodwe_controller/config.yaml (version: "0.23.0") and goodwe_controller/CHANGELOG.md (the "Not in a release yet" block is folded into a new ## 0.23.0 section).

  • Contents (first-parent since the 0.22.0 cut b700c0b): MAINT-28 (#248), CI-17 (#252, test only), EV-03 (#253), CI-18 (#254, CI and tests only).
  • Four options added (ev_charger off, ev_current_entity, ev_max_a, ev_phases), all with defaults. No option removed, renamed or changed. Existing installs need no option change (90 options, 86 before).
  • Offline: test_version_gate, test_docs, test_defaults_pin, test_validate, test_tool_inputs pass. predeploy_check.py --deployed-version 0.22.0: refused before the bump (no-op), CLEARED after.
  • Known issues: MAINT-28's entry dropped (fixed by #248); SAFETY-141, MAINT-29, TEL-19, UX-81 added.
  • Not merged, no tag, no deploy. The master PR is opened by the reviewer.

Report: reports/REL-0.23.0-dev-report.md

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC

Release cut 0.23.0 on release/1.0 (minor). Changes only `goodwe_controller/config.yaml` (`version: "0.23.0"`) and `goodwe_controller/CHANGELOG.md` (the "Not in a release yet" block is folded into a new `## 0.23.0` section). - Contents (first-parent since the 0.22.0 cut `b700c0b`): MAINT-28 (#248), CI-17 (#252, test only), EV-03 (#253), CI-18 (#254, CI and tests only). - Four options added (`ev_charger` off, `ev_current_entity`, `ev_max_a`, `ev_phases`), all with defaults. No option removed, renamed or changed. Existing installs need no option change (90 options, 86 before). - Offline: test_version_gate, test_docs, test_defaults_pin, test_validate, test_tool_inputs pass. `predeploy_check.py --deployed-version 0.22.0`: refused before the bump (no-op), CLEARED after. - Known issues: MAINT-28's entry dropped (fixed by #248); SAFETY-141, MAINT-29, TEL-19, UX-81 added. - Not merged, no tag, no deploy. The master PR is opened by the reviewer. Report: reports/REL-0.23.0-dev-report.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC
admin added 2 commits 2026-11-16 02:37:59 +01:00
Bump version to 0.23.0 and fold "Not in a release yet" into a new
0.23.0 CHANGELOG section (MAINT-28, CI-17, EV-03, CI-18). Four new
options (ev_*), all with defaults; no option change needed.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC
Release 0.23.0: one Known issues heading
checks / unit (pull_request) Successful in 22m6s
infra-pin / fresh (pull_request) Successful in 2s
e3cce25cb0
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC
admin added 1 commit 2026-11-16 03:34:15 +01:00
Release 0.23.0: CHANGELOG review wording fixes
checks / unit (pull_request) Successful in 20m52s
infra-pin / fresh (pull_request) Successful in 2s
568230c422
- MAINT-28: say the hold is for two inverters (the code gates it on N >= 2).
- EV-03: "no longer buy energy for the car" (the profile is a 7-day median).
- TEL-19: plain wording for the PV sensor point.
- Known issues: add TEL-20 (DOCS names a car sensor id HA does not create).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

REL-0.23.0 review of #255 (head reviewed e3cce25; fixes pushed as 568230c)

Checks

  1. Only goodwe_controller/config.yaml (version: "0.23.0") and goodwe_controller/CHANGELOG.md changed: PASS.
  2. Version: PASS, minor is right. Options/schema against master 10ee2ba: exactly four added (ev_charger: "off", ev_current_entity: "", ev_max_a: 16, ev_phases: "auto"), 86 -> 90, none removed, renamed or changed; no other top-level key changed but version. Option reads with a default in app/: master's 38 are all unchanged, the 4 new ones are the ev_* with the same defaults. _charger_problems() returns at once with the charger off. Existing installs need no option change.
  3. Contents table: PASS. git log --first-parent b700c0b..5fc92cf = 6c0546b #248, 6bf3759 #252, 7513fd9 #253, 5fc92cf #254. (10ee2ba..5fc92cf prints the same four; the dev's "prints nothing" was most likely the rtk output filter, as in REL-0.22.0.) b700c0b's tree equals master's. CI-17 touches only test_peakguard.py; CI-18 only .gitea/ci, checks.yml, README and test files. EV-03 claims match the EV-03 review/test reports (0 service calls to charger entities, write methods have no caller). MAINT-28 figures match MAINT-28-test2 (0 flips against 325-385; night charge equal). The 0.22.0 section and everything below it is byte-identical to master.
  4. Known issues: PASS after F4. MAINT-28 dropped (card Done); SAFETY-141, MAINT-29, TEL-19, UX-81 added and match their cards; all other cards still To Do except SAFETY-97, SAFETY-126 and SAFETY-136 (Done, kept as in 0.22.0). OPT-31's "such as one with a car charger" can stay: true while the charger is off, which is the default.
  5. Plain text: PASS after the fixes. One Known issues heading. Bullets end with a full stop; table rows end with the card link, as in every earlier section (convention, not changed).
  6. CI: run 1691 checks / unit (pull_request) success on e3cce25 (attempt 1). test_version_gate and test_docs rc 0 locally on e3cce25 and on 568230c (goodwe-addon-checks:1, --network none).

Findings (all Low, all CHANGELOG wording, fixed in 568230c)

  • F1 (low), goodwe_controller/CHANGELOG.md:5, :10, :18, MAINT-28. The hold is gated on two or more inverters (ctl_cycle.py: len(self.inverters) > 1; DECISIONS/MAINT-28: "N=1 not changed"). The text read as if it applied to every site. Now says "with two inverters" / "Two inverters:".
  • F2 (low), CHANGELOG.md:8, EV-03. "no longer buy energy for a car that charged last night" overstated the effect (the house profile is a 7-day hourly median). Now "no longer buy energy for the car".
  • F3 (low), CHANGELOG.md:110, TEL-19. "The PV power sensor should do the same" read as a wish. Now "From reading the code, the PV power sensor does the same when it is switched off".
  • F4 (low), CHANGELOG.md:112, Known issues. TEL-20 (To Do, filed 2026-11-16 02:01) is user-visible: DOCS names goodwe_car_today_kwh, HA creates sensor.goodwe_car_energy_today. Added as one line.

No behaviour claim is wrong. Merge follows once checks / unit (pull_request) is green on 568230c.

**REL-0.23.0 review of #255 (head reviewed e3cce25; fixes pushed as 568230c)** Checks 1. Only `goodwe_controller/config.yaml` (`version: "0.23.0"`) and `goodwe_controller/CHANGELOG.md` changed: PASS. 2. Version: PASS, minor is right. Options/schema against master 10ee2ba: exactly four added (`ev_charger: "off"`, `ev_current_entity: ""`, `ev_max_a: 16`, `ev_phases: "auto"`), 86 -> 90, none removed, renamed or changed; no other top-level key changed but `version`. Option reads with a default in app/: master's 38 are all unchanged, the 4 new ones are the `ev_*` with the same defaults. `_charger_problems()` returns at once with the charger off. Existing installs need no option change. 3. Contents table: PASS. `git log --first-parent b700c0b..5fc92cf` = 6c0546b #248, 6bf3759 #252, 7513fd9 #253, 5fc92cf #254. (`10ee2ba..5fc92cf` prints the same four; the dev's "prints nothing" was most likely the rtk output filter, as in REL-0.22.0.) b700c0b's tree equals master's. CI-17 touches only test_peakguard.py; CI-18 only .gitea/ci, checks.yml, README and test files. EV-03 claims match the EV-03 review/test reports (0 service calls to charger entities, write methods have no caller). MAINT-28 figures match MAINT-28-test2 (0 flips against 325-385; night charge equal). The 0.22.0 section and everything below it is byte-identical to master. 4. Known issues: PASS after F4. MAINT-28 dropped (card Done); SAFETY-141, MAINT-29, TEL-19, UX-81 added and match their cards; all other cards still To Do except SAFETY-97, SAFETY-126 and SAFETY-136 (Done, kept as in 0.22.0). OPT-31's "such as one with a car charger" can stay: true while the charger is off, which is the default. 5. Plain text: PASS after the fixes. One Known issues heading. Bullets end with a full stop; table rows end with the card link, as in every earlier section (convention, not changed). 6. CI: run 1691 `checks / unit (pull_request)` success on e3cce25 (attempt 1). test_version_gate and test_docs rc 0 locally on e3cce25 and on 568230c (`goodwe-addon-checks:1`, `--network none`). Findings (all Low, all CHANGELOG wording, fixed in 568230c) - **F1 (low), goodwe_controller/CHANGELOG.md:5, :10, :18, MAINT-28.** The hold is gated on two or more inverters (`ctl_cycle.py`: `len(self.inverters) > 1`; DECISIONS/MAINT-28: "N=1 not changed"). The text read as if it applied to every site. Now says "with two inverters" / "Two inverters:". - **F2 (low), CHANGELOG.md:8, EV-03.** "no longer buy energy for a car that charged last night" overstated the effect (the house profile is a 7-day hourly median). Now "no longer buy energy for the car". - **F3 (low), CHANGELOG.md:110, TEL-19.** "The PV power sensor should do the same" read as a wish. Now "From reading the code, the PV power sensor does the same when it is switched off". - **F4 (low), CHANGELOG.md:112, Known issues.** TEL-20 (To Do, filed 2026-11-16 02:01) is user-visible: DOCS names `goodwe_car_today_kwh`, HA creates `sensor.goodwe_car_energy_today`. Added as one line. No behaviour claim is wrong. Merge follows once `checks / unit (pull_request)` is green on 568230c.
admin merged commit b65609133e into release/1.0 2026-11-16 03:55:38 +01:00
Author
Owner

Merged after run 1693 checks / unit (pull_request) went green on 568230c (job 2846, attempt 1). Merge commit b65609133e (parents 5fc92cf + 568230c, tree equal to 568230c); ls-remote release/1.0 = b656091. Master PR: #256 (not merged; the owner merges).

Merged after run 1693 `checks / unit (pull_request)` went green on 568230c (job 2846, attempt 1). Merge commit b65609133e51f1ed0b396a3c907d1435fc4208c8 (parents 5fc92cf + 568230c, tree equal to 568230c); ls-remote release/1.0 = b656091. Master PR: #256 (not merged; the owner merges).
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/goodwe-addon#255