UX-44: contract label says every 15 minutes, not hourly #195

Merged
admin merged 1 commits from UX-44 into release/1.0 2026-10-16 06:59:19 +02:00
Owner

Settings contract choice: "Dynamic, hourly" -> "Dynamic, every 15 minutes"; "Dynamisch, per uur" -> "Dynamisch, per kwartier". One DOCS line (under hourly pricing -> under dynamic pricing). New part 7 in test_ui_text.py. No option keys, values or logic changed. Not touched: Home price chart text (UX-45), hourly-by-design text.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC

Settings contract choice: "Dynamic, hourly" -> "Dynamic, every 15 minutes"; "Dynamisch, per uur" -> "Dynamisch, per kwartier". One DOCS line (`under hourly pricing` -> `under dynamic pricing`). New part 7 in test_ui_text.py. No option keys, values or logic changed. Not touched: Home price chart text (UX-45), hourly-by-design text. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC
admin added 1 commit 2026-10-16 05:26:34 +02:00
UX-44: contract label says every 15 minutes, not hourly
checks / unit (pull_request) Successful in 40m37s
infra-pin / fresh (pull_request) Successful in 2s
1bd2ba1397
The settings page contract choice read "Dynamic, hourly" / "Dynamisch,
per uur". Belgian day-ahead prices are per 15 minutes since 2025-10-01.
Now "Dynamic, every 15 minutes" / "Dynamisch, per kwartier". One DOCS
line that called dynamic pricing "hourly pricing" now says dynamic.
test_ui_text.py part 7 fails if either label says hourly again.

Co-Authored-By: Claude <noreply@anthropic.com>
Author
Owner

Review of 1bd2ba1: no findings.

  • Labels: "Dynamic, every 15 minutes" / "Dynamisch, per kwartier" are short, plain and correct (STYLE.md: "15-minute period", not "quarter"; "kwartier" already used in nl.yaml). DOCS.md:3116 "dynamic pricing" is true in context.
  • Hit list: agree with every item left alone. Extra hits checked and left: en.json:361 / nl.json:301 Home plan heading "cheapest hour" and translations en.yaml:219 / nl.yaml:200 arbitrage description describe the add-on's hourly trade (arbitrage.py switches per hour), not the contract price; DOCS.md:288 "every hour" is about a flat levy.
  • Diff touches only 2 strings, 1 DOCS line and test_ui_text.py part 7; no keys, values or logic.
  • Mutations (all caught, 2 FAILED each): EN back to "Dynamic, hourly"; NL back to "Dynamisch, per uur"; own: NL "Dynamisch, elk uur".
  • Offline suite goodwe-addon-checks:1, --network none: 78/78 pass. Browser (Playwright 1.55, demo): EN and NL show the new label.
  • CI run 1304 checks / unit and 1305 infra-pin / fresh green on 1bd2ba1.

Merging with head_commit_id pinned.

Review of 1bd2ba1: no findings. - Labels: "Dynamic, every 15 minutes" / "Dynamisch, per kwartier" are short, plain and correct (STYLE.md: "15-minute period", not "quarter"; "kwartier" already used in nl.yaml). DOCS.md:3116 "dynamic pricing" is true in context. - Hit list: agree with every item left alone. Extra hits checked and left: en.json:361 / nl.json:301 Home plan heading "cheapest hour" and translations en.yaml:219 / nl.yaml:200 arbitrage description describe the add-on's hourly trade (arbitrage.py switches per hour), not the contract price; DOCS.md:288 "every hour" is about a flat levy. - Diff touches only 2 strings, 1 DOCS line and test_ui_text.py part 7; no keys, values or logic. - Mutations (all caught, 2 FAILED each): EN back to "Dynamic, hourly"; NL back to "Dynamisch, per uur"; own: NL "Dynamisch, elk uur". - Offline suite goodwe-addon-checks:1, --network none: 78/78 pass. Browser (Playwright 1.55, demo): EN and NL show the new label. - CI run 1304 checks / unit and 1305 infra-pin / fresh green on 1bd2ba1. Merging with head_commit_id pinned.
admin merged commit 8e02a0928b into release/1.0 2026-10-16 06:59:19 +02:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/goodwe-addon#195