From 6aa1c32cbbe3e78d197349fcbfd1d41b05bea5d0 Mon Sep 17 00:00:00 2001 From: goodwe-review Date: Wed, 14 Oct 2026 00:39:37 +0200 Subject: [PATCH] MAINT-11 review round 2: pin each cycle button to its own disabled flag Reviewer mutations survived the round-2 page checks: Start forced always disabled (|| true), and the two flags swapped between Start and Stop, because the checks only looked for each flag somewhere in the file. The check now pins each flag to its own button. No behaviour change. Co-Authored-By: Claude Opus 5.5 --- goodwe_controller/test_maint11.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/goodwe_controller/test_maint11.py b/goodwe_controller/test_maint11.py index 8451135..3a27fec 100644 --- a/goodwe_controller/test_maint11.py +++ b/goodwe_controller/test_maint11.py @@ -372,6 +372,9 @@ check("Start is disabled while any battery cycles", and "disabled: !can.start" in JS) check("Start is disabled on a switched-off battery (use false, modes on)", "&& b.use !== false, abort" in JS) +check("each button carries its own flag, and only that flag", + 'id: "bcs-" + i, disabled: !can.start, onclick: ask1("start_dialog"' in JS + and 'id: "bca-" + i, disabled: !can.abort, onclick: ask1("abort_dialog"' in JS) check("a battery counts as cycling when its phase is not idle", 'cycling = (x) => x.maintenance !== "idle"' in JS) check("the old header buttons still post a bare request",