• Joined on 2025-08-30
admin opened issue admin/model-router#4 2026-11-14 00:13:41 +01:00
"routed to X, ran on Opus" names the wrong model for resumed and router-rewrite agents
admin pushed to MAINT-28-fix at admin/goodwe-addon 2026-11-13 23:42:26 +01:00
07d23d2eed MAINT-28 fix-forward round 4: the paused pack's cap is its own part of the guard's floor, the largest of the period, per unit
admin pushed to MAINT-28-fix at admin/goodwe-addon 2026-11-13 21:21:18 +01:00
fb4a449591 MAINT-28 fix-forward round 3: the cap is the guard's largest claim of the period, 0 W for a pack the guard does not place on
admin pushed to MAINT-28-fix at admin/goodwe-addon 2026-11-13 19:49:21 +01:00
776b84ca20 MAINT-28 fix-forward round 2: while the pause holds, the maintenance pack gives only what the peak guard claims
admin created pull request admin/goodwe-addon#248 2026-11-13 16:56:35 +01:00
MAINT-28 fix-forward: the peak pause ends only on a settled estimate; a pack under its peak reserve gives nothing for the house
admin pushed to MAINT-28-fix at admin/goodwe-addon 2026-11-13 16:56:26 +01:00
34b81e8aeb MAINT-28 fix-forward: the peak pause ends only on a settled house estimate, and a pack under its peak reserve gives nothing for the house while it holds
admin created branch MAINT-28-fix in admin/goodwe-addon 2026-11-13 16:56:26 +01:00
admin commented on pull request admin/goodwe-addon#247 2026-11-13 06:23:31 +01:00
MAINT-28: during a real peak the maintenance charge stays paused

Re-review of e770615: MERGE-READY as is, and now merged. release/1.0 is f3f9483 (normal merge; parents 1b5f7c9 and e770615).

  • git diff 7edf848 e770615 changes only DECISIONS and one code…
admin pushed to release/1.0 at admin/goodwe-addon 2026-11-13 06:23:15 +01:00
f3f9483d9c Merge pull request 'MAINT-28: during a real peak the maintenance charge stays paused' (#247) from MAINT-28 into release/1.0
e7706150e8 MAINT-28: DECISIONS gives the measured reason for the uncapped give (review M-1); ctl_cycle comment one line + pointer (L-1)
7edf8484d1 MAINT-28: test_maint28 reads the replay clock directly (main_files.live parsed every app file per cycle): 269 s -> 28 s, same numbers
29a8a05f30 MAINT-28: shorter test_maint28 runs (892 s -> ~280 s), digests re-pinned on 1b5f7c9; hold kept through the two short holds (documented); DECISIONS duplicate removed
f5bd2a3520 MAINT-28: re-pin test_safety84 n2_charge_banked (the charge no longer restarts in the 5000 W load)
Compare 12 commits »
admin merged pull request admin/goodwe-addon#247 2026-11-13 06:23:13 +01:00
MAINT-28: during a real peak the maintenance charge stays paused
admin pushed to MAINT-28 at admin/goodwe-addon 2026-11-13 05:53:58 +01:00
e7706150e8 MAINT-28: DECISIONS gives the measured reason for the uncapped give (review M-1); ctl_cycle comment one line + pointer (L-1)
admin commented on pull request admin/goodwe-addon#247 2026-11-13 05:51:05 +01:00
MAINT-28: during a real peak the maintenance charge stays paused

MAINT-28 review of 7edf848 (independent, Opus). Verdict: NOT READY. One docs change only; the code is fine.

The code, the tests, CI and the local suite all pass. The only thing blocking is a…

admin pushed to MAINT-28 at admin/goodwe-addon 2026-11-13 03:57:34 +01:00
7edf8484d1 MAINT-28: test_maint28 reads the replay clock directly (main_files.live parsed every app file per cycle): 269 s -> 28 s, same numbers
admin pushed to MAINT-28 at admin/goodwe-addon 2026-11-13 02:29:33 +01:00
29a8a05f30 MAINT-28: shorter test_maint28 runs (892 s -> ~280 s), digests re-pinned on 1b5f7c9; hold kept through the two short holds (documented); DECISIONS duplicate removed
admin pushed to MAINT-28 at admin/goodwe-addon 2026-11-13 00:59:44 +01:00
f5bd2a3520 MAINT-28: re-pin test_safety84 n2_charge_banked (the charge no longer restarts in the 5000 W load)
admin pushed to MAINT-28 at admin/goodwe-addon 2026-11-13 00:20:26 +01:00
bc5be4964e MAINT-28: N=1 digest test with a banked peak (so the N=1 gate is tested)
admin pushed to MAINT-28 at admin/goodwe-addon 2026-11-12 23:58:21 +01:00
edf30f345a MAINT-28: keep the single shaping_suspended(.., maint_aim) call site (test_peak_margin pin); shaping_held takes its answer
admin pushed to MAINT-28 at admin/goodwe-addon 2026-11-12 23:29:15 +01:00
23359a047d MAINT-28: test_maint28 points at MUTATION.md (test_bytecode)
admin pushed to MAINT-28 at admin/goodwe-addon 2026-11-12 23:14:01 +01:00
8640bfcbc1 MAINT-28: hold only where MAINT-24 moved the aim (banked peak above the cap); test_safety119 pins stay
admin pushed to MAINT-28 at admin/goodwe-addon 2026-11-12 22:44:34 +01:00
92f0387415 MAINT-28: reset the hold every cycle, test it; digests vs 1b5f7c9; DECISIONS numbers and mutants