• Joined on 2025-08-30
admin pushed to SAFETY-126 at admin/goodwe-addon 2026-10-31 11:52:31 +01:00
a66a7f1a0f SAFETY-126 round 2: state what the 10 W tolerance costs; test the latch reset
admin commented on pull request admin/goodwe-addon#221 2026-10-31 10:44:28 +01:00
SAFETY-126: no false peak reserve alarm during the night grid charge

SAFETY-126 review (head 8e2463b) - not merged, owner decision needed

The cause is right and the fix removes the rig's false alarm with identical commands. But I found two cases that the brief…

admin created pull request admin/goodwe-addon#221 2026-10-31 01:55:09 +01:00
SAFETY-126: no false peak reserve alarm during the night grid charge
admin pushed to SAFETY-126 at admin/goodwe-addon 2026-10-31 01:54:48 +01:00
8e2463bc32 SAFETY-126: test reads through named_absence; points at MUTATION.md
40595e42ae SAFETY-126: a landing error on the aim is not an overrun
Compare 2 commits »
admin created branch SAFETY-126 in admin/goodwe-addon 2026-10-31 01:54:48 +01:00
admin commented on pull request admin/goodwe-addon#219 2026-10-30 22:16:43 +01:00
OPT-27: the night cheap run is judged with the last fresh forecast

OPT-27 re-review (round 3, head b9dea6d): approved and merged.

  • F1: KEPT_MAX_AGE_S (12 h) is enforced in Hold.stand_in. A reading taken at 00:05 is no longer used at 20:00, 23:00 or…
admin pushed to release/1.0 at admin/goodwe-addon 2026-10-30 22:16:35 +01:00
cc9bbeb73e Merge pull request 'OPT-27: the night cheap run is judged with the last fresh forecast' (#219) from OPT-27 into release/1.0
b9dea6d90d OPT-27 round 3: the kept-forecast wording states the 12 h limit (text only)
13b61d586a OPT-27 round 3: a kept figure is at most 12 h old; DST-safe midnight bound; pruning test
307cb47caf OPT-27 review: the kept forecast line says "kept for tonight"
60aa7f310c OPT-27: a kept figure sizes the night under OPT-28's shortfall, as a fresh one does
Compare 8 commits »
admin merged pull request admin/goodwe-addon#219 2026-10-30 22:16:33 +01:00
OPT-27: the night cheap run is judged with the last fresh forecast
admin pushed to OPT-27 at admin/goodwe-addon 2026-10-30 21:29:32 +01:00
b9dea6d90d OPT-27 round 3: the kept-forecast wording states the 12 h limit (text only)
admin pushed to OPT-27 at admin/goodwe-addon 2026-10-30 20:57:44 +01:00
13b61d586a OPT-27 round 3: a kept figure is at most 12 h old; DST-safe midnight bound; pruning test
admin commented on pull request admin/goodwe-addon#219 2026-10-30 20:31:51 +01:00
OPT-27: the night cheap run is judged with the last fresh forecast

OPT-27 review (Opus), head 60aa7f3 → 307cb47 (text only). Verdict: changes requested, not merged.

The fix works for the case on the card: with sensors stuck at 17:05, the 22:00 night run is…

admin pushed to OPT-27 at admin/goodwe-addon 2026-10-30 20:11:17 +01:00
307cb47caf OPT-27 review: the kept forecast line says "kept for tonight"
admin pushed to OPT-27 at admin/goodwe-addon 2026-10-30 19:14:20 +01:00
60aa7f310c OPT-27: a kept figure sizes the night under OPT-28's shortfall, as a fresh one does
bf842997c1 OPT-27 round 2: a kept tomorrow figure is bounded on both sides
4fde0b177c OPT-27: test_modes_p4 says what a covered sensor does; test_opt27 guards
50b567d6d1 OPT-27: the night plan keeps the last fresh solar forecast
f1b72443ff Merge pull request 'Sync 0.19.x into release/1.0: TARIFF-24 and SAFETY-125, with the forward-port fixes' (#220) from sync-0.19 into release/1.0
Compare 22 commits »
admin commented on pull request admin/goodwe-addon#220 2026-10-30 18:52:08 +01:00
Sync 0.19.x into release/1.0: TARIFF-24 and SAFETY-125, with the forward-port fixes

Merged as f1b72443ff425606b9ecb8ce9e3da02271a537c7 (merge commit, parents b6be312 and 60a3fa6, head_commit_id set to 60a3fa6). The tree is identical to 60a3fa6. ls-remote shows release/1.0 at…

admin pushed to release/1.0 at admin/goodwe-addon 2026-10-30 18:51:56 +01:00
f1b72443ff Merge pull request 'Sync 0.19.x into release/1.0: TARIFF-24 and SAFETY-125, with the forward-port fixes' (#220) from sync-0.19 into release/1.0
60a3fa615e TARIFF-24 forward-port: part 6 reads its last row through nth() (test_named_absence)
1c9fefd9dd Sync 0.19: the Forecast tab extends a cheap run with control's gap (TARIFF-24)
8cca671a05 TARIFF-24 / SAFETY-125 forward-port: record text (review F2, F3, CHANGELOG nit)
9dc22fb987 TARIFF-24 forward-port: pin the hold's edges (review F1, F2)
Compare 31 commits »
admin merged pull request admin/goodwe-addon#220 2026-10-30 18:51:54 +01:00
Sync 0.19.x into release/1.0: TARIFF-24 and SAFETY-125, with the forward-port fixes
admin commented on pull request admin/goodwe-addon#220 2026-10-30 18:51:15 +01:00
Sync 0.19.x into release/1.0: TARIFF-24 and SAFETY-125, with the forward-port fixes

SYNC-0.19 review: approve and merge (head 60a3fa6)

No router verdict exists for this PR, so this review is the only independent check. I pushed nothing.

What I checked

  • **The merge is…
admin created pull request admin/goodwe-addon#220 2026-10-30 08:30:45 +01:00
Sync 0.19.x into release/1.0: TARIFF-24 and SAFETY-125, with the forward-port fixes
admin pushed to sync-0.19 at admin/goodwe-addon 2026-10-30 08:30:34 +01:00
60a3fa615e TARIFF-24 forward-port: part 6 reads its last row through nth() (test_named_absence)
1c9fefd9dd Sync 0.19: the Forecast tab extends a cheap run with control's gap (TARIFF-24)
8cca671a05 TARIFF-24 / SAFETY-125 forward-port: record text (review F2, F3, CHANGELOG nit)
9dc22fb987 TARIFF-24 forward-port: pin the hold's edges (review F1, F2)
5ac1017eed UX-54 scenarios keep the gate they were written for (cycle cost 0.15 with a forecast)
Compare 6 commits »
admin created branch sync-0.19 in admin/goodwe-addon 2026-10-30 08:30:34 +01:00