• Joined on 2025-08-30
admin commented on pull request admin/goodwe-addon#223 2026-11-01 03:19:07 +01:00
MAINT-20 part 1: comments and docstrings in peakguard and the price files

MAINT-20 part 1 review (independent, Opus)

Reviewed head 6e2fde6, base release/1.0 8afadbd (both as expected). I pushed one comment/DECISIONS-only commit, 63dda4b.

Checks

  • No…
admin pushed to MAINT-20-1 at admin/goodwe-addon 2026-11-01 03:04:11 +01:00
63dda4b0d3 MAINT-20 part 1 review: restore three lost lines, rewrap ragged comments
admin pushed to MAINT-20-1 at admin/goodwe-addon 2026-11-01 01:56:02 +01:00
6e2fde63ff MAINT-20 part 1: peakguard.py keeps the reference-pack sentence a test pins
admin created pull request admin/goodwe-addon#223 2026-11-01 01:20:29 +01:00
MAINT-20 part 1: comments and docstrings in peakguard and the price files
admin pushed to MAINT-20-1 at admin/goodwe-addon 2026-11-01 01:20:19 +01:00
72ccfd788c MAINT-20 part 1: price_chain.py comments trimmed
c432d4e419 MAINT-20 part 1: price_forecast.py comments and docstrings cut
50332d4190 MAINT-20 part 1: DECISIONS note for the forecast fill (FCST-03)
eda6d0aed1 MAINT-20 part 1: custom_formula.py comments cut; new TARIFF-16 note
a3f725e8a4 MAINT-20 part 1: price_history.py comments cut; FCST-04 note gets the store details
Compare 10 commits »
admin created branch MAINT-20-1 in admin/goodwe-addon 2026-11-01 01:20:19 +01:00
admin commented on pull request admin/goodwe-addon#222 2026-11-01 00:20:46 +01:00
OPT-34: the night charge keeps its level when the kept forecast ends

OPT-34 re-review (round 3, bb57a85): PASS, merged into release/1.0 as 8afadbdd9a450996c997ebd456c9a15f3d5ae299. CI 1477/1478 green.

  • F1-F4 are fixed. The F1 owner-shape night now ends A and…
admin pushed to release/1.0 at admin/goodwe-addon 2026-11-01 00:19:12 +01:00
8afadbdd9a OPT-34: the night charge keeps its level when the kept forecast ends (#222)
bb57a85b35 OPT-34 round 3: the latch ends on time, with the run, with the mode, and with the night
57b0eb2f20 OPT-34 review: read the inverter in part 4 with a default
8f0af9f318 OPT-34 review: test that a battery leaving the plan leaves the latch
eee7616022 OPT-34 round 2: the latch follows the plan, up or down, and drops what left it
Compare 6 commits »
admin merged pull request admin/goodwe-addon#222 2026-11-01 00:19:10 +01:00
OPT-34: the night charge keeps its level when the kept forecast ends
admin pushed to OPT-34 at admin/goodwe-addon 2026-10-31 23:04:39 +01:00
bb57a85b35 OPT-34 round 3: the latch ends on time, with the run, with the mode, and with the night
admin commented on pull request admin/goodwe-addon#222 2026-10-31 21:43:41 +01:00
OPT-34: the night charge keeps its level when the kept forecast ends

OPT-34 review (Opus): CHANGES REQUESTED. Not merged. Reviewed eee7616. The reviewer pushed tests only: 8f0af9f, then 57b0eb2 (CI 1475 checks/unit success, 1476 infra-pin success). Local suite…

admin pushed to OPT-34 at admin/goodwe-addon 2026-10-31 21:19:02 +01:00
57b0eb2f20 OPT-34 review: read the inverter in part 4 with a default
admin pushed to OPT-34 at admin/goodwe-addon 2026-10-31 20:50:04 +01:00
8f0af9f318 OPT-34 review: test that a battery leaving the plan leaves the latch
admin pushed to OPT-34 at admin/goodwe-addon 2026-10-31 19:17:24 +01:00
eee7616022 OPT-34 round 2: the latch follows the plan, up or down, and drops what left it
admin created pull request admin/goodwe-addon#222 2026-10-31 17:00:42 +01:00
OPT-34: the night charge keeps its level when the kept forecast ends
admin created branch OPT-34 in admin/goodwe-addon 2026-10-31 17:00:33 +01:00
admin pushed to OPT-34 at admin/goodwe-addon 2026-10-31 17:00:33 +01:00
412e47f111 OPT-34: the night charge keeps its level when the kept forecast ends
admin merged pull request admin/goodwe-addon#221 2026-10-31 12:26:05 +01:00
SAFETY-126: no false peak reserve alarm during the night grid charge
admin pushed to release/1.0 at admin/goodwe-addon 2026-10-31 12:26:05 +01:00
deee98d352 Merge pull request 'SAFETY-126: no false peak reserve alarm during the night grid charge' (#221) from SAFETY-126 into release/1.0
a66a7f1a0f SAFETY-126 round 2: state what the 10 W tolerance costs; test the latch reset
8e2463bc32 SAFETY-126: test reads through named_absence; points at MUTATION.md
40595e42ae SAFETY-126: a landing error on the aim is not an overrun
Compare 4 commits »
admin commented on pull request admin/goodwe-addon#221 2026-10-31 12:26:03 +01:00
SAFETY-126: no false peak reserve alarm during the night grid charge

SAFETY-126 re-review (head a66a7f1): approved, merging

Owner decision 2026-10-31: the 10 W tolerance is accepted (B1, B2).

  • Diff 8e2463b..a66a7f1: only CHANGELOG, DECISIONS, DOCS and…