admin/goodwe-addon
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Sync 0.20.1 (master) into release/1.0 #233

Open
admin wants to merge 18 commits from sync-0.20.1 into release/1.0
pull from: sync-0.20.1
merge into: :release/1.0
Conversation 0 Commits 18 Files Changed 15
+1292 -69
admin commented 2026-11-05 18:34:42 +01:00
Owner
Copy Link
Copy Source

Real merge (--no-ff) of master d53f70f (v0.20.1: OPT-36 #229, TEST-37 #231) into release/1.0 371961e (SAFETY-128 #228). No textual conflicts. config.yaml 0.20.1; CHANGELOG: SAFETY-128 entry moved from the 0.20.0 section to "Not in a release yet" above 0.20.1; 0.20.0/0.20.1 sections as on master. No behaviour change beyond the two sides. Do not squash.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC

Real merge (--no-ff) of master d53f70f (v0.20.1: OPT-36 #229, TEST-37 #231) into release/1.0 371961e (SAFETY-128 #228). No textual conflicts. config.yaml 0.20.1; CHANGELOG: SAFETY-128 entry moved from the 0.20.0 section to "Not in a release yet" above 0.20.1; 0.20.0/0.20.1 sections as on master. No behaviour change beyond the two sides. Do not squash. 🤖 Generated with [Claude Code](https://claude.ai/code) https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC
admin added 18 commits 2026-11-05 18:34:42 +01:00
Release 0.20.0: release/1.0 -> master (#227) 01e88a24f2
OPT-36: Leftover solar counts what Cheap hours and Solar first batteries will give before buying
checks / unit (pull_request) Failing after 59m31s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
05746c0564 
Live 0.20.0: A (Leftover solar, 60 %) charged to 95 % while B (Cheap hours,
94 %) already covered the expensive hours. dayplan.plan() now takes off the
shortfall what Cheap hours batteries will hold when the hours start (the
ceiling or what their cheap run reaches under the peak aim) and what Solar
first batteries will still hold after the night's use. Home reads a give
block after the planned charge, plan_cover() is the plan's own figure, and
the Why line says other batteries cover.

Co-Authored-By: Claude <noreply@anthropic.com>
OPT-36: test a give block before tonight's charge, Solar first refusing and in maintenance
checks / unit (pull_request) Failing after 26m32s
Details
infra-pin / fresh (pull_request) Successful in 4s
Details
490f67924b 
Co-Authored-By: Claude <noreply@anthropic.com>
OPT-36: test_opt36 reads possibly-missing values through nth()
checks / unit (pull_request) Failing after 35m3s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
60674e45ba 
Co-Authored-By: Claude <noreply@anthropic.com>
OPT-36: test_opt34 and test_ux54 scenarios keep a shortfall B does not cover
checks / unit (pull_request) Successful in 27m17s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
6a527de851 
With Cheap hours B counted, A buys only what B cannot reach. The OPT-34
night scenarios use a 1.6 x larger house profile, and the ux54 tab scenarios
a 4.8 kW evening (ux54_scenarios.make(evening=)), so A still charges; the
hard-coded levels become relations.

Co-Authored-By: Claude <noreply@anthropic.com>
OPT-36 round 2: test_opt34 keeps its tolerances; fresh sensors read the day they are on
checks / unit (pull_request) Successful in 20m36s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
3a18475a5a 
The silent and fresh nights diverged only because the test's fresh sensors
kept reading the evening's 0.4 kWh 'left today' after midnight, while the
kept figure is the 4th's 6.0 kWh (solarfc.Hold.stand_in, as_today): two
different shortfalls (16.5 and 12.7 kWh) that A's ceiling hid until B was
counted. Fresh sensors now read 6.0 after midnight, so fresh and kept are
the same figure; the 0.3 tolerance is back, the other exact values are
recomputed. test_ux54 literals are recomputed too.

Co-Authored-By: Claude <noreply@anthropic.com>
OPT-36 round 3: B's charge counts the cheap time left; OPT-34 nights on their own shapes
checks / unit (pull_request) Failing after 36m29s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
e4b9dee699 
The run is sized at the batteries' ratings, not the peak limit, so a run too
short to fill a Cheap hours battery is planned again later in the night.
Counting that run alone made B's give grow through the night and A's level
fall after A had bought (round 2: 55 -> 69 -> 41 -> 37 %, A to 56 %).
dayplan._cheap_give_kwh() now also counts the later firm slots before the
expensive hours that a run would still be worth charging in (price + the
spread control asks at most the give run's dearest slot); the Controller
passes the slots and the spread.

test_opt34: back to the original house shapes, fixture and expected values.
B is Off in the nights that test A's level (a Cheap hours B now covers
these hours); B's checks run in new `_b` nights; the 03:00 check runs in a
night from midnight; tail starts A at 60 %; late_fresh reads the kept 6.0.
test_opt36: slot cases, a whole night on one figure (level never moves),
F-1 with B counted (raised level reached and held). test_ux54: the run end
is read from the plan and asserted (02:30); the F1/F2 sweep uses a peak
limit that does not bind and reads a level shown as the target as at it.

Co-Authored-By: Claude <noreply@anthropic.com>
OPT-36 round 3: test_opt36 reads the mid_flat level through nth()
checks / unit (pull_request) Successful in 26m38s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
1ac7fe98d7 
Co-Authored-By: Claude <noreply@anthropic.com>
OPT-36 round 4: count only charge control will make; Solar first drain at the night base
checks / unit (pull_request) Successful in 44m14s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
eb9ccc2730 
Review F1: a slot after B's run counts only if no slot from the expensive
hours on is cheaper (control plans B's charge left in the cheapest window
ahead), and x 0.95 of B's charge is stored. Three-price night: 1ac7fe9 left
the expensive hours 2.61 kWh short; now 0.
Review F2: a Solar first battery's drain until the expensive hours reads each
hour at no less than the night base (the profile is net of the sun). Read net,
a dark morning drained the battery the plan still counted; A's level fell,
the cheap run moved and was lost before it started (+0.40 EUR per 3 days).
The two real-price replays now cost what 0.20.0 does.
F3: the ux54 sweep's peak limit is 15 kW (the option's top). F4: the rest
comes from the grid (EN/NL). F5: CHANGELOG and DECISIONS wording.

Co-Authored-By: Claude <noreply@anthropic.com>
Merge pull request 'OPT-36: Leftover solar counts Cheap hours and Solar first batteries before buying' (#229) from OPT-36 into hotfix-0.20.1 22d09f8fe7
Release 0.20.1
checks / unit (pull_request) Successful in 28m19s
Details
infra-pin / fresh (pull_request) Successful in 1s
Details
ec4ba49f45 
Patch bump: OPT-36 (Leftover solar counts Cheap hours only and Solar first batteries). No option changes.

Co-Authored-By: Claude <noreply@anthropic.com>
REL-0.20.1 review: CHANGELOG known issues SAFETY-132/133 wording
checks / unit (pull_request) Failing after 22m19s
Details
infra-pin / fresh (pull_request) Successful in 1s
Details
01eba51dd7 
SAFETY-132: the 9.6 kW is the charge the add-on asked for in a test,
not a measured grid figure. SAFETY-133: the quarter also ends over the
3 500 W limit; the guard sees the load late (0.20.1 has no lateness check).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TEST-37: test_opt34 builds the first Controller under the scenario clock
checks / unit (pull_request) Successful in 30m38s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
95bb214155 
The stale_live scenario stores a latch ending 2026-11-04 07:15 CET. The first
Controller was built before the datetime patch, so Controller.__init__ judged
that latch against the real clock and it expired on 2026-11-04. Build it after
the patch (clock = scenario start), as the restart path already did. Test-only.

Co-Authored-By: Claude <noreply@anthropic.com>
Merge pull request 'TEST-37: test_opt34 stale_live no longer depends on the real clock' (#231) from TEST-37 into hotfix-0.20.1 cfe1f06286
Merge hotfix-0.20.1 (TEST-37 #231) into release-0.20.1
checks / unit (pull_request) Successful in 21m40s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
2fa14e23dc 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge pull request 'Release 0.20.1' (#230) from release-0.20.1 into hotfix-0.20.1
checks / unit (pull_request) Successful in 21m15s
Details
infra-pin / fresh (pull_request) Successful in 1s
Details
3219aea9a0
Release 0.20.1: hotfix-0.20.1 -> master (#232) d53f70f93e
Merge origin/master (0.20.1) into release/1.0
checks / unit (pull_request) Successful in 32m4s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
4f96397a60 
Brings OPT-36 (#229) and TEST-37 (#231) onto release/1.0, which keeps
SAFETY-128 (#228). No textual conflicts. CHANGELOG: the SAFETY-128 entry
moved out of the released 0.20.0 section into "Not in a release yet" above
## 0.20.1; the 0.20.0 and 0.20.1 sections are identical to master.

Co-Authored-By: Claude <noreply@anthropic.com>
All checks were successful
checks / unit (pull_request) Successful in 32m4s
Required
Details
infra-pin / fresh (pull_request) Successful in 2s
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin sync-0.20.1:sync-0.20.1
git checkout sync-0.20.1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/goodwe-addon#233