admin/goodwe-addon
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

MAINT-20 part 1: comments and docstrings in peakguard and the price files #223

Merged
admin merged 12 commits from MAINT-20-1 into release/1.0 2026-11-01 03:24:55 +01:00
Conversation 1 Commits 12 Files Changed 12
+1395 -3584
12 Commits
Author SHA1 Message Date
glenn schrooyenandClaude Opus 5.5 63dda4b0d3 MAINT-20 part 1 review: restore three lost lines, rewrap ragged comments
checks / unit (pull_request) Successful in 19m51s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details 
Comment, docstring and DECISIONS only (same-code script OK; python -OO
bytecode now identical for all six files).
- peakguard.charge_room_w: one-line docstring + SAFETY-125 pointer (cut whole).
- peakguard.shaping_suspended: keep 'the one place this conjunction is
  written; do not inline it'.
- price_forecast module note: an hour with no price and no yesterday is left
  out, never filled (test_price.py 14d cites the module note for it).
- Refill comment blocks the cut left ragged; DECISIONS pointers on one line.
- FCST-04 note: _yesterday_of(), not _previous_day(); FCST-03 note: the 49
  stronger cases are why the rule is a real change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC
 2026-11-01 03:02:51 +01:00
glenn schrooyenandClaude 6e2fde63ff MAINT-20 part 1: peakguard.py keeps the reference-pack sentence a test pins
checks / unit (pull_request) Successful in 25m32s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:55:59 +01:00
glenn schrooyenandClaude 72ccfd788c MAINT-20 part 1: price_chain.py comments trimmed
checks / unit (pull_request) Failing after 38m0s
Details
infra-pin / fresh (pull_request) Successful in 2s
Details 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:19:29 +01:00
glenn schrooyenandClaude c432d4e419 MAINT-20 part 1: price_forecast.py comments and docstrings cut 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:19:29 +01:00
glenn schrooyenandClaude 50332d4190 MAINT-20 part 1: DECISIONS note for the forecast fill (FCST-03) 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:19:29 +01:00
glenn schrooyenandClaude eda6d0aed1 MAINT-20 part 1: custom_formula.py comments cut; new TARIFF-16 note 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:17:46 +01:00
glenn schrooyenandClaude a3f725e8a4 MAINT-20 part 1: price_history.py comments cut; FCST-04 note gets the store details 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:16:53 +01:00
glenn schrooyenandClaude c08eb124c8 MAINT-20 part 1: price.py comments and docstrings cut to a line and a pointer 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:15:46 +01:00
glenn schrooyenandClaude 194efac98d MAINT-20 part 1: DECISIONS note for the price provider plugins (TARIFF-02) 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:15:46 +01:00
glenn schrooyenandClaude 96ca66fc38 MAINT-20 part 1: peakguard.py comments and docstrings cut to a line and a pointer 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:13:48 +01:00
glenn schrooyenandClaude e0db3b0e8a MAINT-20 part 1: DECISIONS note for the peak guard (SAFETY-07, -24, CFG-03) 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:13:48 +01:00
glenn schrooyenandClaude f31307105a MAINT-20 part 1: same-code and ratio script 
Co-Authored-By: Claude <noreply@anthropic.com>
 2026-11-01 01:13:48 +01:00