OPT-34: the night charge keeps its level when the kept forecast ends #222

Merged

admin merged 5 commits from OPT-34 into release/1.0 2026-11-01 00:19:10 +01:00

Conversation 2 Commits 5 Files Changed 12

+1038 -65

5 Commits

Author	SHA1	Message	Date
glenn schrooyenandClaude	bb57a85b35	OPT-34 round 3: the latch ends on time, with the run, with the mode, and with the night ... - F1: an expired latch is dropped whatever the run state; plan_targets() and the store loader ignore one that has ended (no stale latch after a restart). - F2: the "charge goes on" line only while a cheap run is on. - F3: a battery that is off or no longer Leftover solar leaves the latch. - F4: a run carries the latch on only if it starts by the bell start (06:00 local) after the latch began (manager's call, 2026-10-31). Tests: test_opt34 scenarios stale/stale_live and part 5; test_modes_p4 asks at a moment inside the latch. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC	2026-10-31 23:04:36 +01:00
Claude (OPT-34 review)	57b0eb2f20	OPT-34 review: read the inverter in part 4 with a default ... test_named_absence.py flagged next() without a default (CI run 1473). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-31 21:18:59 +01:00
Claude (OPT-34 review)	8f0af9f318	OPT-34 review: test that a battery leaving the plan leaves the latch ... test_opt34.py part 4 drives Controller._latch_charge() directly: a battery that leaves the plan is dropped at once, does not rejoin while nothing charges, an empty latch is cleared from the store, and the screen says the charge goes on only while the latched battery is below its level. Catches two reviewer mutants that survived the round-2 tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-31 20:50:02 +01:00
glenn schrooyenandClaude	eee7616022	OPT-34 round 2: the latch follows the plan, up or down, and drops what left it ... While a forecast is present and the cheap run holds, the night-charge latch is rebuilt from the plan: a latched battery takes its current level whatever its role this tick (a fresh figure may lower it below the SoC), one that left the plan is dropped, a new one comes in only while it charges from the grid. Test: a fresh brighter figure lowers A below its SoC, the sensors go quiet, A does not charge back up. CHANGELOG summary says two fixes. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC	2026-10-31 19:17:20 +01:00
glenn schrooyenandClaude	412e47f111	OPT-34: the night charge keeps its level when the kept forecast ends ... With the forecast sensors silent from 17:05 the kept evening figure ended at midnight + 3 h, in the middle of the night grid charge, and Leftover solar's planned level went with it (rig: A 49.8 % against 79.9 %). - A night grid charge that has started keeps its planned level when the forecast goes (Controller._latch_charge, store key night_charge_latch), and the narrow price gap with it (weather_held). A fresh figure still moves the level. - The evening's tomorrow figure is today's until the bell starts (06:00 local), up to 15 h old but only if it was usable at midnight (solarfc.Hold.stand_in). - Screen: "No solar forecast now. The charge under way goes on to its planned level." (EN/NL) while a latched battery is below its level. - test_opt34.py (whole nights through the real control cycle, mutants), test_opt27 and test_modes_p4 adjusted to the new window and the kept level. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC	2026-10-31 17:00:31 +01:00