OPT-27: the night cheap run is judged with the last fresh forecast #219

Merged

admin merged 7 commits from OPT-27 into release/1.0 2026-10-30 22:16:33 +01:00

Conversation 2 Commits 7 Files Changed 11

+939 -22

7 Commits

Author	SHA1	Message	Date
glenn schrooyenandClaude	b9dea6d90d	OPT-27 round 3: the kept-forecast wording states the 12 h limit (text only) ... Co-Authored-By: Claude <noreply@anthropic.com>	2026-10-30 21:29:29 +01:00
glenn schrooyenandClaude	13b61d586a	OPT-27 round 3: a kept figure is at most 12 h old; DST-safe midnight bound; pruning test ... F1: the evening rule has an age limit (KEPT_MAX_AGE_S). F2: the evening bound is the next local midnight (_bounds), right on 25 h and 23 h days. F5: test that old days are dropped from the stored hold. Co-Authored-By: Claude <noreply@anthropic.com>	2026-10-30 20:41:34 +01:00
glenn schrooyenandClaude Opus 5.5	307cb47caf	OPT-27 review: the kept forecast line says "kept for tonight" ... With battery modes off the forecast is still read and shown (Settings, Simple, and the Forecast tab), but no plan uses it, so "used for tonight's plan" was not true there (UX-53). "Kept for tonight" is true in every shape. NL "vanavond" read wrong after midnight; "vannacht" covers the whole night. DECISIONS' "modes off: nothing reads the sensors" corrected. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC	2026-10-30 19:59:29 +01:00
glenn schrooyenandClaude	60aa7f310c	OPT-27: a kept figure sizes the night under OPT-28's shortfall, as a fresh one does ... Co-Authored-By: Claude <noreply@anthropic.com>	2026-10-30 18:57:37 +01:00
glenn schrooyenandClaude	bf842997c1	OPT-27 round 2: a kept tomorrow figure is bounded on both sides ... Hold.stand_in(): day0 <= now < day0 + 3 h. A tomorrow sensor is asked with day0 = the next midnight, so the upper bound alone was true all day and a figure stood in at any hour. test_opt27.py covers daytime tomorrow outages. Co-Authored-By: Claude <noreply@anthropic.com>	2026-10-30 18:54:41 +01:00
glenn schrooyenandClaude	4fde0b177c	OPT-27: test_modes_p4 says what a covered sensor does; test_opt27 guards ... test_modes_p4.py: 'the forecast is lost mid-run' now loses it for good (a hold that never covers); a second scenario is the same loss with the hold, which keeps Leftover solar charging. test_opt27.py: a failing check no longer hides the ones after it. Co-Authored-By: Claude <noreply@anthropic.com>	2026-10-30 18:54:41 +01:00
glenn schrooyenandClaude	50b567d6d1	OPT-27: the night plan keeps the last fresh solar forecast ... Forecast.Solar's sensors stop updating in the evening, so at night every such site had no forecast: the night cheap run needed 1.5x the cycle cost and Leftover solar planned nothing. One missed poll also dropped it at once. solarfc.Hold keeps the last fresh reading of each sensor, for the day it is for. A missing or stale sensor is covered by it for up to FRESH_S (a short outage), and from the end of the bell (20:00) until local midnight + 3 h however old. A tomorrow figure is tomorrow's until midnight and then today's; a today figure is only today's. Stored in the controller's store (solar_fc_hold), so an evening restart keeps it. The forecast line says 'Solar forecast read 17:05, used for tonight's plan.' (EN, NL). test_tariff24_weather.py runs with a hold that never covers: it tests what the plan does when the forecast IS lost. Co-Authored-By: Claude <noreply@anthropic.com>	2026-10-30 18:54:41 +01:00