Revert MAINT-28 (PR #247) from release/1.0 #249

Merged
admin merged 1 commits from MAINT-28-revert into release/1.0 2026-11-14 02:35:35 +01:00
Owner

What

Reverts PR #247 (merge f3f9483, MAINT-28) out of release/1.0, so the 19 Nov release ships MAINT-24 + MAINT-25 without MAINT-28. Owner go 2026-11-14.

Why

The rig failed f3f9483 (reports/MAINT-28-test-report.md), and the fix-forward PR #248 review found a High regression (reports/MAINT-28-fix-review-report.md).

Proof it is exact

  • git rev-parse HEAD^{tree} = 8846f0cb3c00d40286a3f1e594f67adf651eb0b7
  • git rev-parse 1b5f7c9^{tree} = 8846f0cb3c00d40286a3f1e594f67adf651eb0b7
  • git diff 1b5f7c9 HEAD is empty.

The tree equals 1b5f7c9, which passed review, CI and the MAINT-24 rig test. Locally passed: test_maint24, test_maint25, test_safety84, test_peakguard.

No CHANGELOG line for MAINT-28 (it does not ship); the MAINT-28 DECISIONS note leaves with the revert.

MAINT-28 continues on PR #248 after the release.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC

## What Reverts PR #247 (merge f3f9483, MAINT-28) out of `release/1.0`, so the 19 Nov release ships MAINT-24 + MAINT-25 without MAINT-28. Owner go 2026-11-14. ## Why The rig failed f3f9483 (`reports/MAINT-28-test-report.md`), and the fix-forward PR #248 review found a High regression (`reports/MAINT-28-fix-review-report.md`). ## Proof it is exact - `git rev-parse HEAD^{tree}` = `8846f0cb3c00d40286a3f1e594f67adf651eb0b7` - `git rev-parse 1b5f7c9^{tree}` = `8846f0cb3c00d40286a3f1e594f67adf651eb0b7` - `git diff 1b5f7c9 HEAD` is empty. The tree equals 1b5f7c9, which passed review, CI and the MAINT-24 rig test. Locally passed: test_maint24, test_maint25, test_safety84, test_peakguard. No CHANGELOG line for MAINT-28 (it does not ship); the MAINT-28 DECISIONS note leaves with the revert. MAINT-28 continues on PR #248 after the release. 🤖 Generated with [Claude Code](https://claude.ai/code) https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC
admin added 1 commit 2026-11-14 01:37:48 +01:00
Revert "MAINT-28: during a real peak the maintenance charge stays paused (#247)"
checks / unit (pull_request) Successful in 27m32s
infra-pin / fresh (pull_request) Successful in 2s
7bc8ad264b
Takes PR #247 (f3f9483) out of release/1.0 so the 19 Nov release ships
MAINT-24 + MAINT-25 without MAINT-28. The rig failed f3f9483
(reports/MAINT-28-test-report.md) and the fix-forward PR #248 review found
a High regression (reports/MAINT-28-fix-review-report.md). MAINT-28
continues on PR #248 after the release.

Co-Authored-By: Claude <noreply@anthropic.com>
admin merged commit 4c0122a8b6 into release/1.0 2026-11-14 02:35:35 +01:00
Author
Owner

Reviewed and merged. One revert commit; tree 8846f0cb equals 1b5f7c9, diff empty; CI 1647/1648 green; no MAINT-28 CHANGELOG line. Merge 4c0122a, tree still 8846f0cb. MAINT-28 continues on #248.

Reviewed and merged. One revert commit; tree 8846f0cb equals 1b5f7c9, diff empty; CI 1647/1648 green; no MAINT-28 CHANGELOG line. Merge 4c0122a, tree still 8846f0cb. MAINT-28 continues on #248.
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/goodwe-addon#249