CI-14: infra-pin to admin/goodwe 3b4ff84 (WITNESS-09) #172

Merged
admin merged 1 commits from ci-14-infra-pin-3b4ff84 into release/1.0 2026-10-05 00:45:16 +02:00
Owner

Bumps .gitea/infra-pin from 0c04488a9194039c2bf851b680a8ffc53beff671 to 3b4ff84757f9c2c5b63a4b4a53e593ccaeafb847, the head of admin/goodwe release/1.0 (checked with git ls-remote). Only that one line changes.

admin/goodwe 0c04488..3b4ff84 (fast-forward, 3 commits)

  • WITNESS-09 #64 (019c523, 1407a3c, merge 3b4ff84): the 'inverter not answering' alarm now fires on a real outage, on both buses, with one push per bus.
    • ha/goodwe-witness-alert.yaml: one trigger template per bus.
    • tools/witness_alert_bus_check.py and tools/ux08_text_check.py: checks for the new alarm.
    • sim/inject.py: the deaf_inverter scenario now grades the HA package's predicate, using new constants HA_* and _ha_unanswered().
    • Also: docs (DECISIONS, alerts, commissioning-b) and one comment in admin/goodwe's checks.yml.

Impact on the add-on: none

  • The add-on reads only ../goodwe/sim/. sim/hwsim.py and sim/sitesim.py are the same at both commits; inject.py is the only file in sim/ that changed.
  • tools/alloc_sim.py (run by test_tool_inputs.py) imports inject, but only uses sitesim. What inject.py adds at module level is constants and one function, with no new imports. Its witness_mqtt import stays inside the deaf_inverter function, which the add-on never calls.
  • The add-on does not reference deaf_inverter, the witness package or the witness check tools.

Local run

Image goodwe-addon-checks:1, GOODWE_REQUIRE_HWSIM=1, laid out as CI does (/w/goodwe-addon plus /w/goodwe at 3b4ff84): 62/62 PASS, exit 0, including test_freeze.py against the real hwsim and test_tool_inputs.py (alloc_sim, which imports inject). Log: scratch/CI-14/local-suite.log.

🤖 Generated with Claude Code

https://claude.ai/code/session_019DBUfvndgHwaV339Fvd2gr

Bumps `.gitea/infra-pin` from 0c04488a9194039c2bf851b680a8ffc53beff671 to `3b4ff84757f9c2c5b63a4b4a53e593ccaeafb847`, the head of admin/goodwe release/1.0 (checked with `git ls-remote`). Only that one line changes. ## admin/goodwe 0c04488..3b4ff84 (fast-forward, 3 commits) - WITNESS-09 #64 (019c523, 1407a3c, merge 3b4ff84): the 'inverter not answering' alarm now fires on a real outage, on both buses, with one push per bus. - `ha/goodwe-witness-alert.yaml`: one trigger template per bus. - `tools/witness_alert_bus_check.py` and `tools/ux08_text_check.py`: checks for the new alarm. - `sim/inject.py`: the `deaf_inverter` scenario now grades the HA package's predicate, using new constants `HA_*` and `_ha_unanswered()`. - Also: docs (DECISIONS, alerts, commissioning-b) and one comment in admin/goodwe's checks.yml. ## Impact on the add-on: none - The add-on reads only `../goodwe/sim/`. `sim/hwsim.py` and `sim/sitesim.py` are the same at both commits; `inject.py` is the only file in `sim/` that changed. - `tools/alloc_sim.py` (run by `test_tool_inputs.py`) imports `inject`, but only uses `sitesim`. What `inject.py` adds at module level is constants and one function, with no new imports. Its `witness_mqtt` import stays inside the `deaf_inverter` function, which the add-on never calls. - The add-on does not reference `deaf_inverter`, the witness package or the witness check tools. ## Local run Image `goodwe-addon-checks:1`, `GOODWE_REQUIRE_HWSIM=1`, laid out as CI does (`/w/goodwe-addon` plus `/w/goodwe` at 3b4ff84): 62/62 PASS, exit 0, including test_freeze.py against the real hwsim and test_tool_inputs.py (alloc_sim, which imports inject). Log: scratch/CI-14/local-suite.log. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_019DBUfvndgHwaV339Fvd2gr
admin added 1 commit 2026-10-05 00:13:25 +02:00
CI-14: infra-pin to admin/goodwe 3b4ff84 (WITNESS-09)
checks / unit (pull_request) Successful in 29m18s
infra-pin / fresh (pull_request) Successful in 1s
64dddd64bf
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

CI-14 review: OK to merge.

  1. Diff: one line in .gitea/infra-pin, 0c04488... to 3b4ff84757f9c2c5b63a4b4a53e593ccaeafb847; comment line unchanged. git ls-remote admin/goodwe refs/heads/release/1.0 = 3b4ff84..., as the README ("CI and the infra pin") requires.
  2. Impact: 0c04488..3b4ff84 is a fast-forward (3 commits). In sim/, only inject.py changed. Its module-level additions are three float constants and _ha_unanswered(); the top-level imports are identical at both commits and no new top-level statements run at import. tools/alloc_sim.py imports inject but uses only sitesim. The add-on does not reference deaf_inverter, witness_mqtt, the witness package or its check tools.
  3. CI: I read run 1169 / job 2318 via the API. head_sha 64dddd6, event pull_request, success. Log shows infra: admin/goodwe @ 3b4ff84, GOODWE_REQUIRE_HWSIM=1, 62 test files, 62 PASS, 0 FAIL, test_freeze part 3 against /w/goodwe/sim/hwsim.py, about 29 min, "Job succeeded". Not skipped. infra-pin / fresh (run 1170) is green.

Merging with head_commit_id pinned to 64dddd6.

CI-14 review: OK to merge. 1. Diff: one line in `.gitea/infra-pin`, 0c04488... to `3b4ff84757f9c2c5b63a4b4a53e593ccaeafb847`; comment line unchanged. `git ls-remote admin/goodwe refs/heads/release/1.0` = 3b4ff84..., as the README ("CI and the infra pin") requires. 2. Impact: 0c04488..3b4ff84 is a fast-forward (3 commits). In `sim/`, only `inject.py` changed. Its module-level additions are three float constants and `_ha_unanswered()`; the top-level imports are identical at both commits and no new top-level statements run at import. `tools/alloc_sim.py` imports `inject` but uses only `sitesim`. The add-on does not reference `deaf_inverter`, `witness_mqtt`, the witness package or its check tools. 3. CI: I read run 1169 / job 2318 via the API. head_sha 64dddd6, event pull_request, success. Log shows `infra: admin/goodwe @ 3b4ff84`, `GOODWE_REQUIRE_HWSIM=1`, 62 test files, 62 PASS, 0 FAIL, test_freeze part 3 against /w/goodwe/sim/hwsim.py, about 29 min, "Job succeeded". Not skipped. `infra-pin / fresh` (run 1170) is green. Merging with head_commit_id pinned to 64dddd6.
admin merged commit 3129daed62 into release/1.0 2026-10-05 00:45:16 +02:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/goodwe-addon#172