admin/goodwe-addon
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

UX-53 review: DECISIONS text, day/night weekend case and peak guard limit
checks / unit (pull_request) Successful in 48m2s
Details
infra-pin / fresh (pull_request) Successful in 1s
Details

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
glenn schrooyen
2026-10-26 13:10:49 +01:00
co-authored by Claude Opus 5.5
parent 242cf434f4
commit 5dfe9720c5
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
goodwe_controller/DECISIONS/UX-53-home-follows-the-gate.md
+9 -5
View File
@@ -16,8 +16,9 @@ Home asks the add-on's own gate, and does not decide for itself.
- **Modes off.** A charge the verdict puts after its last dear period is - **Modes off.** A charge the verdict puts after its last dear period is
refused when its time comes: the quarters left are all equal. `leg_taken()` refused when its time comes: the quarters left are all equal. `leg_taken()`
asks `trade_verdict()` (the control cycle's own call) at the leg's start and asks `trade_verdict()` (the control cycle's own call) at the leg's start and
keeps the leg only if the gate allows it there. A leg in progress is the verdict's own answer now. The keeps the leg only if the gate allows it there. A leg in progress is the
sale, "Tomorrow:" lines and chart marks use the same answer. verdict's own answer now. The sale, "Tomorrow:" lines and chart marks use
the same answer.
- **Words.** "Lowest/Highest published price" becomes "Lowest/Highest price - **Words.** "Lowest/Highest published price" becomes "Lowest/Highest price
left" (the verdict reads only the periods not yet over). The flat-tariff left" (the verdict reads only the periods not yet over). The flat-tariff
refusal calls a site "a fully fixed product" only when its product is fixed. refusal calls a site "a fully fixed product" only when its product is fixed.
@@ -26,11 +27,14 @@ Home asks the add-on's own gate, and does not decide for itself.
No control decision, command or option. Day/night and hourly sites with a No control decision, command or option. Day/night and hourly sites with a
second day of prices keep both legs at every half hour of a day second day of prices keep both legs at every half hour of a day
(`test_ux53.py` part 4); price-off sites draw nothing, as before. (`test_ux53.py` part 4), except where every price left is equal: with an
all-night weekend, Friday's 22:00 charge is no longer drawn, as the add-on
does not take it. Price-off sites draw nothing, as before.
## Limits ## Limits
The leg's gate is asked on today's plan, as the control cycle will find it at The leg's gate is asked on today's plan, as the control cycle will find it at
that time. A plan that gets new prices in between is drawn again at the next that time. A plan that gets new prices in between is drawn again at the next
refresh. While the peak guard holds, a modes-on page shows no charge for that refresh. While the peak guard holds, a modes-on page shows no grid charge at
time, as the modes-off page already did. all, also not the rest of a run the add-on charges in once the guard clears,
as the modes-off page already did.