glenn schrooyenandClaude Opus 5
7b4877d56d
checks / unit (pull_request) Successful in 3m35s
FCST-03's developer reverted `self.provisional` to `here.provisional`, re-ran, and reported the mutation as a survivor. It was not one. CPython validates a cached `.pyc` on (source size, source mtime truncated to whole seconds), and that edit moved neither number - same length, same second - so the interpreter loaded the bytecode it already had. Disassembly settled it at the time: the source read `here`, the running code loaded `self`. A mutation run had graded code that was not there, with no error and exit status 0. This does not make the results already on the record wrong. It makes them UNVERIFIED, and that distinction is the whole card - so nothing here re-runs a campaign and nothing here quietly assumes the old numbers hold. REPRODUCED, THEN CLOSED. test_bytecode.py builds a real package whose two return values are the same length, imports it in a real subprocess, rewrites it inside the same second (retrying until both writes land in one whole second - milliseconds, no sleep) and reads back which value ran. Part 1 shows the interpreter running SELF off a file that says HERE. AND THE TWO OBVIOUS MITIGATIONS DO NOT WORK. Measured, not read off documentation: `python3 -B` and PYTHONDONTWRITEBYTECODE=1 are write-side only. Neither stops an EXISTING stale .pyc being read, and a mutation run always has one, because the previous run wrote it. Part 2 grades both still running the old code. The advice in test_control.py's coverage audit led with `-B`; it is corrected here - the purge is the half that works, and `-B` earns its place by keeping THIS run from leaving a cache for the NEXT edit to inherit. NO SLEEP ANYWHERE. One-second mtime resolution is the mechanism, not the enemy. Waiting it out would slow every run down and would still only cover the edit somebody remembered to slow down. THE HARNESS. tools/mutation_run.sh purges, prints a sha256/byte fingerprint of every app/*.py it is about to grade - so a mutation report can say WHICH source produced it, which is the reviewer's addition to this card - runs each suite under `python3 -B`, refuses a tree with no test_*.py (CI-01's rule, for CI-01's reason), and fails if a cache appears during the run. It takes the tree as an argument so the infra repo's replay harnesses can call it without being moved. WHERE IT IS SAID (AC 2). MUTATION.md carries the mechanism, the measurement, the reporting rules and the survey, and every one of the 16 suites now points at it from its docstring. That list is DERIVED FROM THE TREE by test_bytecode.py part 5, so a new suite that joins this directory without the pointer is red - the same failure shape CI-01's file glob exists to prevent. CI WAS ALREADY IMMUNE, AND IS DESCRIBED THAT WAY (AC 4). Verified rather than reasoned: with the checkout bind mounted `-v "$WS:/w:ro"` the interpreter writes no __pycache__ into the tree at all, and it fails SILENTLY - no error, exit status 0 - while the same probe on a writable mount produces one. Each job also rm -rf's its workspace and clones afresh, so nothing crosses between jobs on the shared runner. PYTHONDONTWRITEBYTECODE=1 is added as belt and braces only: the `:ro` is one character wide and the next person debugging a write will be tempted by it. Part 6 grades both ON THE DOCKER COMMAND LINE rather than on the file - the first draft searched the whole workflow and stayed green after the flag was deleted, because the comment explaining it still named it. THE SHIPPED ADD-ON IS NOT AFFECTED and the question is closed: goodwe_controller/Dockerfile has set PYTHONDONTWRITEBYTECODE=1 since it was written. There is no deploy-side finding. THE SURVEY (AC 3), in MUTATION.md, scoped BY THE PROPERTY. The defect is one-directional - a mutation that never took leaves the suite green, so stale bytecode manufactures SURVIVORS and cannot manufacture a red - which puts every "all red, no survivors" claim in the window out of scope, along with mutations executed in-process (SAFETY-07's B1/B2/B3, test_peakguard parts 7 and 10, where no source file is edited) and everything run after the purge discipline landed on 2026-08-31 (SAFETY-24, SAFETY-26, OPT-04, FCST-03's re-run). What is left is the recorded SURVIVORS from source-edit runs before that date. Two were re-run here under the harness and both still stand: TARIFF-01's record_block() ignoring its policy argument, and SAFETY-03's abs() on the clamp limit - 15 suites green each, on the tree as it stood. The rest are labelled still-unverified rather than assumed or re-run; each is one harness run to close, and the moment to spend it is when somebody next touches that module. OUT OF SCOPE AND RECORDED: the infra repo's sim/ replay harnesses import the add-on and write bytecode into both trees (goodwe/sim/__pycache__ exists today), so SAFETY-02's headline replay carries the same exposure. mutation_run.sh takes a tree argument for exactly that, but the change belongs in that repo and some of those harnesses want the rig. RED AND GREEN. Every new check was broken and watched fail: the purge commented out of the harness turns part 4 red (and its non-vacuity probe already proves the fixture would mis-grade without it); one docstring pointer removed turns part 5 red naming the file; `:ro` and the `-e` flag removed from the workflow turn part 6 red. Full suite green, 16 files, in the CI image on a read-only mount - the shape the runner uses. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
119 lines
4.1 KiB
Python
119 lines
4.1 KiB
Python
"""Runnable check for the maintenance state machine. `python3 test_maintenance.py`
|
|
|
|
Walks a whole cycle in simulated time, which is the test the YAML version never
|
|
had - and it is exactly the phase transitions that a real cycle takes ten hours
|
|
to exercise once a month.
|
|
|
|
⚠️ MUTATING THE MODULE THIS FILE GRADES? PURGE `__pycache__` FIRST - or run
|
|
`tools/mutation_run.sh`, which does. `python3 -B` alone does NOT save you: it
|
|
stops bytecode being WRITTEN, not a stale one being READ, and a size-preserving
|
|
edit reverted inside one second is invisible to CPython's staleness test. That
|
|
is TEST-15, and it has already turned one live mutation into a false survivor.
|
|
Read MUTATION.md before you report a survivor.
|
|
"""
|
|
|
|
import sys
|
|
from datetime import datetime, timedelta, timezone
|
|
|
|
from app.maintenance import CHARGE, DRAIN, HOLD, IDLE, MaintConfig, Maintenance
|
|
|
|
fails = []
|
|
|
|
|
|
def check(name, cond):
|
|
print(f" {'ok ' if cond else 'FAIL'} {name}")
|
|
if not cond:
|
|
fails.append(name)
|
|
|
|
|
|
class FakeStore:
|
|
"""Same surface as Store, no disk."""
|
|
|
|
def __init__(self):
|
|
self.data = {"phase": IDLE, "phase_started": None,
|
|
"last_completed": None, "last_start_attempt": None}
|
|
|
|
def set(self, k, v):
|
|
self.data[k] = v
|
|
|
|
def set_time(self, k, when):
|
|
self.data[k] = when
|
|
|
|
def get_time(self, k):
|
|
return self.data.get(k)
|
|
|
|
def save(self):
|
|
pass
|
|
|
|
|
|
cfg = MaintConfig(enabled=True, interval_days=28, start_hour=10,
|
|
discharge_w=2500, charge_w=2500,
|
|
soc_floor=11, soc_target=99, hold_min=120)
|
|
|
|
t0 = datetime(2026, 8, 23, 10, 0, tzinfo=timezone.utc)
|
|
|
|
print("scheduling")
|
|
m = Maintenance(cfg, FakeStore())
|
|
check("never run before is due", m.due(t0))
|
|
r = m.tick(t0, soc=80)
|
|
check("starts at the start hour when due", r.phase == DRAIN and r.owns_setpoint)
|
|
check("drain commands the discharge rate", r.setpoint_w == 2500)
|
|
|
|
m2 = Maintenance(cfg, FakeStore())
|
|
r = m2.tick(t0.replace(hour=11), soc=80)
|
|
check("does not start outside the start hour", r.phase == IDLE)
|
|
|
|
m3 = Maintenance(cfg, FakeStore())
|
|
m3.store.set_time("last_completed", t0 - timedelta(days=3))
|
|
check("not due three days after a cycle", not m3.due(t0))
|
|
check("due 29 days after a cycle",
|
|
Maintenance(cfg, FakeStore()).due(t0) and
|
|
(t0 - (t0 - timedelta(days=29))) >= timedelta(days=28))
|
|
|
|
print("ownership per phase")
|
|
m = Maintenance(cfg, FakeStore())
|
|
m.force_start(t0)
|
|
r = m.tick(t0, soc=80)
|
|
check("drain: maintenance owns the setpoint", r.owns_setpoint and not r.charge_only)
|
|
r = m.tick(t0 + timedelta(hours=3), soc=10.5)
|
|
check("drain exits at the floor", r.phase == CHARGE)
|
|
check("charge: the LOOP owns the setpoint", not r.owns_setpoint and r.charge_only)
|
|
r = m.tick(t0 + timedelta(hours=20), soc=99)
|
|
check("charge exits at the target", r.phase == HOLD)
|
|
check("hold: maintenance owns and commands zero",
|
|
r.owns_setpoint and r.setpoint_w == 0.0)
|
|
r = m.tick(t0 + timedelta(hours=21), soc=100)
|
|
check("hold keeps holding before hold_min", r.phase == HOLD)
|
|
r = m.tick(t0 + timedelta(hours=22, minutes=5), soc=100)
|
|
check("hold completes after hold_min", r.phase == IDLE)
|
|
check("completion is recorded", m.store.get_time("last_completed") is not None)
|
|
check("no longer due right after completing", not m.due(t0 + timedelta(hours=22)))
|
|
|
|
print("failure handling")
|
|
m = Maintenance(cfg, FakeStore())
|
|
m.force_start(t0)
|
|
r = m.tick(t0 + timedelta(hours=13), soc=60)
|
|
check("drain aborts on timeout", r.phase == IDLE)
|
|
check("abort commands zero", r.setpoint_w == 0.0)
|
|
|
|
m = Maintenance(cfg, FakeStore())
|
|
m.force_start(t0)
|
|
r = m.tick(t0 + timedelta(minutes=5), soc=None)
|
|
check("no SoC: holds the phase rather than guessing", r.phase == DRAIN)
|
|
check("no SoC: still commands the drain rate", r.setpoint_w == 2500)
|
|
|
|
m = Maintenance(cfg, FakeStore())
|
|
m.store.set("phase", "banana")
|
|
r = m.tick(t0, soc=50)
|
|
check("unknown phase recovers to idle at 0 W", r.phase == IDLE and r.setpoint_w == 0.0)
|
|
|
|
print("disabled schedule")
|
|
m = Maintenance(MaintConfig(enabled=False), FakeStore())
|
|
check("disabled never starts", m.tick(t0, soc=80).phase == IDLE)
|
|
|
|
print()
|
|
if fails:
|
|
print(f"{len(fails)} FAILED: {', '.join(fails)}")
|
|
sys.exit(1)
|
|
print("all checks passed")
|