"""PKG-09 - refuse a deploy that would be a no-op, or that the add-on would reject. python3 tools/predeploy_check.py --deployed-version 0.7.0 --options live-options.json ⚠️ RUN IT WHERE THE ADD-ON'S DEPENDENCIES EXIST. `app/validate.py` imports its siblings and those need aiohttp, so on a bare host the validator half SKIPS - loudly, and exit 2, never a silent pass. To get both halves: docker run --rm -v :/w:ro goodwe-addon-checks:1 \ python3 /w/goodwe_controller/tools/predeploy_check.py \ --deployed-version 0.7.0 --options /w/live-options.json EXIT CODES. 0 cleared; 1 REFUSED, do not deploy; 2 NOT CLEARED - a check did not run, and that is not the same as passing. TWO FAILURES THIS ANSWERS, BOTH OF WHICH HAVE HAPPENED. 1. THE SILENT NO-OP. The Supervisor keys the built image by `version:` in config.yaml. `ha apps update` against an unchanged version does nothing and REPORTS SUCCESS. PKG-06 recorded this on 2026-09-05 with four merges behind an unbumped version; PKG-07 recorded it again on 2026-09-06 with six. Both times a human noticed. Nothing else was ever going to. 2. THE REFUSED CONFIG. A config the shipped validator rejects is `SystemExit(78)` - the add-on does not start. ⚠️ AND THE INGRESS PANEL GOES WITH IT, because the add-on serving it is not running, so recovery means the Supervisor UI. SAFETY-39's rule 10 made this reachable by a config that started fine on the previous version: it refuses an explicit `slew_w` above SLEW_RAIL_FRAC x the site rail, and 0.7.0's own shipped default of 1000 exceeds the 555.6 W ceiling on a 5000 W rail. ⚠️ WHY THIS IS NOT A CI CHECK. The obvious version gate - "a pull request that touches runtime code must bump the version" - is the WRONG shape for this project, which deliberately batches many merges into one deploy. It would demand a bump per pull request, put every branch in conflict over one line of config.yaml, and still not prevent the actual failure, which happens at DEPLOY and not at merge. The check belongs where the mistake is made. ⚠️ WHAT THIS DOES NOT DO. It does not read the live box. The options blob is reachable only through the Supervisor API, which needs a supervisor token, so the operator exports it and passes `--options`. Without that flag the validator half is SKIPPED and says so - a skipped check must never look like a passed one. """ import argparse import json import os import re import subprocess import sys HERE = os.path.dirname(os.path.abspath(__file__)) ADDON = os.path.dirname(HERE) sys.path.insert(0, ADDON) # Files that end up in the built image and can change what it DOES. A change to # any of these needs a new `version:` or the Supervisor will not rebuild. # CHANGELOG.md, DOCS.md, MUTATION.md, DECISIONS/, test_*.py, tools/ and # scenarios/ are deliberately absent: they ship in the repo but cannot change # runtime behaviour, and demanding a bump for a typo fix trains people to bump # without reading, which is the habit this file exists to prevent. RUNTIME = ( "goodwe_controller/app/", "goodwe_controller/translations/", "goodwe_controller/config.yaml", "goodwe_controller/Dockerfile", "goodwe_controller/run.sh", "goodwe_controller/requirements.txt", "goodwe_controller/build.yaml", ) _VER = re.compile(r'^version:\s*"([^"]+)"', re.M) def shipped_version(tree=ADDON): with open(os.path.join(tree, "config.yaml"), encoding="utf-8") as fh: m = _VER.search(fh.read()) return m.group(1) if m else None def is_runtime(path): return any(path == p or path.startswith(p) for p in RUNTIME) def _git(*args, repo=None): return subprocess.run(["git", "-C", repo or os.path.dirname(ADDON), *args], capture_output=True, text=True) def runtime_commits_since_version_change(repo=None): """Commits touching RUNTIME since `version:` last changed. ([], None) if unknown. Returns (commits, last_bump_sha). An empty list with a sha means the tree is clean; an empty list with None means git could not answer and the caller must NOT read that as a pass. """ r = _git("log", "-1", "--format=%H", "-S", 'version: "', "--", "goodwe_controller/config.yaml", repo=repo) if r.returncode != 0 or not r.stdout.strip(): return [], None last = r.stdout.strip() r = _git("log", "--format=%H %s", f"{last}..HEAD", repo=repo) if r.returncode != 0: return [], None out = [] for line in r.stdout.splitlines(): sha, _, subject = line.partition(" ") f = _git("show", "--name-only", "--format=", sha, repo=repo) if any(is_runtime(p) for p in f.stdout.split()): out.append((sha[:10], subject)) return out, last[:10] def main(): ap = argparse.ArgumentParser() ap.add_argument("--deployed-version", required=True, help="the version currently running ON THE BOX") ap.add_argument("--options", help="path to the live options blob, exported " "from the Supervisor. Omitted = that half is SKIPPED.") ap.add_argument("--tree", default=ADDON) ap.add_argument("--repo", default=None) a = ap.parse_args() problems, skipped = [], [] shipped = shipped_version(a.tree) print(f" deployed on the box : {a.deployed_version}") print(f" shipped in this tree: {shipped}") commits, last = runtime_commits_since_version_change(a.repo) if shipped is None: problems.append("could not read `version:` out of config.yaml") elif shipped == a.deployed_version: if last is None: skipped.append("could not ask git what changed since the last bump; " "the no-op check is INCONCLUSIVE, not clean") if commits: problems.append( f"THE DEPLOY WOULD BE A NO-OP. Version is {shipped} on both sides, and " f"{len(commits)} commit(s) touching runtime files have landed since the " f"version last changed ({last}). `ha apps update` will report success " f"and install NOTHING. Bump `version:` first.") for sha, subj in commits[:12]: print(f" {sha} {subj[:76]}") elif last is not None: print(" no runtime change since the last bump - nothing to deploy") if a.options: with open(a.options, encoding="utf-8") as fh: opts = json.load(fh) try: from app.validate import validate_startup_config except Exception as exc: # pragma: no cover skipped.append( f"could not import the shipped validator ({exc}); the config check " f"did NOT run. `app/validate.py` imports its siblings, and those need " f"the add-on's runtime dependencies - so THIS SCRIPT ONLY CHECKS A " f"CONFIG WHERE THOSE DEPENDENCIES EXIST: inside the add-on container, " f"or in the CI image. Re-run it as:\n" f" docker run --rm -v :/w:ro goodwe-addon-checks:1 \\\n" f" python3 /w/goodwe_controller/tools/predeploy_check.py \\\n" f" --deployed-version --options /w/") else: found = validate_startup_config(opts) if found: problems.append( f"THE LIVE CONFIG IS REFUSED BY THIS VERSION'S VALIDATOR " f"({len(found)} problem(s)). Deploying it is SystemExit(78): the " f"add-on does not start, and the ingress panel goes with it because " f"the add-on serving it is not running. Recovery is the Supervisor UI.") for p in found: print(f" - {p}") else: print(" live options pass this version's validator") else: skipped.append("--options was not given, so the live config was NEVER CHECKED " "against this version's validator. A config refused at startup is " "exit 78. Export the options and re-run before deploying.") print() for s in skipped: print(f" ⚠️ SKIPPED: {s}") if problems: for p in problems: print(f" ❌ {p}") print("\n REFUSED - do not deploy.") return 1 if skipped: print(" NOT CLEARED - checks above did not run. Deploying now is a decision " "made without them.") return 2 print(" CLEARED for deploy.") return 0 if __name__ == "__main__": sys.exit(main())