From 06661c5e1761ad828b8aefe1e800aafb309944d4 Mon Sep 17 00:00:00 2001 From: glenn schrooyen Date: Sun, 6 Sep 2026 20:03:06 +0200 Subject: [PATCH] PKG-07: bump 0.7.0 -> 0.8.0, because 0.7.0's own default is now a refused config MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Six merges landed behind an unbumped 0.7.0 - CI-06, SAFETY-38, SAFETY-39, SAFETY-37, SAFETY-13, SAFETY-42. PKG-06 recorded this exact failure YESTERDAY (bbc903b, 2026-09-05 19:23): the Supervisor keys the built image by `version:`, so `ha apps update` against an unchanged version is a silent no-op and the box keeps running the old tree. Catching it by hand a second time is the argument for the automated check PKG-06's follow-up still owes. MINOR rather than patch, and the reason is sharper than a semantic change: SAFETY-39's validator rule 10 refuses an explicit `slew_w` above SLEW_RAIL_FRAC x the site rail - 555.6 W on a 5000 W rail - and 0.7.0's own SHIPPED DEFAULT was `slew_w: 1000` under schema `int(50,5000)`. An install that never touched the key is refused on 0.8.0. Refusal is SystemExit(78); the add-on does not start. ⚠️ AN EARLIER DRAFT OF THIS COMMIT JUSTIFIED THE BUMP BY CLAIMING `slew_w: 0` USED TO MEAN "no limit" AND NOW MEANS "follow the rail". THAT WAS FALSE AND IS REMOVED. The schema was `int(50,5000)` from the repo's first commit through 0.7.0, so 0 was never a legal value and never meant anything; and the old `control.py` had no zero case - at slew_w=0 it pinned the command to its previous value, freezing it, which is the opposite of "no limit". The widening to `int(0,5000)` is a NEW capability, not a changed meaning. The bump is right; the story told for it was invented - PROC-01's defect appearing in the very commit that complains about process. ⚠️ AND THEN A SECOND ONE, IN THE SAME COMMIT: the text said PKG-06 was "three days ago" when the two commits are about a day apart (2026-09-05 19:23 -> 2026-09-06 20:03). Caught in round 2 and corrected. Two invented facts in one documentation-only change is the measurement PROC-01 wants, not an anecdote: both were plausible, neither was load-bearing, and both would have shipped. ⚠️ THE PRE-DEPLOY CHECK THIS IMPLIES IS NOT DONE AND CANNOT BE DONE FROM HERE. Whether the LIVE options survive rule 10 depends on the live `slew_w`, and the options blob is only reachable through the Supervisor API, which needs a token this session does not have; the HA REST API does not expose it and no entity carries it. On record `slew_w` was set to 400 during the SAFETY-39 interim fix, and 400 is below 555.6 - but that is a written record, not a reading, and the value has been hand-edited since. Read the options and check them BEFORE `ha apps update`. Exit 78 also takes the ingress panel down, because the add-on serving it is not running. The contents table now carries each merge subject's WHOLE claim. Two rows had been trimmed to their flattering halves - SAFETY-39's "`gain` is the constant that is still wrong" and SAFETY-42's "the discriminator the card asked for does not exist" - and both are restored. Separately, `## Unreleased` was a lie twice over: two headings by that name, one spanning ~3000 lines across three releases, one from the 0.4.x era, and every word under both is shipped and running. Retitled, not re-sorted; the split is PKG-08. Reviewed twice. Round 1 REJECTED for an empty PR - built in a clone a concurrent agent was using, and "pushed" reported from the command's echo rather than from the remote ref - and for the fabricated slew_w story. Round 2 APPROVED with the date as a non-blocking finding, fixed here. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01BwRLw7eKYj2byVdwB6kbjU --- goodwe_controller/CHANGELOG.md | 68 +++++++++++++++++++++++++++++++++- goodwe_controller/config.yaml | 2 +- 2 files changed, 67 insertions(+), 3 deletions(-) diff --git a/goodwe_controller/CHANGELOG.md b/goodwe_controller/CHANGELOG.md index 304cd96..4cebec5 100644 --- a/goodwe_controller/CHANGELOG.md +++ b/goodwe_controller/CHANGELOG.md @@ -1,5 +1,52 @@ # Changelog +## 0.8.0 + +⚠️ **A CONFIG THAT STARTED ON 0.7.0 CAN BE REFUSED ON 0.8.0, AND THAT IS WHY +THIS IS A MINOR BUMP.** [[SAFETY-39]] adds validator rule 10, which refuses an +explicit `slew_w` above `SLEW_RAIL_FRAC` x the site rail, where `SLEW_RAIL_FRAC` +is `LOOP_TICK_S / PLANT_SETTLE_S` = 2/18. On a 5000 W rail that ceiling is +**555.6 W**. + +⚠️ **THE VALUE THAT BREAKS IS 0.7.0'S OWN SHIPPED DEFAULT.** `slew_w` defaulted +to **1000** and the schema was `int(50,5000)`; 1000 > 555.6, so an install that +never touched the key and simply took the default is refused on 0.8.0 until the +value is lowered. That is as backward-incompatible as it gets, and it is the +whole justification for MINOR over PATCH. + +The schema also widens from `int(50,5000)` to `int(0,5000)`, and `slew_w: 0` - +**a value that was not legal before** - now means *follow the rail* and is the +shipped default. This is a new capability rather than a changed meaning. + +⚠️ Refusal is `SystemExit(78)` (`EX_CONFIG`): the add-on does not start. **Read +the live options and check them against the ceiling BEFORE `ha apps update`.** +That check is NOT performed by this PR and cannot be - see the PR body. + +CFG-04's rule and PKG-06's: the Supervisor keys the built image by `version:`, +so shipping a change without a bump means `ha apps update` is a silent no-op. +**Six merges accumulated behind an unbumped 0.7.0 before this was caught, for +the second time in two days.** The automated check that would catch it without +a human noticing is still unwritten, and that is PKG-06's standing follow-up. + +Contents, in merge order since 0.7.0 (`bbc903b`). ⚠️ Each row carries the merge +subject's **whole** claim, including the half that is not flattering: + +| | | +|---|---| +| `9e42cec` | CI-06 - `test_peakguard.py` answered two of its checks with the wall clock | +| `24c3d87` | SAFETY-38 - pin `site_standing` with shares that cannot answer for the site | +| `a4290d3` | SAFETY-39 - `slew_w` is a ratio to the rail, **and `gain` is the constant that is still wrong** | +| `c8dcb38` | SAFETY-37 - a stale reading is `None`, and arrival cannot be what says so | +| `0581648` | SAFETY-13 - the output freeze gets an exit, and only where it needs one | +| `464d398` | SAFETY-42 - a unit that stops delivering, **and the discriminator the card asked for does not exist** | + +⚠️ **TWO DISCLOSED RESIDUALS SHIP IN THIS RELEASE.** SAFETY-13's bounded +freeze-exit shows 0 spurious releases on the sweep's measured-plant slice but +**2 of 272 on a finer grid**, and the docs carry the 2-of-272 figure rather than +the flattering one. SAFETY-42's card proposed a discriminator that **turned out +not to exist**, and the branch says so rather than shipping a weaker check under +the original name. + ## 0.7.0 ⚠️ **SCHEMA CHANGE, AND IT IS WHY THIS IS A MINOR BUMP RATHER THAN A PATCH.** @@ -29,7 +76,19 @@ is a defect in this file, not in the release: the deployed 0.6.0 is `2d025ee` an the table above is what is new since it. Splitting it retroactively would mean guessing a boundary; saying so is more useful than a guess. -## Unreleased +## Detail notes — accumulated, NOT a separate release + +⚠️ **THIS HEADING USED TO SAY "Unreleased" AND IT WAS WRONG.** Everything below +has SHIPPED. The section accumulated across 0.6.0, 0.7.0 and 0.8.0 because each +release was cut without clearing it, so it names tickets from all three +([[SAFETY-18]] and [[SAFETY-30]] from the 0.6.0 era through [[SAFETY-42]] in +0.8.0). A reader who trusted the old heading would have concluded that shipped, +running behaviour was still pending — and there was a SECOND heading saying the +same thing further down, from the 0.4.x era. + +Retitled rather than re-sorted, on purpose: splitting ~3000 lines by release is +real work that does not belong inside a version bump, where it would bury the +one line that changes what the Supervisor installs. Card PKG-08 carries it. ⚠️ **THE OUTPUT FREEZE NOW HAS AN EXIT, AND ONLY WHERE IT CANNOT END ON ITS OWN ([[SAFETY-13]]).** While the loop is frozen the command's magnitude may fall but @@ -3381,7 +3440,12 @@ human to read rather than alarmed on - at a converged -10 W a 1 Wh register need about six minutes to move, so any threshold would false-trip at the target operating point. -## Unreleased +## Detail notes from the 0.4.x era — NOT unreleased + +⚠️ Retitled with the same correction as the section above: [[TEL-05]] and the +entries under this heading shipped long ago. Two headings in one file both +claiming "Unreleased" is how a reader ends up believing running behaviour is +still pending. **TEL-05.** A fourth `meter_source`, `homewizard_local`, which polls a HomeWizard P1's **own local API** (`GET /api/v1/data`) instead of watching a diff --git a/goodwe_controller/config.yaml b/goodwe_controller/config.yaml index f2b9333..ec8568a 100644 --- a/goodwe_controller/config.yaml +++ b/goodwe_controller/config.yaml @@ -1,5 +1,5 @@ name: GoodWe RS485 Controller -version: "0.7.0" +version: "0.8.0" slug: goodwe_controller description: >- Drives a GoodWe ES/BP battery inverter over RS485 by emulating its smart -- 2.54.0