EV-14: Car Why says what happens in shadow mode and after an abandoned phase change #270

Merged
ems-agent merged 3 commits from EV-14 into release/1.0 2026-11-22 15:52:31 +01:00
Collaborator

EV-14: the Car Why says what happens, not only what the user set.

Display only (homeview._car_manual_why, ui_text en/nl):

  • Shadow mode with the car over the limit: "Shadow mode: the add-on would set {a} A, {phases}. This charge would set the peak."
  • A phase change that did not happen (read phases differ from the setting, no sequence running): "You set {a} A, {phases}. The charger stays on {real}."
  • The writer holds for another writer: "Something else set the charger. The add-on leaves it until you change something."
  • Phases equal or unknown, no hold: unchanged.

Tests: goodwe_controller/test_ev14.py (T1-T35, N2, N3). No control, write, constant, alarm or notification changed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VSY9UpTaUYnjJF5oVtbM1w

EV-14: the Car Why says what happens, not only what the user set. Display only (homeview._car_manual_why, ui_text en/nl): - Shadow mode with the car over the limit: "Shadow mode: the add-on would set {a} A, {phases}. This charge would set the peak." - A phase change that did not happen (read phases differ from the setting, no sequence running): "You set {a} A, {phases}. The charger stays on {real}." - The writer holds for another writer: "Something else set the charger. The add-on leaves it until you change something." - Phases equal or unknown, no hold: unchanged. Tests: goodwe_controller/test_ev14.py (T1-T35, N2, N3). No control, write, constant, alarm or notification changed. 🤖 Generated with [Claude Code](https://claude.ai/code) https://claude.ai/code/session_01VSY9UpTaUYnjJF5oVtbM1w
ems-agent added 2 commits 2026-11-22 14:00:22 +01:00
Display only: shadow mode over-limit Why speaks in would-terms; read phases that
differ from the setting say the charger stays; a writer hold says something
else set the charger. EN and NL texts, test_ev14.py.

Co-Authored-By: Claude <noreply@anthropic.com>
EV-14: T33 reads the raw nl words; T29 carries a would
checks / unit (pull_request) Successful in 34m43s
infra-pin / fresh (pull_request) Successful in 1s
b66ce68d4d
ems-agent added 1 commit 2026-11-22 15:25:35 +01:00
EV-14 review: T1 phases check (shadow-over phases come from would)
checks / unit (pull_request) Successful in 26m36s
infra-pin / fresh (pull_request) Successful in 1s
9987a32424
Kills the surviving mutant 'shadow-over phases from car_n'.

Co-Authored-By: Claude <noreply@anthropic.com>
ems-agent merged commit 885528ab48 into release/1.0 2026-11-22 15:52:31 +01:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/goodwe-addon#270