EV-28: no phase select while the car still draws #268

Merged
ems-agent merged 2 commits from EV-28 into release/1.0 2026-11-21 23:28:04 +01:00
Collaborator

EV-28: the phase select is written only when the charger reads under 100 W (mode3 only without a power reading). A car still drawing after 20 s gets no select: its current comes back at once, one failed try, next try 10 minutes later.

Tests: test_ev28.py (new), test_ev04.py (slow_stop rewritten, fuzz power check). Brief v2, R3.

Generated with Claude Code

EV-28: the phase select is written only when the charger reads under 100 W (mode3 only without a power reading). A car still drawing after 20 s gets no select: its current comes back at once, one failed try, next try 10 minutes later. Tests: test_ev28.py (new), test_ev04.py (slow_stop rewritten, fuzz power check). Brief v2, R3. Generated with Claude Code
ems-agent added 1 commit 2026-11-21 21:04:18 +01:00
EV-28: never select the phases while the car still draws
checks / unit (pull_request) Successful in 32m4s
infra-pin / fresh (pull_request) Successful in 1s
83f114fe08
Stage zero counted mode3 B as quiet whatever the power and selected at the
20 s timeout under load. A power reading now decides (under 100 W); mode3
(not C, not D) only without one. Still drawing at 20 s: no select, the
current comes back at once, one failed try, next try PHASE_GAP_S later.

Co-Authored-By: Claude <noreply@anthropic.com>
ems-agent added 1 commit 2026-11-21 22:58:59 +01:00
EV-28 review: pin the restore step in T17a and the counted failure in T15
checks / unit (pull_request) Successful in 28m34s
infra-pin / fresh (pull_request) Successful in 1s
4b4a4c1053
Review fixes, no logic change:
- T17a now asserts the restore is the first write once the charger is back
  (it was only checked to happen at some point); mutant M3 (restore after
  SETTLE_S) now turns T17a red.
- T15 now asserts the refused restore is counted once (`fails == 1`);
  a mutant without `_failed` there now turns T15 red.
- DECISIONS "The phase sequence" and the carmode docstring reflowed to 79
  columns; DECISIONS says D counts as drawing too, as the code does.

Co-Authored-By: Claude <noreply@anthropic.com>
ems-agent merged commit 76f4de23c7 into release/1.0 2026-11-21 23:28:04 +01:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/goodwe-addon#268