6 Commits

Include renames

Author	SHA1	Message	Date
adminandClaude Opus 5.5	6a95447248	UX-08 2d: plain log lines, the rest of the status page, and DOCS ... Every WARNING and ERROR line is one plain line of at most 25 words, with no card ids, capitals or semicolons; the reasoning of the ten longest is on a DEBUG line. The ux08 allowlist is empty and its cap is 0 (43 -> 0). The status page: the month-peak and peak-guard rows, the stale-reading row, the top table (Why, Tariff, Arbitrage, Shadow mode, labels), the Stopped banner and the line under the buttons, which now shows the plain hint of each event instead of the raw action log. The Supervisor question at start logs one line with a real reason. Refusals are counted as shown (labels expanded, long cases driven), seven were shortened, the card and parse errors lost their internals, a blank value reads "empty", and the panel no longer files inverters.max_w under the flat max_w. Option names lose "(JSON)", the NL texts are checked too. DOCS gets a glossary (control board, isolator, Developer Tools) and card ids move from headings to a "For installers" line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LyR88rXETvwhTgx6yHE39p	2026-09-27 08:01:16 +02:00
goodwe-review	c84d5fd14f	UX-08 2c review: unit settings anchor to inverters, plainer texts ... - messages.setting() for one inverter in the list reads “Inverter rating” for inverter-b (inverters.max_w), so the config panel files per-unit reasons under `inverters`, where the value is changed. - The tariff card and plausibility reasons name “Distribution, levies and VAT” (price_taxes_eur_kwh) again. - The wrong-direction reasons say "safety stop", the sign_disagree_w option says what it protects, and the roster, price-entity, integrator_max_w and capacity_kwh texts read more plainly. - NL: stuurprint -> stuurmodule, "De piekbeperking". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-27 06:51:57 +02:00
glenn schrooyenandClaude Opus 5.5	2c516a032c	UX-08 2c: short refusals, error texts and option texts ... Validator refusals name the setting by its label and key, say what is wrong and what to change, and keep the rejected value and limit. Option names and descriptions are short in en and nl; citations moved to DOCS "For installers" and the test_translations citation check now pins the instruction on the tab and the record in DOCS. No rule, key, schema, default or exit code changed. Allowlist 167 -> 43 (log lines only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LyR88rXETvwhTgx6yHE39p	2026-09-27 05:55:45 +02:00
glenn schrooyenandClaude Opus 5	995da777ce	TARIFF-16: the injection leg stops being one number ... `price.py` modelled what a site is PAID for export as ONE scalar. The market publishes a line, and the cards say so in their own words: Eneco Zon & Wind Dynamisch `0,1 x BELPEX-H - 1,188` c EUR/kWh - "het injectietarief is dynamisch en kan per uur wijzigen", identical on the January and the September 2026 cards; ENGIE Dynamic `(B x eSpot_15) - A`; Aspiravi `0,07 x Belpex - 2`. `price_export_formula` carries that line with its OWN coefficients. ⚠️ THIS IS NOT A WRONG-TRADE FIX, AND SAYING SO IS PART OF SHIPPING IT. `arbitrage.py` does not read `export_price_eur_kwh` at all - its own comment says so, citing §9.3's near-zero Belgian injection price as the reason the economically sound trade on this market is charge-cheap-to-displace-expensive- IMPORT. Both hours it compares are all-in CONSUMPTION prices. No trade this add-on takes today is decided by an injection price and nothing here changes one. What it changes is what an operator is told, and what a future export-aware strategy rests on: OPT-06 and any export logic would otherwise inherit a scalar that cannot represent the market, and the 6% VAT asymmetry would be invisible in the arithmetic. test_price.py 17h parses every module under app/ and goes red the day something calls an injection reader, so that sentence is graded rather than attested. FOUR PROPERTIES A SCALAR CANNOT HOLD. Its own factor (Eneco 0,102 consumption against 0,100 injection; Aspiravi 0,07 against ~0,10 - not the consumption B with a sign flip). A negative offset, which `price_markup_eur_kwh: float(0,1)` cannot express at all. VAT-exemption - "injectietarieven zijn vrijgesteld van btw" - against 6% on consumption, representable only because `vat_pct` is PER SPEC. And a price that goes below zero with no floor, under 11,88 EUR/MWh of BELPEX-H, which is the middle of a sunny day. ⚠️ A NEGATIVE INJECTION PRICE IS ACCEPTED, AND THAT NEEDED A DIFFERENT BAND RATHER THAN A LOWER FLOOR. `implausible_all_in()` floors the consumption leg at +0.02 EUR/kWh of energy; applied to injection that refuses the real market in the hours it matters most. Measured rather than argued: 17c puts ONE spec through BOTH bands and prints that the consumption band refuses -0.03008 EUR/kWh while the injection band accepts it. The floor was not decoration - it is what catches a card read a hundred times too small, the one unit error the card self-check cannot see because it cancels out of a comparison between the two sides - so the bound moves OFF the price and ONTO the coefficients, where it is index-free and sign-free: a pass-through band (Eneco's injection leg is 1.00x, Aspiravi's 0.70x; the band is 0.10-10x) and an offset magnitude bound (0.20 EUR/kWh against published 0.01188 and 0.02). Two rungs that can both answer a hundredfold error, so each is graded on its REASON, each gets a stimulus the other cannot reach with the precondition asserted as its own check, and they are mutated TOGETHER (TEST-16). ⚠️ THE CARD SELF-CHECK APPLIES WHERE THERE IS A CARD, AND WHERE THERE IS NOT THAT IS STATED RATHER THAN WORKED AROUND. `price_formula` can require a `card` block because a Belgian card prints the consumption formula, the reference index AND the resulting price. Eneco's INJECTION formula is printed with no price beside it. Requiring a block would make the published line inexpressible; inventing the estimate would grade the coefficients against arithmetic done with the same coefficients. So the block is OPTIONAL on this leg and unchanged on the other, the self-check runs at the same tolerance wherever a printed estimate exists, and validate.py says at startup - "its coefficients are UNGRADED" - when it does not, naming the two bounds that ran instead. This is TARIFF-15 demonstrating two tariffs end to end rather than three, one card later. 17e also MEASURES the size of that gap: a factor of 0.070 where the contract says 0.100 - 30% of every export payment - passes both bounds, because 0.70x is a pass-through somebody really publishes. ONE PARSER, NOT TWO. `parse_export_formula()` is `parse_price_formula()` with its OPTION NAME as an argument - TARIFF-17's move on `parse_static_profile()`, exactly - and everything that differs between the legs is a string in one `_LEGS` table. A second copy would be a second unit table, a second NaN rule, a second unknown-key rule and a second `to_resolution()`, diverging first on the 23- and 25-hour days. test_price.py 17b pins it two ways: all 32 grammar names are defined in exactly ONE module under app/, with the scope COMPUTED by parsing every file rather than listed; and twelve refusal sentences for the new option are DERIVED from the old option's own sentence rather than transcribed. The four sentences that deliberately differ are named, with what differs, and asserted to differ. NOTHING CHANGES FOR A SITE THAT DOES NOT SET IT. The option ships ""; `export_price_eur_kwh()`'s body is byte-identical, pinned on the AST rather than on the source text; `export_price_at()` falls through to it for every index value. 17f compares seven option dicts x five index values against the pre-TARIFF-16 expression with `==`. `price_export_formula` joins FRAMEWORK_KEYS, BANNED_IN_PLUGIN_CODE is derived from that set, and `code_leaks()` refuses a plugin that names it with nothing else edited. ALSO CORRECTED HERE: config.yaml's comment beside `export_price_eur_kwh` still read "no shipped supplier publishes a dynamic injection curve". TARIFF-07 struck that claim from app/price.py and DOCS.md and did not reach config.yaml, where it has been shipping since. 20 mutations, every one red on a named check, ledger in test_price.py below section 17 - including a ZERO-byte one (the two legs transposed in the VAT-asymmetry banner: no decision moves, only the sentence) and a ONE-byte one (`card_required=True` on the injection leg). Three run over all 29 files and red on test_price.py alone. 29/29 green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BwRLw7eKYj2byVdwB6kbjU	2026-09-13 18:41:06 +02:00
glenn schrooyenandClaude Opus 5	9c65ac2cf8	TARIFF-18: price_taxes_eur_kwh stops shipping at half the real figure ... `price_taxes_eur_kwh` shipped at 0.06 EUR/kWh with no recorded provenance - no card, no date, no component list - and roughly HALF the true Flemish all-in non-energy figure. It now ships at 0.11736, and the rows it is made of are in the code rather than in this message: Fluvius distribution (Antwerpen) 5,35 c EUR/kWh Bijzondere accijns, "Alle verbruik" 4,876 Bijdrage groene stroom en WKK Vlaanderen 1,51 Energiebijdrage (0 EUR/MWh since 2026-08-01) 0 ------ 11,736 c EUR/kWh = 0.11736 Eneco residential card for Flanders, September 2026, incl. 6 % VAT. `app/price.py`'s FLEMISH_TAXES_COMPONENTS_EUR_KWH carries the rows and test_price.py section 1b re-adds them - and also compares the total against the card's own figures typed in the test file, so an edit that moved the rows and the default together is still caught. WHAT THIS IS NOT. It is not an arbitrage-correctness fix and it cannot be. This scalar is a LEVEL component: an additive constant cancels exactly in `max - min` and leaves the argmin where it was. TARIFF-17 shipped that proof and it is unchanged - test_price.py 16b drives six flat scalars spanning and exceeding the whole per-DSO range and gets the identical cheapest hour and the identical spread to the last digit. DOCS and the CHANGELOG say so in those words. WHAT IT IS. A display and guard fix: * every number an operator reads, which at half the true value made the add-on look considerably better than it is; and * §17's negative-price guard in arbitrage.py - the one rung that tests an ABSOLUTE all-in price rather than a difference. It fires when `spot < -(markup + taxes)`, so its boundary moves -0.09 -> -0.14736 EUR/kWh of spot. test_arbitrage.py section 2c drives both sides through the shipped decide() and pins the boundary from below as well. The default is Antwerpen's real row, near the LOW end of the 0.117-0.131 per-DSO band, and that is deliberate: the error directions are not symmetric. Too high carries a genuinely negative hour above zero and the add-on exports into paid-for disposal - §17's own case. Too low only declines a discharge that would have paid. TARIFF-17's INTERACTION, WHICH HAD TO BE DECIDED. Nothing in that rung hardcoded 0.06; it read PRICE_OPTION_DEFAULTS, so moving the default moves what it refuses. The Supervisor sets `App.options = deepmerge(config.yaml defaults, stored options)`, so a saved blob carries the key whether it was typed or not - every stored 0.06 became "non-default" with nobody editing anything, and a working Walloon or Brussels site with a taxes table would have met SystemExit(78) on the upgrade over an inert number. price.py now carries SUPERSEDED_TAXES_DEFAULTS_EUR_KWH = (0.06,) and validate.py reads a superseded default as untouched too. The rung is NOT weakened: 0.1198 beside a table is still refused by name, and the refusal now names both figures. config.yaml and PRICE_OPTION_DEFAULTS moved together; CFG-03's tripwire (test_price.py section 1, test_defaults_pin.py) stayed green by agreeing. test_price.py section 0's fourth check was REWRITTEN rather than re-pointed: it used to justify the file's own grading constants by observing that the shipped pair was degenerate (0.06 is exactly twice 0.03). TARIFF-18 ends that coincidence, so the sentence is no longer true and is not kept. 29/29 test files green. Mutation ledger on the PR. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BwRLw7eKYj2byVdwB6kbjU	2026-09-13 16:24:56 +02:00
Claude Opus 5	ac9854886b	TARIFF-15: your own tariff card, as two coefficients the card itself grades ... A Belgian dynamic contract prices energy as `B x index + A`, and the two coefficients exist on exactly one artefact: the customer's own tariff card. There is no machine-readable source for them anywhere - CREG's consumer tariff-card pages 404, CREG Scan is a JS wizard, the annual report has the supplier list without per-product coefficients, VREG was unreachable, and every coefficient found in research came off a supplier's own PDF, one image-only. So nothing can be scraped and a per-supplier plugin would have no source for its numbers, which is why TARIFF-07 withdrew three of them. The customer is the only party who can see their own coefficients; they type them. New provider `custom_formula`, one new option `price_formula` (a JSON string, the `static_profile` precedent exactly), and a new module `app/custom_formula.py`. The index path is `generic_dayahead`'s, not a second one: the URL/override decision is now one shared `dayahead_feed_url()` both plugins call, same feed, same Brussels-calendar range, same columnar parser, same declared egress hosts. It declares {ENERGY, MARKUP}, NOT ALL_IN. A card's Tariefformule line is the energy component alone - Eneco tabulates network tariffs and levies separately, ENGIE states the formula excludes network, distribution, transport, levies and excise - so ALL_IN would lie for every operator who typed what their card says and would drop the taxes from every hour (0.2125 -> 0.1555 EUR/kWh, measured). THE CARD IS THE GRADER, and that is why this is safe to ship. The framework already mechanises that a PLUGIN cannot double-count. This introduces a risk none of those guards can see because it is config, not code: the OPERATOR double-counting, by folding network charges into `offset` while price_taxes_eur_kwh carries them too. So validate.py recomputes the card's own printed price from the operator's coefficients at startup and refuses to start unless the two agree to within 0.01, naming the discrepancy. An inflated offset cannot pass: 15.55 becomes 28.27. The same check catches VAT omitted, VAT doubled, a transposed digit and a unit mismatch between the two sides. And the limit, in the same sentence as the claim: it grades the coefficients against the card, NOT the card against reality. A consistent-but-wrong pair passes. A second refusal covers the one unit error the first cannot see - the one applied to both sides at once - by bounding the card's own point to 0.02-1.00 EUR/kWh. Its FLOOR is applied to the energy figure rather than the all-in one because the shipped 0.06 of taxes is three times that floor and would carry a hundredfold error over it alone; found by writing the mutation, not by review (M10, +0 B). The market's own arithmetic, reproduced through the shipped code: Eneco (0.102 x 133.9905 + 1) x 1.06 = 15.5471 card prints 15,55 ENGIE (0.1 x 61.96 + 0.9) x 1.06 = 7.5218 card prints 7,522 NO EXPRESSION EVALUATION OF ANY KIND. The string is settable over HTTP through the add-on's own ingress page, so eval on it is RCE in a root container holding SUPERVISOR_TOKEN and driving an inverter over RS485 - but the deciding argument is that an expression is UNVERIFIABLE: two coefficients can be graded against the card, an arbitrary expression cannot be graded against anything, so it would make the invisible-wrong-coefficient problem strictly worse. An unknown field is REFUSED rather than ignored, so `"expr"` is told it does not exist. Future shapes become named fields, never a grammar. test_price.py 15f walks the module's AST for eval/exec/compile/__import__/literal_eval and exercises the scanner's red direction on every run. Refused at startup: card absent or out by >0.01; `units` absent (no default); factor == 0 (every spread 0, arbitrage silently never fires - the message points at static_profile); factor < 0 (inverts the market); vat_pct outside 0-30 (0 stays legitimate); non-finite or non-numeric; unknown field, index or resolution; the plausibility band. A card older than ~6 months WARNS and does not refuse - ENGIE freezes coefficients for a contract's duration. Negative output prices are not refused anywhere. A startup preview logs the next 24 h as `index EUR/MWh -> all-in EUR/kWh` with min/median/max and the day's spread, through a new default-silent `PriceProvider.startup_preview()` hook - only the plugin knows what went in to its own arithmetic. Emitted once per process, and a preview that raises cannot cost the site its prices. `custom_formula` joins the config.yaml enum through the DERIVED set PROVIDERS | RETIRED_PROVIDERS | {"off"}, not a hardcoded list. Both translations describe the option and the new id. DOCS.md replaces the "planned" sentence with the shape, a worked example from a real card, a real startup transcript and the limit of the check stated beside the claim. 22 mutations, one per check added, no survivors - MUTATION.md carries the ledger. M13 (the preview's index column) was a -13 B survivor of the whole suite on the first attempt because the check graded the HEADING and not the row; it is graded on a rendered row now. All 29 suites green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BwRLw7eKYj2byVdwB6kbjU	2026-09-13 03:49:08 +02:00