From ef8c5dcf627ba7ad18bfac14ee2e982dec6e63ae Mon Sep 17 00:00:00 2001 From: ems-agent Date: Thu, 19 Nov 2026 13:02:02 +0100 Subject: [PATCH] EV-18 review round 3: the DECISIONS line and a comment say what the contradiction latch does Wording only. DECISIONS/EV-04: a contradiction is a meter that answered and fell short (an unknown reading is none), and it grades no alarm while the guard's input keeps the figure. ctl_car.car_cycle: the car-over row keeps the figure only with the cover off. Co-Authored-By: Claude --- goodwe_controller/DECISIONS/EV-04-manual-mode.md | 7 ++++--- goodwe_controller/app/ctl_car.py | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/goodwe_controller/DECISIONS/EV-04-manual-mode.md b/goodwe_controller/DECISIONS/EV-04-manual-mode.md index 3a45fb7..2c2b9e3 100644 --- a/goodwe_controller/DECISIONS/EV-04-manual-mode.md +++ b/goodwe_controller/DECISIONS/EV-04-manual-mode.md @@ -148,9 +148,10 @@ up to 1.8 kW; the 40 Wh floor fixes that.) batteries (`_car_over_now`), or by the EV-10 test above. A `None` car figure or battery reading explains nothing in that cycle and latches nothing; a car known to draw nothing (fresh, not charging) still grades the house's need. - Owner 2026-11-19: a figure the energy meter contradicted (fresh, charging, - not corroborated) stays untrusted to the quarter's end. After a restart or a - gap the car's earlier energy is not known, so it counts as house. + Owner 2026-11-19: a figure the energy meter contradicted (it answered over a + whole window and fell short; an unknown reading is no contradiction) grades + no alarm to the quarter's end; the guard's input keeps it. After a restart + or a gap the car's earlier energy is not known, so it counts as house. - **Our own write is ours until its mute ends** (EV-12). The mute of the tracker's own detector opens before the write and runs 15 s from when it returns, because the read-back reaches the cycle while the write still waits for it. diff --git a/goodwe_controller/app/ctl_car.py b/goodwe_controller/app/ctl_car.py index d3f86a2..479f737 100644 --- a/goodwe_controller/app/ctl_car.py +++ b/goodwe_controller/app/ctl_car.py @@ -355,7 +355,7 @@ class CarMixin: # EV-18 (owner 2026-11-19): a figure the meter contradicted grades no # alarm again in that quarter, not even as our own pause's stand-in. # The alarm decision only: the car's energy count, the guard's input - # (`car_exclude`) and the car-over row keep the figure. + # (`car_exclude`) and, with the cover off, the car-over row keep it. key = None if real_proj is None else real_proj.block_start if key is not None and not own and self._car_contradicted(mono): self._car_contra_block = key