OPT-34 round 2: the latch follows the plan, up or down, and drops what left it

While a forecast is present and the cheap run holds, the night-charge latch is
rebuilt from the plan: a latched battery takes its current level whatever its
role this tick (a fresh figure may lower it below the SoC), one that left the
plan is dropped, a new one comes in only while it charges from the grid.
Test: a fresh brighter figure lowers A below its SoC, the sensors go quiet, A
does not charge back up. CHANGELOG summary says two fixes.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC

goodwe_controller/test_opt34.py

@@ -236,12 +236,14 @@ def opts(late=False, cap=2500):
     return o
 
 
-def sensors(*, silent=True, fresh_from=None, fresh=(1.0, 5.0)):
+def sensors(*, silent=True, fresh_from=None, fresh=(1.0, 5.0),
+            fresh_until=None):
     """Sensors that update until 17:05 (or all night) and then show that
     reading for good; from `fresh_from` a new reading every call."""
     def f(now, ent):
         if fresh_from is not None and now >= fresh_from:
-            return st(fresh[0] if ent == T_ENT else fresh[1], now)
+            when = now if fresh_until is None else min(now, fresh_until)
+            return st(fresh[0] if ent == T_ENT else fresh[1], when)
         when = min(now, LAST) if silent else now
         return st(0.4 if ent == T_ENT else 6.0, when)
     return f
@@ -260,7 +262,8 @@ def run_night(spec):
             store.data[unit_key(f"inverter-{u}", k)] = val
     sens = sensors(silent=spec.get("silent", True),
                    fresh_from=spec.get("fresh_from"),
-                   fresh=spec.get("fresh", (1.0, 5.0)))
+                   fresh=spec.get("fresh", (1.0, 5.0)),
+                   fresh_until=spec.get("fresh_until"))
     clock = [EVENING[0]]
 
     class H(rp.Hass):
@@ -399,6 +402,12 @@ SCEN = {
     "tail": dict(start=at(4, 5, 40), hours=80 / 60.0,
                  soc={"a": 70.0, "b": 70.0}, restarts=[at(4, 6, 30)],
                  marks=[at(4, 5, 50), at(4, 6, 10), at(4, 6, 40)]),
+    # a fresh, brighter figure at 03:10 lowers A's level below its SoC (A
+    # stops, B goes on), then the sensors go quiet: the forecast ends at 06:10
+    "lowered": dict(start=at(4, 2, 30), hours=4.5, house_w=500.0,
+                    soc={"a": 30.0, "b": 30.0}, fresh_from=at(4, 3, 10),
+                    fresh_until=at(4, 3, 10), fresh=(30.0, 30.0),
+                    marks=[at(4, 3, 5), at(4, 3, 20), at(4, 6, 30)]),
     # the same, B already full and a 1.5 kW limit: the run is sized at the
     # battery's 2.5 kW rating and ends at 06:33, before A is there, so the
     # next slice is planned after 06:00 and is only A's
@@ -509,6 +518,23 @@ check("06:10 and 06:40 (the second after a restart at 06:30): A still "
       and t6["why_a"] == "grid_charge" and t7["why_a"] == "grid_charge")
 check("... and ends the hour higher than it was (+8 % or more from 06:00)",
       tl["soc_at"]["06:55"][0] > tl["soc_at"]["06:00"][0] + 8.0)
+lo = R["lowered"]
+l0, l1, l2 = (lo["marks"][k] for k in ("03:05", "03:20", "06:30"))
+check("a fresh, brighter figure lowers A's level below its SoC during the "
+      f"charge ({l0['target_a']} -> {l1['target_a']}, SoC "
+      f"{l1['soc_a']:.1f} %), and A stops",
+      l0["target_a"] is not None and l1["target_a"] is not None
+      and l1["target_a"] < l1["soc_a"] - 2.0
+      and l1["target_a"] < l0["target_a"] - 10.0
+      and lo["soc_at"]["03:30"][0] < lo["soc_at"]["03:20"][0] + 0.5)
+check("the sensors go quiet, the forecast ends (06:30): the latch holds the "
+      "LOWERED level, so A does not charge back up to the old one "
+      f"({lo['soc_at']['03:30'][0]:.1f} -> {lo['soc_at']['06:55'][0]:.1f} %), "
+      "while B goes on",
+      l2["fc_none"] and l2["target_a"] is not None
+      and l2["target_a"] < l2["soc_a"] and l2["p_a"] > -200.0
+      and lo["soc_at"]["06:55"][0] < lo["soc_at"]["03:30"][0] + 1.0
+      and lo["soc"][1] > lo["soc_at"]["03:30"][1] + 15.0)
 tb = R["tail_bfull"]
 check("B full: the run ends at 06:33 before A is at its level, so the next "
       "slice is only A's, planned after the figure has ended with A's "