From 96375ecbec836aa011cd4a58cfbd2a84701722f4 Mon Sep 17 00:00:00 2001 From: glenn schrooyen Date: Wed, 21 Oct 2026 02:47:27 +0200 Subject: [PATCH] SAFETY-119 review: DECISIONS states the steady-meter limit The quarter-edge numbers were measured with one cycle per reading at a steady interval. With the default 15 s cycle floor, a meter that is sometimes slower adds cycles on an old reading and the false alarm can come back (reviewer's runs, 11 seeds). Text only. Co-Authored-By: Claude Opus 5.5 --- .../DECISIONS/SAFETY-119-bound-after-hand-back.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/goodwe_controller/DECISIONS/SAFETY-119-bound-after-hand-back.md b/goodwe_controller/DECISIONS/SAFETY-119-bound-after-hand-back.md index 70ac4e9..bb05e7e 100644 --- a/goodwe_controller/DECISIONS/SAFETY-119-bound-after-hand-back.md +++ b/goodwe_controller/DECISIONS/SAFETY-119-bound-after-hand-back.md @@ -71,6 +71,13 @@ in the case above), so nothing more is claimed there. The cap held at 1 to meters the meter's lag puts quarters over it, the same with and without the fix (commands are identical). +**Limits.** These runs have one cycle per meter reading, at a steady +interval. A 20 or 30 s cycle needs `cycle_floor_s` raised; at the default +15 s, a slower meter adds cycles on an old reading. Measured that way (11 +seeds): a 15 s meter that varies by up to 30 % false-alarmed on 5 seeds, a +30 s meter on 10 (0 to 4 in 2 h, 8 to 15 without the fix); a 20 s meter on +none. The case above still warned every quarter there. + **Kept.** The loop in charge at its rail warns on the same cycle as before. The start and a restart after a stop are not hand-backs. The quarter-edge kick of `test_safety119.py` part 1 stays hidden (see above).