From 7de77a5a097a2ccfd2ed925a7196e0e45ee880df Mon Sep 17 00:00:00 2001 From: glenn schrooyen Date: Mon, 2 Nov 2026 05:16:28 +0100 Subject: [PATCH] SAFETY-128 review: DECISIONS states the slow-battery limit as measured Round 2 review: a 10 s dead time reads late at 1-2 s meters, and a 15-20 s lag gives late fits; the note said 3-20 s and 6-10 s gave none. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC --- .../DECISIONS/SAFETY-128-late-readings.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/goodwe_controller/DECISIONS/SAFETY-128-late-readings.md b/goodwe_controller/DECISIONS/SAFETY-128-late-readings.md index 41fd33a..13888d7 100644 --- a/goodwe_controller/DECISIONS/SAFETY-128-late-readings.md +++ b/goodwe_controller/DECISIONS/SAFETY-128-late-readings.md @@ -23,8 +23,9 @@ inverter limit in its last seconds (OPT-34 rig F-2). Late from 9.5 s, after 2 late fits in a row. A late fit must explain 75 % and beat every fit up to 6.5 s by 2x; the shortest delay that fits about as well (within 2x, or within 2 500 W^2) is taken instead, since a swing's - period fits again. A slow battery (3-20 s lag) answering at once gives no - late fit (checked in the test). No late battery fit counts for 60 s + period fits again. A slow battery (3-10 s lag) answering at once gives no + late fit; at a 15-20 s lag some fits read late (see "What it costs"). + No late battery fit counts for 60 s after a battery gave nothing under its ask: an emptied battery lined its old movement up as 85 s late. - **Meter** (`MeterFit`, round 1's fit): `meter(t) + request(t - d)` is the @@ -56,7 +57,7 @@ inverter limit in its last seconds (OPT-34 rig F-2). WARNING (`READINGS_LATE`) per episode and one line when it ends. **With readings on time** no verdict was reached in any reviewer scenario -(owner-shaped house, ovens 20/40 to 60/60 s, clouds, a 300 W/s battery, 6-10 s +(owner-shaped house, ovens 20/40 to 60/60 s, clouds, a 300 W/s battery, 6-8 s dead times, HA jitter 0-4 s, an EV following the meter, capped batteries, HA restarts, meter pauses; 1, 2 and 5 s meters) nor in 2 days of the recorded house at 1, 2 and 5 s ticks, so the commands are the same as without the gate. @@ -66,8 +67,10 @@ The fits run all the time; the pull request has the counts. - Found 36-68 s after a lag starts at 1-2 s meters, about 3 minutes at a 5 s meter (battery fit only; the meter fit needs a faster meter). Until then control is as before. At 5 s and 30 s late the export is cut to about a third, not removed. -- A battery whose own answer takes about 10 s is close to the threshold: an - 8 s dead time reads 7, 10 s reads 9, HA 10 s late reads 10. +- A battery that answers slowly is read as late readings and held: a dead + time of 10 s or more (8 s reads 7-8; 10 s reads 10 at 1-2 s meters, 9 at + 5 s), or a 15-20 s lag (review round 2). The GoodWe measured settles in 6 s + (`freshness.PLANT_SETTLE_S`); the row then blames Home Assistant wrongly. - The row can stay up to 180 s after the readings are on time on a steady site. While only the meter has shown the delay it gives no figure. - A battery that cannot follow while the readings are late (at a limit, not