From 71045152295f1d9a52b017c2fe03246c8a7bf68c Mon Sep 17 00:00:00 2001 From: glenn schrooyen Date: Tue, 29 Sep 2026 11:21:32 +0200 Subject: [PATCH] OPT-11 P3 option A review: wizard no longer says modes come later Step 5 said "Choosing a mode for each battery comes in a later update", stale since P1. It now points to battery modes on the Batteries screen (EN/NL); test_setup checks the new line. Co-Authored-By: Claude Opus 5.5 --- goodwe_controller/app/ui_text/en.json | 2 +- goodwe_controller/app/ui_text/nl.json | 2 +- goodwe_controller/test_setup.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/goodwe_controller/app/ui_text/en.json b/goodwe_controller/app/ui_text/en.json index ddb987b..57d70c9 100644 --- a/goodwe_controller/app/ui_text/en.json +++ b/goodwe_controller/app/ui_text/en.json @@ -209,7 +209,7 @@ "5": {"name": "Peak limit", "description": "The grid stays under this limit, averaged over each 15-minute period."}, "6": {"name": "Check and start", "description": "The add-on checks everything with its own start checks, then restarts."} }, - "modes_later": {"description": "Choosing a mode for each battery comes in a later update."}, + "modes_later": {"description": "After setup, turn on battery modes to choose a mode for each battery on the Batteries screen."}, "kettle": { "name": "Check the direction", "description": "Read the meter, switch on a kettle, then read the meter again.", diff --git a/goodwe_controller/app/ui_text/nl.json b/goodwe_controller/app/ui_text/nl.json index 086cb56..5690fc7 100644 --- a/goodwe_controller/app/ui_text/nl.json +++ b/goodwe_controller/app/ui_text/nl.json @@ -190,7 +190,7 @@ "5": {"name": "Piekgrens", "description": "Het net blijft onder deze grens, gemiddeld over elk kwartier."}, "6": {"name": "Nakijken en starten", "description": "De add-on kijkt alles na met zijn eigen startcontroles en herstart dan."} }, - "modes_later": {"description": "Een modus kiezen per batterij komt in een latere update."}, + "modes_later": {"description": "Zet na de installatie batterijmodi aan om per batterij een modus te kiezen op het scherm Batterijen."}, "kettle": { "name": "Richting nakijken", "description": "Lees de meter af, zet een waterkoker aan en lees de meter opnieuw af.", diff --git a/goodwe_controller/test_setup.py b/goodwe_controller/test_setup.py index 00f2efe..bf37557 100644 --- a/goodwe_controller/test_setup.py +++ b/goodwe_controller/test_setup.py @@ -76,8 +76,8 @@ check("the mockup's six steps: meter, inverters, solar, prices, peak limit, " and [WS["steps"][str(n)]["name"] for n in range(1, 7)] == ["Your meter", "Inverters and batteries", "Solar", "Prices", "Peak limit", "Check and start"]) -check("battery modes are not a step yet (OPT-11): step 5 says they come later", - "later update" in WS["modes_later"]["description"] +check("battery modes are not a wizard step (OPT-11): step 5 points to the Batteries screen", + "Batteries screen" in WS["modes_later"]["description"] and not any("mode" in k for k in BY_STEP[5])) SPEC = uipage.setup_spec() check("the spec the page reads is the table's",