MAINT-20 part 1 review: restore three lost lines, rewrap ragged comments
checks / unit (pull_request) Successful in 19m51s
infra-pin / fresh (pull_request) Successful in 2s

Comment, docstring and DECISIONS only (same-code script OK; python -OO
bytecode now identical for all six files).
- peakguard.charge_room_w: one-line docstring + SAFETY-125 pointer (cut whole).
- peakguard.shaping_suspended: keep 'the one place this conjunction is
  written; do not inline it'.
- price_forecast module note: an hour with no price and no yesterday is left
  out, never filled (test_price.py 14d cites the module note for it).
- Refill comment blocks the cut left ragged; DECISIONS pointers on one line.
- FCST-04 note: _yesterday_of(), not _previous_day(); FCST-03 note: the 49
  stronger cases are why the rule is a real change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bdqr7PiaHcBnzPituu2yTC
This commit is contained in:
glenn schrooyen
2026-11-01 03:02:51 +01:00
co-authored by Claude Opus 5.5
parent 6e2fde63ff
commit 63dda4b0d3
7 changed files with 61 additions and 78 deletions
@@ -52,7 +52,8 @@ files. It cannot be made complete from its arguments: `published` is over the
whole unwindowed read while the fill emits `[since, until)`, so a published point
outside the window is legitimately absent. FCST-05 built "every published point
is emitted" (+162 B) and it took the 1 h, 12 h and 48 h horizon checks red on a
healthy feed (49 cases scored stronger), so the rule as stated is wrong, and
healthy feed (a real change: the differential scored it 49 cases stronger),
so the rule as stated is wrong, and
asserting a completeness the instrument lacks is MUTATION.md habit 16's defect.
## The fill keys on the wall clock
@@ -205,7 +205,7 @@ cache on the ephemeral layer. "Cannot persist" is one question asked after the
attempt: see [[FCST-06]]; `self._days` never holds a point the file does not.
**Brussels date, not UTC.** 23:30 UTC in July is already tomorrow in Belgium.
`_previous_day()` subtracts on the local `date`, not the instant: the old
`_yesterday_of()` subtracts on the local `date`, not the instant: the old
`brussels(stamp) - timedelta(days=1)` took 24 absolute hours and, at
2026-03-30T00:30+02:00, returned 2026-03-28 (a two-day-old profile flagged as
yesterday's). Rows are keyed by instant, not local hour, so the two 02:00s of