UX-08 phase 2b review: keep over-rating evidence, pin latch clearing, plainer rows
- During a bound episode an earlier over-rating count stays on the page (amber, under its own title); test_clamp pins it. - test_messages pins that every latch row says how it clears. - pv_entities description no longer claims the page names the entity (en, nl); allowlist hash updated for that option-desc line. - Plainer texts: multi-inverter direction banner, "fine now" after an episode, and the e-stop, peak-forecast and peak-guard-waiting rows move to messages.py. - TEL-12 DECISIONS points to UX-08 item 3 for the retired row rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
696142bccc
commit
571b884315
@@ -549,7 +549,7 @@ check("...and once clear, a warn row still says how many times it engaged, "
|
||||
any(c["warn"] and c.get("id") == "not_keeping_up"
|
||||
and c["text"].startswith(messages.T_LOOP_BOUND)
|
||||
and messages.times(ctl_r.clamp_wd.bound) in c["text"]
|
||||
and "not now" in c["text"] for c in ctl_r.checks()))
|
||||
and "fine now" in c["text"] for c in ctl_r.checks()))
|
||||
# UX-07 item 1: the after-episode row used to say "output clamp ... engaged N
|
||||
# time(s)" for integrator-bound cycles. Each count now sits under its own name.
|
||||
check("UX-07 item 1: bound-only engagements are counted as the bound, and no "
|
||||
@@ -559,6 +559,20 @@ check("UX-07 item 1: bound-only engagements are counted as the bound, and no "
|
||||
and not any(c.get("id") == "power_too_high"
|
||||
or messages.T_OUTPUT_CLAMP in c["text"]
|
||||
for c in ctl_r.checks()))
|
||||
# ...and an earlier over-rating count stays on the page while a LATER bound
|
||||
# episode runs: it is the software-fault evidence, and that episode (bug False)
|
||||
# cannot have added to it, so "fine now" is true of it.
|
||||
_w = ctl_r.clamp_wd
|
||||
_saved = (_w.active, _w.bug, _w.over_rating)
|
||||
_w.active, _w.bug, _w.over_rating = True, False, 2
|
||||
_rows = ctl_r.checks()
|
||||
_w.active, _w.bug, _w.over_rating = _saved
|
||||
check("UX-07 item 1: during a bound episode an earlier over-rating count is "
|
||||
"still shown, amber, under its own title",
|
||||
any(c.get("id") == "not_keeping_up" for c in _rows)
|
||||
and any(c.get("id") == "power_too_high" and c["warn"] and not c["ok"]
|
||||
and c["text"] == messages.row_before(messages.T_OUTPUT_CLAMP, 2)
|
||||
for c in _rows))
|
||||
|
||||
# ⚠️ NOT A TRIP. 11.2's action is "clamp and alarm"; the loop keeps running and
|
||||
# keeps writing the clamped value. If a later cut changes that it must come here.
|
||||
|
||||
Reference in New Issue
Block a user