UX-08 phase 2a: short, plain notifications, and a ratchet for the rest
checks / unit (pull_request) Successful in 8m54s
infra-pin / fresh (pull_request) Successful in 1s

Every HA notification the add-on raises now has a title of at most 5
everyday words and a one-sentence body; a red alarm may use three so no
action is lost. The texts live in app/messages.py, the rule in STYLE.md,
and the detail that moved out in DOCS.md "Notifications", which each body
links to. No notification_id, trigger or cadence changed.

test_messages.py enforces the rule on every notification, fails any
notification worded outside app/messages.py, and ratchets the kinds not yet
rewritten (rows, banners, refusals, logs, options) through a shrinking
allowlist of 200. Six tests re-pinned from prose to meaning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LyR88rXETvwhTgx6yHE39p
This commit is contained in:
glenn schrooyen
2026-09-27 01:00:54 +02:00
co-authored by Claude Opus 5.5
parent 2503de124e
commit 50ccea3dd7
13 changed files with 1170 additions and 185 deletions
+113
View File
@@ -2802,6 +2802,119 @@ it.
| `estop_fitted` | Whether the RS485 e-stop is installed. Drives the warning banner |
| `log_level` | `trace`/`debug`/`info`/`warning`/`error` |
## Notifications
Each Home Assistant notification this add-on raises has a short title, one
sentence (a red alarm may use three), and a **Details** link to the add-on
documentation that names the section below. This section holds what the
notification leaves out. The wording rule is `STYLE.md` in the repository; the
texts live in `app/messages.py`. Every notification keeps a fixed
`notification_id`, so a repeat replaces the card instead of adding one.
| Title | Severity | id |
|---|---|---|
| Battery is not keeping up | warning | `goodwe_integrator_bound` |
| Power request too high | alarm | `goodwe_output_clamp` |
| Load too high for battery | alarm | `goodwe_peak_saturated` |
| Battery at its peak reserve | alarm | `goodwe_peak_soc_floor` |
| Inverters working against each other | alarm | `goodwe_circulating_power` |
| *name* is not delivering | alarm | `goodwe_not_delivering_<name>` |
| Meter reading may be stuck | alarm | `goodwe_meter_frozen` |
### Battery is not keeping up
The grid-following loop's integrator reached its anti-windup bound
(`integrator_max_w`): the controller has been asking for more than the battery
delivers for a while. This is SAFETY-40, and it is **not** a fault. No command
went over the rating and control keeps running. Short spells after a big load
or solar step are normal. If it keeps coming back, check that the battery
follows its commands. The bound and the command of that tick are in the add-on
log (WARNING, reason code `OUTPUT_CLAMP`). See *The winding-loop alarm* for the
full story.
### Power request too high
The controller computed a command above a limit, and the command was cut to that
limit before it was written. The notification names what was asked, what was
sent, and which limit cut it: the configured inverter rating (`max_w`), the
inverter's own limit (the setpoint device's range), or the inverter rating on
the loop side. Asked always comes first. This is a **software fault** (the old
wording was "BUG SIGNAL"). It is not the inverter failing to follow a legal
command, which is the saturation freeze and does not alarm. Control keeps
running. Report it with the add-on log, whose ERROR line carries the reason code
`OUTPUT_CLAMP` and the full figures. See *The winding-loop alarm*.
### Load too high for battery
The capacity-peak guard (SAFETY-07) is asking for everything the inverter can
discharge, and the running 15-minute average is still projected over the peak
limit. That 15-minute period will set or raise the month's billed peak
(capaciteitstarief). The controller is not at fault: the house load is larger
than the inverter. Switching off load in the next few minutes is the only thing
that still changes the bill. The projection and the watts are in the add-on log
and on the status page. See *The capacity-peak guard*.
### Battery at its peak reserve
The peak guard wanted to discharge to hold the 15-minute peak, but it may not go
below the peak reserve (`peak_soc_floor`, SAFETY-24). It also stops when the
battery level cannot be read, or when no reserve is set. So this 15-minute
period will go over the peak limit and set or raise the month's billed peak.
Charging from the grid stays blocked meanwhile. On a site with several inverters
the notification names the battery at its limit (SAFETY-32): each battery is
graded against its own cut-out level (`bms_soc_floor`), and raising the other
batteries' settings will not change this one.
⚠️ **The reserve binds the peak guard only (SAFETY-25).** It is not a
whole-battery reserve. Ordinary self-consumption has no such floor and goes on
discharging below it, down to the battery's own cut-out level. See *What
`peak_soc_floor` does not protect*.
### Inverters working against each other
Two inverters were pushing power into each other: one discharging while another
charged (SAFETY-31). **The meter cannot see this.** The two flows cancel at the
P1 meter, so the site reads idle while both batteries cycle through two
conversion stages. Every other guard reads that net figure, so none of them
fires. The add-on has **stopped control and commands 0 W on every inverter**.
If the grid reading does not move after that, one inverter is no longer
listening to the add-on; this has happened on this hardware, once for
6 h 25 min. Switch the inverters off at the isolator. The alarm is latched: a
Home Assistant or add-on restart does not clear it, and the card is raised
again every 5 min until you start control on the add-on page. The watts and the time
window are in the add-on log and on the status page. See *The circulating-power
alarm*.
### An inverter is not delivering
One inverter has stood well short of its share of the site target for longer
than the hold time (SAFETY-42), while the others have not. No other check sees
this. A unit at 0 W is absent rather than pushing the wrong way, so the per-unit
sign check and the circulation check stay quiet. **Nothing is commanded
differently.** The guard only reports: commanding an inverter that has stopped
listening achieves nothing, and the only fallback the add-on has is
all-or-nothing. The other inverters keep regulating, and the site is short by up
to the missing unit's rating. Check, in this order:
1. Is the inverter answering on RS485 at all?
2. Is its battery colder or emptier than its configured cut-out level
(`bms_soc_floor`) says? If so, that setting does not describe this battery.
3. Is anything else writing to it?
The alarm is latched and survives restarts; start control on the add-on page
once you know why. See *A unit that stops DELIVERING is a third fault again*.
### Meter reading may be stuck
The meter keeps answering, but its value has not changed for longer than the
hold time while the command stands at the power limit (SAFETY-18). The loop is
regulating against a number that has stopped moving. The age is still fresh, so
no other guard stops it. This is an alarm only: control keeps running and keeps
following the reading. Held for a whole 15-minute period, it can set the month's
billed peak. Check the meter; if it is stuck, stop control on the add-on page.
The limit and command figures are in the add-on log and on the status page. See
*The frozen-meter alarm*.
## The Web UI
The ingress panel shows live values, why the controller is commanding what it