From 39e6c260fe14f2b7af7559683f3ca0b987b97f42 Mon Sep 17 00:00:00 2001 From: Claude review agent Date: Mon, 28 Sep 2026 15:15:51 +0200 Subject: [PATCH] UX-15 review: DECISIONS states the TEST-23 run that happened (PR #147) It said the PR had TEST-23 evidence, but the PR says TEST-23 was not run. Co-Authored-By: Claude Opus 5.5 --- goodwe_controller/DECISIONS/UX-15-setup-only-mode.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/goodwe_controller/DECISIONS/UX-15-setup-only-mode.md b/goodwe_controller/DECISIONS/UX-15-setup-only-mode.md index 7265a50..d733a4c 100644 --- a/goodwe_controller/DECISIONS/UX-15-setup-only-mode.md +++ b/goodwe_controller/DECISIONS/UX-15-setup-only-mode.md @@ -87,8 +87,12 @@ rule (UX-13 ยง2) sends it to the wizard as before. read-only refusal removed, the Controller's check removed, `amain()` giving setup-only mode a writable HomeAssistant, `/action`'s 409 removed, and the `return` after `serve()` removed. -- TEST-23: a real container on the shipped defaults, with the Supervisor - stand-in logging every service call (the PR has the evidence). +- TEST-23 (PR #147 review, 2026-09-28): the add-on image on the shipped + defaults and an empty `/data` made 0 service calls and no MQTT request in + 3.5 minutes of setup-only mode, counted in both the stand-in and the rig + shim logs. The wizard save then passed Supervisor 2026.08.0's `AppOptions`, + and after the restart it ran in shadow: 11 of 11 writes were + `set_value 0.0`. ## 5. The wizard fixes in the same card