UX-13 P4 review fixes (PR #146, comment 1887)

R1: first_start also needs a Store created at this boot (Store.fresh), so
    old never-started sites (both TEST-23 add-ons, one in shadow) stay on Home.
R2: a kettle skip after a fall says on the last step that the reading went down.
R3: the shadow switch goes only on the model the wizard posts, never into V.
R4: Home Assistant not answering is red on the last step.
R5: meter + solar + battery below -300 W flags a reversed battery sensor.
R6: the live checks say what to change and where.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

goodwe_controller/app/validate.py

@@ -1782,6 +1782,9 @@ def _entity_notes(notes, opts: dict, entities: dict, bad=()) -> None:
 # --------------------------------------------------------------------------- #
 # Below this a battery or solar reading counts as idle for a sign check.
 IDLE_W = 50.0
+# Meter + solar + battery is the house's use, never below zero. Below minus
+# this, read seconds apart, a direction is reversed (a battery giving power).
+BALANCE_W = 300.0
 # The keys that pick the meter. A meter the add-on reads itself (HomeWizard,
 # MQTT) is only known live when the running options read the same one.
 _METER_KEYS = ("meter_source", "p1_host", "meter_mqtt_topic")
@@ -1848,33 +1851,50 @@ def setup_checks(opts: dict, *, entities: dict | None, running=None,
     """
     notes: list[Note] = []
     if entities is None:
-        _advise(notes, "warn", (), "Home Assistant is not answering, so "
-                "no entity was checked yet.")
+        # Red: only the list can tell a missing power request entity (SAFETY-77).
+        _advise(notes, "bad", ("setpoint_entity",), "Home Assistant is not "
+                "answering, so press Check again once it is back.")
     else:
         _entity_notes(notes, opts, entities, bad=("setpoint_entity",))
-    _meter_check(notes, opts, entities, running, meter_now_w)
-    for who, entry in _cards(opts):
-        _card_checks(notes, who, entry, entities)
+    meter = _meter_check(notes, opts, entities, running, meter_now_w)
+    batts = [_card_checks(notes, who, entry, entities)
+             for who, entry in _cards(opts)]
+    solar = []
     if entities is not None:
         flipped = pv.inverted(opts)
         for entity in pv.entities(opts):
             w, _unit = _reading(entities, entity, convert=True)
             if entity not in entities or w is None:
+                solar.append(None)
                 continue
             if w < -IDLE_W and entity not in flipped:
+                solar.append(None)
                 _advise(notes, "warn", ("pv_invert_entities",),
-                        f"{entity} reads below zero now, so its solar "
-                        "production sign looks reversed.")
+                        f"{entity} reads below zero now, so turn on its "
+                        "“Reads negative” switch in the Solar step.")
             else:
                 w = -w if entity in flipped else w
+                solar.append(w)
                 _advise(notes, "ok", ("pv_entity",),
                         f"{entity} reads {_signed(w)} of solar production "
                         "now.")
+    # A battery sensor that reads the wrong way while giving power makes the
+    # house use less than nothing. Only with every term known: a missing
+    # solar reading could be the difference.
+    known = [meter] + batts + solar
+    if solar and batts and all(w is not None for w in known) \
+            and sum(known) < -BALANCE_W:
+        _advise(notes, "warn", ("batt_invert",),
+                f"The readings add up to {_signed(sum(known))} of house "
+                "use, so check each "
+                "battery's “Battery power sign is reversed” switch in step 2.")
     _price_check(notes, opts, running, prices_known)
     return notes
 
 
-def _meter_check(notes, opts, entities, running, meter_now_w) -> None:
+def _meter_check(notes, opts, entities, running, meter_now_w):
+    """The meter line. Returns the grid reading in W (positive: taken from
+    the grid) as the add-on will read it, or None when it is not known."""
     source = str(opts.get("meter_source") or "off").strip()
     if source == "off":
         parts = [(opts.get("meter_entity"), 1.0)]
@@ -1888,28 +1908,29 @@ def _meter_check(notes, opts, entities, running, meter_now_w) -> None:
             running.get(k) == opts.get(k) for k in _METER_KEYS)
         if same and meter_now_w is not None:
             _meter_line(notes, float(meter_now_w))
-        else:
-            _advise(notes, "info", ("meter_source",), "The add-on reads "
-                    "this meter itself, so Home shows its reading after "
-                    "the restart.")
-        return
+            return float(meter_now_w)
+        _advise(notes, "info", ("meter_source",), "The add-on reads "
+                "this meter itself, so Home shows its reading after "
+                "the restart.")
+        return None
     if entities is None:
-        return
+        return None
     total = 0.0
     for entity, sign in parts:
         entity = str(entity or "").strip()
         if not entity or entity not in entities:
-            return              # a refusal or a missing-entity note says so
+            return None         # a refusal or a missing-entity note says so
         w, text = _reading(entities, entity)
         if w is None:
             _advise(notes, "warn", ("meter_source",),
-                    f"{entity} reads {text} now, so the meter has no "
-                    "reading yet.")
-            return
+                    f"{entity} reads {text} now, so check it in Home "
+                    "Assistant before you start.")
+            return None
         total += sign * w
     if source == "off" and opts.get("meter_invert"):
         total = -total
     _meter_line(notes, total)
+    return total
 
 
 def _meter_line(notes, w) -> None:
@@ -1922,9 +1943,11 @@ def _meter_line(notes, w) -> None:
     _advise(notes, "ok", ("meter_source",), text)
 
 
-def _card_checks(notes, who, entry, entities) -> None:
+def _card_checks(notes, who, entry, entities):
+    """The checks for one inverter's card. Returns its battery power in W,
+    positive while giving power, or None when it is not known."""
     if entities is None:
-        return
+        return None
     setpoint = str(entry.get("setpoint_entity") or "").strip()
     if setpoint and setpoint in entities:
         _advise(notes, "ok", ("setpoint_entity",),
@@ -1933,7 +1956,8 @@ def _card_checks(notes, who, entry, entities) -> None:
     soc = str(entry.get("soc_entity") or "").strip()
     if not soc:
         _advise(notes, "warn", ("soc_entity",), f"There is no battery "
-                f"level entity{who}, so the add-on holds 0 W.")
+                f"level entity{who}, so pick one in step 2 or the add-on "
+                "holds 0 W.")
     elif soc in entities:
         level, _unit = _reading(entities, soc)
         if level is None or not 0.0 <= level <= 100.0:
@@ -1948,7 +1972,7 @@ def _card_checks(notes, who, entry, entities) -> None:
         if w is None:
             _advise(notes, "warn", ("batt_entity",), f"The battery "
                     f"power{who} reads nothing now, so check {batt}.")
-            return
+            return None
         w = -w if entry.get("batt_invert") else w
         if abs(w) < IDLE_W:
             _advise(notes, "info", ("batt_entity",), f"The battery{who} is "
@@ -1958,6 +1982,8 @@ def _card_checks(notes, who, entry, entities) -> None:
             _advise(notes, "info", ("batt_invert",),
                     f"The battery{who} reads {messages.watts(w)} {doing} "
                     "now, so check the inverter shows the same.")
+        return w
+    return None
 
 
 def _price_check(notes, opts, running, prices_known) -> None: