admin/goodwe-addon
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

UX-15 review: shorter setup banner (PR #147)

Browse Source 
The Home banner title was ten words; UX-08 asks for about six.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Claude review agent
2026-09-28 15:06:12 +02:00
parent 63e7e8a133
commit 30cba1e58d
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
goodwe_controller/DOCS.md
+5 -6
View File
@@ -3244,9 +3244,8 @@ control is started, and whenever the stored settings name no inverter to
control. A site that already ran before is never sent there. control. A site that already ran before is never sent there.
A new install names no inverter yet, so the add-on starts **in setup**: it A new install names no inverter yet, so the add-on starts **in setup**: it
serves the page and sends nothing to any inverter. Home says "Setup: the serves the page and sends nothing to any inverter. Home says "Setup: nothing
add-on controls nothing until setup is done", and there is no Start button. The is controlled yet", and there is no Start button. The installer's steps:
installer's steps:
1. Install the add-on, turn on **Watchdog** on its Info tab, and start it. 1. Install the add-on, turn on **Watchdog** on its Info tab, and start it.
Leave the Configuration tab as it is. Leave the Configuration tab as it is.
@@ -3276,9 +3275,9 @@ inverter stays at 0 W. If the banner is red and says a safety stop stays on,
one of the red rows below is a stop that will still be there when shadow mode one of the red rows below is a stop that will still be there when shadow mode
ends. That row says how to clear it. ends. That row says how to clear it.
In **setup** (a new install that names no inverter yet) the banner says the In **setup** (a new install that names no inverter yet) the banner says
add-on controls nothing until setup is done, and the one row says to finish nothing is controlled yet, and the one row says to finish Setup. See *Setup,
Setup. See *Setup, for a new install*. for a new install*.
| Row starts with | What it tells you | | Row starts with | What it tells you |
|---|---| |---|---|
goodwe_controller/app/messages.py
+1 -1
View File
@@ -385,7 +385,7 @@ def banner_stopped() -> str:
def banner_setup_only() -> str: def banner_setup_only() -> str:
"""UX-15: setup-only mode, where the add-on serves the page and commands """UX-15: setup-only mode, where the add-on serves the page and commands
nothing (app/setuponly.py).""" nothing (app/setuponly.py)."""
return "Setup: the add-on controls nothing until setup is done" return "Setup: nothing is controlled yet"
def row_setup_only() -> str: def row_setup_only() -> str: