From 2ff9be710cea9ff044c504a6d9b0e02e2efb2274 Mon Sep 17 00:00:00 2001 From: glenn schrooyen Date: Thu, 22 Oct 2026 08:37:39 +0200 Subject: [PATCH] PRICE-02: correct the DECISIONS note (which sentences changed, how identity is pinned) Co-Authored-By: Claude --- .../PRICE-02-the-verdict-skips-ended-periods.md | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/goodwe_controller/DECISIONS/PRICE-02-the-verdict-skips-ended-periods.md b/goodwe_controller/DECISIONS/PRICE-02-the-verdict-skips-ended-periods.md index a485730..e4f994e 100644 --- a/goodwe_controller/DECISIONS/PRICE-02-the-verdict-skips-ended-periods.md +++ b/goodwe_controller/DECISIONS/PRICE-02-the-verdict-skips-ended-periods.md @@ -18,10 +18,15 @@ ended (`end <= now`, the span `price._cover_table()` gives, as - An hourly point that is still current stays in, so hourly feeds and the static day/night plan give the same verdict as before. - `now=None` keeps the old reach (the whole series); only tests leave it out. -- The idle sentence now reads "now is not the cheapest or the dearest price - period". Other sentences that say "hour" (AUDIT-01 T6) are not touched here. +- The sentences of this verdict in `arbitrage.py` (status row and action log, + English only) say "price period" where they said "hour": the idle one now + reads "now is not the cheapest or the dearest price period". The UI texts + that say "cheapest hour" (AUDIT-01 T1-T5) are not touched here. - Not changed here: F2 (static profile sampled at HH:00) and F3 (carried value). Measured: with price off, and on a static tariff, every command over the -modes-off replay is byte-identical. On the dynamic replay a sale quotes a -smaller "above the cheapest" figure once the first cheap period is over. +modes-off replay is byte-identical. On the dynamic replay every command is +the same too; only a sale's sentence quotes a smaller "above the cheapest" +figure once the first cheap period is over. The identity pins in +`test_modes_p3.py` and `test_price_run_fixes.py` hide just that figure and the +word change (`opt11p3_identity.trade_digest()`).