TARIFF-17: a price component that varies by hour has somewhere to live
checks / unit (pull_request) Successful in 7m25s
checks / unit (pull_request) Successful in 7m25s
`price.py` modelled the whole non-energy part of a Belgian bill as ONE flat scalar. This adds `price_taxes_profile`, which carries the TAXES component as a period table, and makes `assemble()` evaluate it at each point's own instant. ⚠️ THE FLAT SCALAR WAS NOT A WRONG NUMBER, AND THIS IS NOT A CORRECTION OF ONE. The optimiser reads exactly two quantities off a series - the spread `max - min` over the firm points, and which hour is cheapest - and an additive constant identical in every hour cancels out of the first and leaves the second where it was. It is provably inert. Measured, and printed by test_price.py 16b on every run: with a flat taxes figure of 0.00, 0.0739, 0.1198, 0.1327 or 1.00 EUR/kWh the same 24-hour feed is cheapest at 13:00 in all five cases and its spread is 0.1500 EUR/kWh in all five cases. What was missing is anywhere for an HOUR-VARYING non-energy component to live. This is a missing capability, not a bad constant. Belgium has one. Fluvius distribution is a single rate - its tariff-card row reads `Normaal | Uitsl. nacht`, where exclusive night is a separate physical circuit and not a night register - so nothing changes for the reference site in Flanders. The Walloon DSOs and Sibelga are on the same card with four columns, `Enkelvoudig | Dag | Nacht | Uitsl. nacht`, and the gap is real money (c/kWh): ORES 13,27 / 7,39; AIESH 15,17 / 8,21; Tecteo RESA 12,20 / 7,01; Sibelga 9,39 / 7,10; ORES IMPACT 2026 16,578 / 5,090. ⚠️ AND THE BANDS ARE ANTI-CORRELATED WITH WHAT THE BATTERY WANTS TO DO. The cheap network hours are the cheap spot hours, so flattening them does not shift the curve - it UNDERSTATES the spread and declines cycles that would have paid. Same feed, same markup, the only difference being the taxes argument: flat 0.0000 / 0.0739 / 0.1198 / 0.1327 / 1.0000 -> cheapest hour 13, spread 0.1500 ORES dag 0.1327 / nacht 0.0739 -> cheapest hour 03, spread 0.1788 The regression check grades WHICH HOUR IS CHEAPEST, not the spread: an implementation that reads the table once and adds one number to every point is the LEVEL bucket wearing a period table - right magnitude, wrong shape - and a spread assertion passes on it. Measured: hoisting the lookup out of `assemble()`'s loop (+17 B) is red on six named checks in test_price.py and GREEN in the other 28 files. ONE GRAMMAR, NOT TWO. `static_tariff.py` already shipped the periods, the day selectors, the tiling rule and the DST handling, so `parse_taxes_profile()` is the same parser with the option name and the "what this number means" clause as arguments. A second tiling rule would be a second set of 23- and 25-hour-day bugs. test_static_tariff.py section 10 pins that two ways: by parsing every module under `app/` and asserting the grammar is defined in exactly one of them, and by deriving each of thirteen refusal sentences for the new option from the old option's own sentence rather than transcribing them. `Component.TAXES` semantics, `code_leaks()` and the double-counting guarantee are untouched. The new key joins FRAMEWORK_KEYS, BANNED_IN_PLUGIN_CODE is derived from that set, and a plugin that names it is refused at `register()`. It reaches both plugins that take taxes - `custom_formula` ({ENERGY, MARKUP}) and `generic_dayahead` ({ENERGY}) - and not `manual_csv`, which is all-in: the table is routed through `capabilities().adds`, exactly as the scalar is. ⚠️ A MALFORMED TABLE IS REFUSED AT STARTUP, NOT AT THE NEXT FETCH. It is read on the ~30 s planning path, and a table that first fails at 03:00 is a site that stops pricing at 03:00, which §11.4 turns into a quiet fallback indistinguishable from a healthy fixed-tariff day. validate.py refuses three things: a table that does not tile the day; a table set beside a NON-DEFAULT `price_taxes_eur_kwh`, because the table wins and the scalar would then be a number the operator typed that decides nothing; and a whole card typed in CENTS, which is how these figures are printed. That last rung is not a restatement of the parser's +-10 EUR/kWh bound - ORES's 13,27 trips the parser, but Sibelga's entire card, 9,39 and 7,10, is under it and would otherwise have started as a 9.39 EUR/kWh levy. Both rungs are graded by the REASON each gives, and mutating them together (TEST-16) moves three rows. NOTHING CHANGES FOR A SITE THAT DOES NOT SET IT. The option ships "", and the scalar path is unchanged arithmetically rather than merely in intent: test_price.py 16f reproduces the pre-TARIFF-17 expression and compares 12 capability/scalar combinations point for point with `==`. 13 mutations, every one red on a named check, ledger in test_price.py below section 16k with byte deltas and the one equivalent mutant named. 29/29 green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BwRLw7eKYj2byVdwB6kbjU
This commit is contained in:
co-authored by
Claude Opus 5
parent
c518007caf
commit
2fac0aaf06
@@ -1366,6 +1366,134 @@ check("...and the flat single-inverter config it always refused is refused "
|
||||
-5000, 5000) == [])
|
||||
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------- #
|
||||
print()
|
||||
print("TARIFF-17 - the taxes period table is refused HERE, at startup, and not "
|
||||
"at 03:00")
|
||||
# ⚠️ WHY IT IS REFUSED IN THIS MODULE AND NOT AT FETCH TIME. `price.assemble()`
|
||||
# reads this table on the ~30 s planning path. A table that only fails when a
|
||||
# fetch happens is a site that stops pricing mid-afternoon, and §11.4 turns
|
||||
# that into a quiet fallback indistinguishable on the status page from a
|
||||
# healthy fixed-tariff day. That is `static_profile`'s argument, one option
|
||||
# over, and this is the same rule.
|
||||
_T17_DAG, _T17_NACHT = 0.1327, 0.0739
|
||||
_T17_OK = ('{"periods":['
|
||||
'{"name":"dag","from":"07:00","to":"22:00","days":"mon-fri",'
|
||||
f'"eur_per_kwh":{_T17_DAG}}},'
|
||||
'{"name":"nacht","from":"22:00","to":"07:00","days":"mon-fri",'
|
||||
f'"eur_per_kwh":{_T17_NACHT}}},'
|
||||
'{"name":"nacht","from":"00:00","to":"24:00","days":"sat,sun",'
|
||||
f'"eur_per_kwh":{_T17_NACHT}}}]}}')
|
||||
|
||||
# ⚠️ THE ACCEPTED BASELINE COMES FIRST (MUTATION.md habit 7). Every refusal
|
||||
# below varies ONE thing from this line, so a refusal on the next line has
|
||||
# nowhere else to have come from.
|
||||
check("ORES's real dag/nacht table STARTS - it is a valid configuration, and "
|
||||
"the refusals below are one edit away from this one",
|
||||
validate_startup_config(base(price_taxes_profile=_T17_OK),
|
||||
-5000, 5000) == [])
|
||||
check("...and so does the shipped \"\", which is every install that exists: "
|
||||
"the option is an addition, not a requirement",
|
||||
validate_startup_config(base(price_taxes_profile=""), -5000, 5000) == []
|
||||
and validate_startup_config(base(), -5000, 5000) == [])
|
||||
|
||||
_T17_GAP = ('{"periods":[{"name":"dag","from":"07:00","to":"22:00",'
|
||||
f'"days":"all","eur_per_kwh":{_T17_DAG}}}]}}')
|
||||
_T17_P_GAP = validate_startup_config(base(price_taxes_profile=_T17_GAP),
|
||||
-5000, 5000)
|
||||
print(f" {(_T17_P_GAP or [''])[0][:120]}")
|
||||
check("a table that leaves 00:00-07:00 unpriced is REFUSED, by the same tiling "
|
||||
"rule static_profile has - and the refusal names the KEY and the HOURS, "
|
||||
"not merely that something was wrong",
|
||||
why(_T17_P_GAP, "price_taxes_profile cannot be used:")
|
||||
and why(_T17_P_GAP, "leaves mon 00:00-07:00 with no period"))
|
||||
check("...and it is refused for THAT reason and not as a side effect of "
|
||||
"something else this fixture happens to break: exactly one problem",
|
||||
len(_T17_P_GAP) == 1)
|
||||
|
||||
# ⚠️ TWO WRITERS OF ONE QUANTITY, ONE OF WHICH SILENTLY WINS. The table decides
|
||||
# when it is set, so a scalar left at a NON-DEFAULT value beside it is a number
|
||||
# the operator typed that changes nothing - on the quantity §11.4 makes hardest
|
||||
# to notice.
|
||||
_T17_P_BOTH = validate_startup_config(
|
||||
base(price_taxes_profile=_T17_OK, price_taxes_eur_kwh=0.1198), -5000, 5000)
|
||||
print(f" {(_T17_P_BOTH or [''])[0][:120]}")
|
||||
check("the table AND a non-default price_taxes_eur_kwh is refused, and the "
|
||||
"refusal says WHICH ONE WINS and what to do - not merely that the two "
|
||||
"are incompatible",
|
||||
why(_T17_P_BOTH, "price_taxes_profile is set AND price_taxes_eur_kwh is "
|
||||
"0.1198")
|
||||
and why(_T17_P_BOTH, "THE TABLE WINS"))
|
||||
check("...and the SHIPPED scalar beside the table is NOT refused, or every "
|
||||
"Walloon site would have to clear a key it never touched. The refusal is "
|
||||
"about a value the operator chose, and 0.06 is the one they did not",
|
||||
validate_startup_config(base(price_taxes_profile=_T17_OK,
|
||||
price_taxes_eur_kwh=0.06),
|
||||
-5000, 5000) == []
|
||||
and len(_T17_P_BOTH) == 1)
|
||||
check("...and the same non-default scalar WITHOUT the table still starts, "
|
||||
"which is what makes the line above about the PAIR rather than about "
|
||||
"0.1198 being disliked",
|
||||
validate_startup_config(base(price_taxes_eur_kwh=0.1198),
|
||||
-5000, 5000) == [])
|
||||
|
||||
# ⚠️ THE UNITS RUNG, A SECOND QUANTITY RATHER THAN A RESTATEMENT. Every Belgian
|
||||
# DSO prints these bands in c EUR/kWh, and the whole table is copied off ONE
|
||||
# card - so a factor-100 error lands on every row at once and nothing inside
|
||||
# the table disagrees with itself.
|
||||
#
|
||||
# ⚠️ AND THE TWO RUNGS ARE GRADED SEPARATELY, BY THE REASON EACH GIVES, because
|
||||
# the parser's own +-10 EUR/kWh bound catches SOME of these cards and not
|
||||
# others - and a check that only ever exercised the loud ones would pass with
|
||||
# this rung deleted. ORES's 13,27 is refused by the parser; SIBELGA's whole
|
||||
# card - 9,39 dag against 7,10 nacht, the Brussels DSO - is under 10 in both
|
||||
# bands and reaches this rung alone.
|
||||
_T17_ORES_C = ('{"periods":['
|
||||
'{"name":"dag","from":"07:00","to":"22:00","days":"mon-fri",'
|
||||
'"eur_per_kwh":13.27},'
|
||||
'{"name":"nacht","from":"22:00","to":"07:00","days":"mon-fri",'
|
||||
'"eur_per_kwh":7.39},'
|
||||
'{"name":"nacht","from":"00:00","to":"24:00","days":"sat,sun",'
|
||||
'"eur_per_kwh":7.39}]}')
|
||||
_T17_SIB_C = ('{"periods":['
|
||||
'{"name":"dag","from":"07:00","to":"22:00","days":"mon-fri",'
|
||||
'"eur_per_kwh":9.39},'
|
||||
'{"name":"nacht","from":"22:00","to":"07:00","days":"mon-fri",'
|
||||
'"eur_per_kwh":7.10},'
|
||||
'{"name":"nacht","from":"00:00","to":"24:00","days":"sat,sun",'
|
||||
'"eur_per_kwh":7.10}]}')
|
||||
_T17_P_ORES = validate_startup_config(base(price_taxes_profile=_T17_ORES_C),
|
||||
-5000, 5000)
|
||||
_T17_P_SIB = validate_startup_config(base(price_taxes_profile=_T17_SIB_C),
|
||||
-5000, 5000)
|
||||
print(f" ORES : {(_T17_P_ORES or [''])[0][:110]}")
|
||||
print(f" Sibelga : {(_T17_P_SIB or [''])[0][:110]}")
|
||||
check("ORES's card typed in CENTS is refused by the PARSER's bound, and the "
|
||||
"sentence is the parser's - `beyond +-10.0`, naming the row",
|
||||
why(_T17_P_ORES, "price_taxes_profile cannot be used:")
|
||||
and why(_T17_P_ORES, "beyond +-10.0"))
|
||||
check("...and SIBELGA's whole card - 9,39 and 7,10, BOTH under that bound - is "
|
||||
"refused by THIS rung instead, naming both bands and the factor. Without "
|
||||
"it a Brussels site would price a 9.39 EUR/kWh levy and start",
|
||||
why(_T17_P_SIB, "price_taxes_profile carries [7.1, 9.39] EUR/kWh")
|
||||
and why(_T17_P_SIB, "factor of 100"))
|
||||
check("...and the two refusals are DIFFERENT sentences, so the rungs cannot "
|
||||
"mask each other: deleting the units rung leaves the Sibelga line red "
|
||||
"while the ORES line goes on passing for the parser's reason",
|
||||
_T17_P_ORES != _T17_P_SIB
|
||||
and not why(_T17_P_ORES, "factor of 100")
|
||||
and not why(_T17_P_SIB, "beyond +-10.0"))
|
||||
check("...and BOTH cards divided by 100 start, which is habit 7: the refusals "
|
||||
"above are about the units and not about Brussels or Wallonia",
|
||||
validate_startup_config(
|
||||
base(price_taxes_profile=_T17_ORES_C.replace("13.27", "0.1327")
|
||||
.replace("7.39", "0.0739")), -5000, 5000) == []
|
||||
and validate_startup_config(
|
||||
base(price_taxes_profile=_T17_SIB_C.replace("9.39", "0.0939")
|
||||
.replace("7.10", "0.0710")), -5000, 5000) == [])
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------- #
|
||||
print()
|
||||
if fails:
|
||||
|
||||
Reference in New Issue
Block a user