From 1b343da8e3d30928aaafa2dc64f159ef42aee23d Mon Sep 17 00:00:00 2001 From: glenn schrooyen Date: Tue, 25 Aug 2026 17:35:11 +0200 Subject: [PATCH] DOCS: say plainly that ha_dsmr and mqtt_p1 have never seen real hardware No meter in this installation uses either transport. Both were written to specs.md 5.2's assumption that a Belgian P1 exposes two unsigned registers, which the meter actually fitted here does not - it is the HomeWizard P1 that ha_signed reads. Their only coverage is test_p1.py and an end-to-end test against a fake Home Assistant. Deliberately not called "experimental". That word says the design is unfinished, which is not the defect and is vaguer than the truth; these are complete and reviewed, they have simply never had a real telegram through them. The failure this note is guarding against is a future session debugging a meter problem, treating those two paths as proven, and looking elsewhere. Placed where the mode is chosen rather than in a footnote, because the choice is the decision it should inform. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01Du77usMj8XNKNFZGmUiWDa --- goodwe_controller/DOCS.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/goodwe_controller/DOCS.md b/goodwe_controller/DOCS.md index 403f4a5..fbcf5aa 100644 --- a/goodwe_controller/DOCS.md +++ b/goodwe_controller/DOCS.md @@ -70,6 +70,18 @@ Either way, do not build the missing shape out of template sensors. The point of `meter_source` is that the sign convention is derived in one tested place rather than in YAML nobody reviews underneath a safety input. +> ⚠️ **`ha_dsmr` and `mqtt_p1` have never processed a telegram from real +> hardware.** No meter in this installation uses either one. Both were written +> to the assumption in `specs.md` §5.2 that a Belgian P1 exposes two unsigned +> registers, and the meter actually fitted here does not — it is the HomeWizard +> P1 that `ha_signed` reads. They are covered by the unit checks in `test_p1.py` +> and by an end-to-end test against a fake Home Assistant, and nothing more. +> +> This is recorded because the realistic way it bites is someone debugging a +> meter problem months from now treating those two paths as proven and looking +> for the fault elsewhere. If you are the first person to point one at a real +> meter, expect to find something, and please update this note when you do. + | option | default | meaning | |---|---|---| | `meter_source` | `off` | `off` keeps `meter_entity`. `ha_dsmr` subscribes to the DSMR integration over the HA WebSocket; `mqtt_p1` reads a topic; `ha_signed` subscribes to one signed entity over the HA WebSocket |